doc: clarify fs.utimes() arguments #8651
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
not-an-aardvark
approved these changes
Sep 19, 2016
addaleax
approved these changes
Sep 19, 2016
| `Date.now()`. | ||
| - The value should be a Unix timestamp in seconds. For example, `Date.now()` | ||
| returns milliseconds, so it should be divided by 1000 before passing it in. | ||
| - If the value is a numberable string like `'123456789'`, the value will get |
There was a problem hiding this comment.
nit: I realize it’s copied, but numerable sounds a bit weird to me… maybe just “numeric”?
There was a problem hiding this comment.
Good point. I updated the commit with numeric.
Make it clear that atime and mtime should be in seconds.
dguo
force-pushed
the
8638-fs-utimes-docs
branch
from
2dc1298
to
bd2f332
Compare
jasnell
pushed a commit
that referenced
this pull request
Sep 20, 2016
Make it clear that atime and mtime should be in seconds. PR-URL: #8651 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
|
Landed in 99ab686. Thank you! |
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
Make it clear that atime and mtime should be in seconds. PR-URL: #8651 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
Description of change
Make it clear that the
atimeandmtimearguments tofs.utimes()should be in seconds.Fixes #8638