Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix awkward sentence for fs.utimes() #10005

Closed
wants to merge 1 commit into from

Conversation

dguo
Copy link
Contributor

@dguo dguo commented Dec 1, 2016

Checklist
  • documentation is changed or added
Affected core subsystem(s)

doc

Description of change

I made some minor edits to this documentation with #8651, and I just noticed that one of the sentences sounds awkward, so here's a fix.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Dec 1, 2016
@mscdex
Copy link
Contributor

mscdex commented Dec 1, 2016

First line of the commit message should be <= 50 characters.

@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@dguo dguo changed the title doc: change awkward sounding sentence for fs.utimes() doc: fix awkward sentence for fs.utimes() Dec 1, 2016
@dguo
Copy link
Contributor Author

dguo commented Dec 1, 2016

Thanks. I fixed the commit message.

@cjihrig
Copy link
Contributor

cjihrig commented Dec 5, 2016

I'm not sure what makes this easier to understand.

@dguo
Copy link
Contributor Author

dguo commented Dec 5, 2016

I realize it's very minor, but it sounds quite awkward (to me) when I read it aloud because it uses a passive voice. Please feel free to close this though if you think it's fine the way it is.

@jasnell
Copy link
Member

jasnell commented Dec 5, 2016

Yeah, I really appreciate the contribution but I think I prefer the original

@dguo
Copy link
Contributor Author

dguo commented Dec 5, 2016

Fair enough. Thank you all for taking a look.

@dguo dguo closed this Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants