test: various test improvements #8468
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assert.equal(4, addressType); | ||
| }); | ||
| dns.lookup(null, common.mustCall((error, result, addressType) => { | ||
| if (error) throw error; |
|
Is there any motivation for the changes from |
| `"${process.execPath}"`, | ||
| '-e', | ||
| '"console.error(process.argv)"', | ||
| 'foo', 'bar'].join(' '); |
There was a problem hiding this comment.
Nit: there is one element per line now, what about putting 'bar' on a new line?
|
LGTM once |
jasnell
force-pushed
the
test-improve-tests
branch
from
effca79
to
12ecd42
Compare
|
Updated! PTAL |
lpinca
reviewed
Sep 27, 2016
|
|
||
| var dns = require('dns'); | ||
| const dns = require('dns'); | ||
|
|
||
| // Stub `getaddrinfo` to *always* error. | ||
| cares.getaddrinfo = function() { |
|
LGTM if CI is green. |
* Favor strictEqual * Use const where appropriate * Modernize where possible
jasnell
force-pushed
the
test-improve-tests
branch
from
12ecd42
to
efa87af
Compare
|
New New CI: https://ci.nodejs.org/job/node-test-pull-request/4434/ (since the last one had to be partially aborted) |
|
Failures seem to be unrelated to these changes. |
jasnell
added a commit
that referenced
this pull request
Oct 10, 2016
* Favor strictEqual * Use const where appropriate * Modernize where possible PR-URL: #8468 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in 07b54ec. |
jasnell
added a commit
that referenced
this pull request
Oct 10, 2016
* Favor strictEqual * Use const where appropriate * Modernize where possible PR-URL: #8468 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
* Favor strictEqual * Use const where appropriate * Modernize where possible PR-URL: #8468 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Setting as don't land for v4.x @jasnell please feel free to manually backport |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Various test improvements