Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix url markdown formatting #8933

Closed
wants to merge 1 commit into from
Closed

doc: fix url markdown formatting #8933

wants to merge 1 commit into from

Conversation

squarejaw
Copy link

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

Documentation for the URL module

Description of change

This is very similar to #7817. The single quote throws off the syntax highlighting in the diagram describing the URL Object when the documentation is viewed on the Node.js web site. I've implemented a similar fix for the affected section.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. labels Oct 5, 2016
@mscdex
Copy link
Contributor

mscdex commented Oct 5, 2016

LGTM

lpinca
lpinca approved these changes Oct 5, 2016
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

claudiorodriguez
claudiorodriguez approved these changes Oct 5, 2016
View reviewed changes
Copy link
Contributor

@claudiorodriguez claudiorodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Fishrock123 pushed a commit that referenced this pull request Oct 5, 2016
@Fishrock123
doc: fix markdown formatting in url.md
3723806 
Tangentially related to #7817

PR-URL: #8933
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123
Copy link
Contributor

Thanks! Landed in 3723806 with a minor commit re-word. :)

@Fishrock123 Fishrock123 closed this Oct 5, 2016
jasnell pushed a commit that referenced this pull request Oct 6, 2016
@jasnell
doc: fix markdown formatting in url.md
6ff13c9 
Tangentially related to #7817

PR-URL: #8933
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
@Fishrock123
doc: fix markdown formatting in url.md
e7039cd 
Tangentially related to #7817

PR-URL: #8933
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@claudiorodriguez claudiorodriguez claudiorodriguez approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@squarejaw @mscdex @Fishrock123 @lpinca @cjihrig @claudiorodriguez @MylesBorins @nodejs-github-bot