Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove VS 2013 compatibility hacks #8067

Merged
merged 2 commits into from
Sep 23, 2016

Conversation

bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented Aug 11, 2016

We can remove some Visual Studio 2013-specific workarounds now that
support for that compiler has officially been dropped.

Refs: #7484
Refs: #8049

("has been dropped" == future tense.)

The last commit is something I can drop if people feel it's less readable.

CI: https://ci.nodejs.org/job/node-test-pull-request/3625/ (expected to fail on the vs2013 buildbots.)

@bnoordhuis bnoordhuis added c++ Issues and PRs that require attention from people who are familiar with C++. windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. lib / src Issues and PRs related to general changes in the lib or src directory. labels Aug 11, 2016
@jasnell
Copy link
Member

jasnell commented Aug 11, 2016

more or less rubber stamp LGTM if CI is green where it should be

@bnoordhuis
Copy link
Member Author

There were some rather strange errors on the fedora22 and fedora23 builbots. New CI, just in case: https://ci.nodejs.org/job/node-test-pull-request/3628/

@joaocgreis
Copy link
Member

Working on the bits for not using VS2013 on v6 and after, already working for the compile job: https://ci.nodejs.org/job/node-test-pull-request/3669/ But the test job will have to run on machines with VS2013, because we still support building native modules with that. Will have to work more on that.

It's great to have this work ready, but perhaps this should only land after we have the release servers ready, so that non-LTS releases of v6 don't have to work around this.

@bnoordhuis
Copy link
Member Author

That's fine, there is no rush to land this.

@joaocgreis
Copy link
Member

#8412 is my suggestion to unblock this. After it lands, CI for this should be all green: test machines (vcbuild noprojgen nobuild nosign test-ci) will no longer try to find Visual Studio, node-gyp will handle that independently.

@joaocgreis
Copy link
Member

#8412 has landed, here is a passing CI: https://ci.nodejs.org/job/node-test-commit/4954/

Changes in vcbuild.bat now LGTM.

@bnoordhuis bnoordhuis force-pushed the drop-vs2013 branch 2 times, most recently from 62e8931 to a0b6a4d Compare September 16, 2016 08:49
@bnoordhuis
Copy link
Member Author

Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We can remove some Visual Studio 2013-specific workarounds now that
support for that compiler has officially been dropped.

PR-URL: nodejs#8067
Refs: nodejs#7484
Refs: nodejs#8049
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joao Reis <reis@janeasystems.com>
Support for Visual Studio 2013 has officially been dropped, remove the
build option for that compiler.

PR-URL: nodejs#8067
Refs: nodejs#7484
Refs: nodejs#8049
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joao Reis <reis@janeasystems.com>
@bnoordhuis bnoordhuis closed this Sep 23, 2016
@bnoordhuis bnoordhuis deleted the drop-vs2013 branch September 23, 2016 16:07
@bnoordhuis bnoordhuis merged commit a3f861d into nodejs:master Sep 23, 2016
jasnell pushed a commit that referenced this pull request Sep 29, 2016
We can remove some Visual Studio 2013-specific workarounds now that
support for that compiler has officially been dropped.

PR-URL: #8067
Refs: #7484
Refs: #8049
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joao Reis <reis@janeasystems.com>
jasnell pushed a commit that referenced this pull request Sep 29, 2016
Support for Visual Studio 2013 has officially been dropped, remove the
build option for that compiler.

PR-URL: #8067
Refs: #7484
Refs: #8049
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joao Reis <reis@janeasystems.com>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
We can remove some Visual Studio 2013-specific workarounds now that
support for that compiler has officially been dropped.

PR-URL: #8067
Refs: #7484
Refs: #8049
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joao Reis <reis@janeasystems.com>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
Support for Visual Studio 2013 has officially been dropped, remove the
build option for that compiler.

PR-URL: #8067
Refs: #7484
Refs: #8049
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joao Reis <reis@janeasystems.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants