Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete workaround in src/util.h #8284

Closed
joemmett opened this issue Aug 26, 2016 · 2 comments
Closed

Obsolete workaround in src/util.h #8284

joemmett opened this issue Aug 26, 2016 · 2 comments
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.

Comments

@joemmett
Copy link

  • Version: v7.0.0-pre
  • Platform: Windows 10 64-bit
  • Subsystem:

src/util.h contains the following workaround for Windows builds:

// VS 2013 doesn't understand dependent templates.

ifdef _MSC_VER

define ListNodeMember(T) ListNodeMember

else

define ListNodeMember(T) ListNodeMember

endif

This is now obsolete with VS2015, which can compile the uses of ListNodeMember without the workaround. The workaround is actually creating ill-formed code that was accepted by VS2013 and 2015, but starting with the next version of the MS compiler this code will be rejected as a use of a template alias with no argument list. The workaround can be proactively removed now to avoid build breaks when the new MSVC compiler is released.

@mscdex
Copy link
Contributor

mscdex commented Aug 26, 2016

See #8067

@mscdex mscdex added windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. labels Aug 26, 2016
@addaleax
Copy link
Member

addaleax commented Apr 30, 2017

I think this has been addressed in #8067, let me know if I’m mistaken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

No branches or pull requests

3 participants