Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inspector: fix minor issues #8890

Closed
wants to merge 1 commit into from
Closed

inspector: fix minor issues #8890

wants to merge 1 commit into from

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Oct 1, 2016 •
edited
Loading

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
  • inspector
Description of change

Fixes a couple of minor issues found during static analysis.

CI: https://ci.nodejs.org/job/node-test-pull-request/4353/

@mscdex mscdex added c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol labels Oct 1, 2016
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol labels Oct 1, 2016
addaleax
addaleax approved these changes Oct 1, 2016
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

alexkozy
alexkozy approved these changes Oct 2, 2016
View reviewed changes
Copy link
Member

@alexkozy alexkozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fhinkel
Copy link
Member

fhinkel commented Oct 3, 2016

Thanks. Landed in 13481d0

@fhinkel fhinkel closed this Oct 3, 2016
fhinkel pushed a commit that referenced this pull request Oct 3, 2016
@mscdex @fhinkel
inspector: fix minor issues
13481d0 
PR-URL: #8890
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@mscdex mscdex deleted the inspector-minor-fixes branch October 3, 2016 14:36
jasnell pushed a commit that referenced this pull request Oct 6, 2016
@mscdex @jasnell
inspector: fix minor issues
450b4ae 
PR-URL: #8890
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
@mscdex @Fishrock123
inspector: fix minor issues
573d8bc 
PR-URL: #8890
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

@alexkozy alexkozy alexkozy approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mscdex @fhinkel @alexkozy @addaleax @MylesBorins @nodejs-github-bot