Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: modernize JS and tighten equality checking #8602

Closed
wants to merge 1 commit into from
Closed

test: modernize JS and tighten equality checking #8602

wants to merge 1 commit into from

Conversation

wzoom
Copy link
Contributor

@wzoom wzoom commented Sep 17, 2016 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

Changed var --> const and let.
Changed assert.equal --> assert.strictEqual
Cleanup according to nodejs/code-and-learn#56

@wzoom
test: modernize JS and tighten equality checking
0abe125 
Changed var --> const and let.
Changed assert.equal --> assert.strictEqual
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 17, 2016
cjihrig
cjihrig approved these changes Sep 17, 2016
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mscdex mscdex added the child_process Issues and PRs related to the child_process subsystem. label Sep 17, 2016
addaleax
addaleax approved these changes Sep 17, 2016
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a green CI

imyller
imyller approved these changes Sep 19, 2016
View reviewed changes
Copy link
Member

@imyller imyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imyller imyller self-assigned this Sep 19, 2016
@imyller
Copy link
Member

imyller commented Sep 19, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/4133/

@imyller
Copy link
Member

imyller commented Sep 19, 2016 •
edited
Loading

Any objections to changing commit title to test: cleanup test-child-process-disconnect.js test: improve child-process-disconnect test when landing? Better ideas?

@imyller
Copy link
Member

imyller commented Sep 20, 2016

I'll start landing this. We've got three LGTMs and CI passed.

imyller pushed a commit that referenced this pull request Sep 20, 2016
@wzoom @imyller
test: cleanup test-child-process-disconnect.js
13e110d 
Changed var --> const and let
Changed assert.equal --> assert.strictEqual

PR-URL: #8602
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
@imyller
Copy link
Member

imyller commented Sep 20, 2016

landed in 13e110d

Thank you for your contribution, @wzoom

@imyller imyller closed this Sep 20, 2016
@imyller imyller removed their assignment Sep 20, 2016
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
@wzoom @Fishrock123
test: cleanup test-child-process-disconnect.js
14025db 
Changed var --> const and let
Changed assert.equal --> assert.strictEqual

PR-URL: #8602
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@imyller imyller imyller approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@wzoom @imyller @addaleax @cjihrig @mscdex @MylesBorins @nodejs-github-bot