test: update equal to strictEqual & function to arrow function #8596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Sep 17, 2016
| @@ -11,12 +11,12 @@ fs.read(fd, | |||
| expected.length, | |||
| 0, | |||
| 'utf-8', | |||
| common.mustCall(function(err, str, bytesRead) { | |||
| common.mustCall((err, str, bytesRead) => { | |||
| assert.ok(!err); | |||
There was a problem hiding this comment.
This could be assert.ifError(err);, which gives slightly more information when anything fails.
|
Changed .ok to .ifError as suggested. Ready for re-review. |
|
Thank you! |
jasnell
pushed a commit
that referenced
this pull request
Sep 22, 2016
* Replace equal with strictEqual * Update functions to arrow functions PR-URL: #8596 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in 0718dd9. thank you! |
jasnell
pushed a commit
that referenced
this pull request
Sep 29, 2016
* Replace equal with strictEqual * Update functions to arrow functions PR-URL: #8596 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
* Replace equal with strictEqual * Update functions to arrow functions PR-URL: #8596 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change