4.3 dev issue with the navigation menu #40235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [4.4] set the correct version number for 4.4 code review the only thing not changed that should be are some of the dates and codenames in version.php * status
* db * front test * architecture * tests * more tests * dist * reame * connections test * resolve * better connection handling * more tests * do not cache the connection * debug * error check * debug * move cleanup to each spec file * missing field * postgres support * cs * escape column names * Determine pgsql type of drone correctly * pg no backticks * after * Support multiple layouts * new test * after * case * postgres needs double quotes
* lint tests files * Fix tests * lint new tests
* Move db setup code to plugins file * require
* Track inserted items and delete them when test has finished * Add mod_articles_news system test * no cleanup in the test
* Add mod_footer system test * better description
* Converting from File::exists() to is_file() * Removing duplicate lines * Cleaning path
* Update mod_users_latest.xml * Update UsersLatestHelper.php * Create Dispatcher.php * Delete modules/mod_users_latest/Dispatcher directory * Create provider.php * Create Dispatcher.php * Delete mod_users_latest.php * Delete Factory class Delete Factory class * services `folder module="mod_users_latest">mod_users_latest.php</folder>` becomes `<folder module="mod_articles_latest">services</folder>` * cleaner code replace $user = $app->getIdentity(); * Add mod_users_latest system test mod_users_latest system test * correction syntax error * replace code * create a user create a user for the test * add registerDate registerDate: '2023-03-01 20:00:00' * add params params: '' --------- Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>
* Default the ordering parameter in the latest articles module * cs
* Make UsersLatestHelper backward compatible * Add replacement in deprecated message
* cypress_test_for_com_contact * update_code_style * updates
* tests * api * artiucles crud * banners * contact * media * media * Remove codeception * cs * more traces of codeception * readd certs * dependencies * more deps * secret * cs * better doc * write * config workaround * cs * revert * prepare db for api tests * variable * revert pool * end connections * no limit * cs * prefix * Update tests/cypress/drone-system-run.sh * run specific specs in drone * Update tests/README.md Co-authored-by: Brian Teeman <brian@teeman.net> * Update tests/cypress/integration/api/com_media/Files.cy.js Co-authored-by: Brian Teeman <brian@teeman.net> * Update tests/cypress/integration/api/com_media/Files.cy.js Co-authored-by: Brian Teeman <brian@teeman.net> * postgres * media on postgres * sign * cs * remove more traces * basic api tests * cleanup * path * run recursive specs * chmod images folder * path to cms * correct dependencies and better cleanup * cleaner deps * Update tests/cypress/drone-system-run.sh Co-authored-by: Brian Teeman <brian@teeman.net> * missing fields * stabilize cleanup * cs * secret in install test * order of tests * optimize cleanup * cs * cache the connection * revert connection cache * docs * Rename cypress to system * lint * simplification and docs * docs * better cleanup * move * merge conflict * remove redundant connect --------- Co-authored-by: Brian Teeman <brian@teeman.net>
…odule helper (#40156) * change version + text * change version + text * change version + text * rename none static to non-static * rename none static to non-static * rename none static to non-static * rename none static to non-static
Change the description to more accurately describe what is being tested
* not featured test * fix code style * updates * fixed code style
* Update mod_footer.xml
* Update default.php
* Create provider.php
* Create Dispatcher.php
* Create Dispatcher.php
* Update Dispatcher.php
* Delete Dispatcher.php
* Create FooterHelper.php
* Delete mod_footer.php
* Delete FooterHelper.php
Is no longer necessary
* Delete line
no need to use Helper
* Delete some use statements
No longer necessary
* new variable
$list moved by $lineOne
* Some changes
Forgot somethingto change
* no chanching layout variable
$data['lineOne'] to $data['lineone']
* No changing layout variable
$lineOne to $lineone
* Removed comment code
* return void
* replaces defined to be consistent
Oops
* defined('_JEXEC') or die;
More consistent with other provider.php files
* correction
Small type
* no static class
harder to write unit tests for it
* empty variable added
* Update Dispatcher.php
* Convert installer plugins to service providers * cs * system tests * 6 * move to system folder * restore and correct folder
* test for contact form * updates * updates * add a blank line at last * updates * updates * updates * updates * adding endline * Update and rename Form.cy.js to contact_details_page.cy.js * Rename contact_details_page.cy.js to Contact.cy.js * Update Contact.cy.js * Update Contact.cy.js * Update Contact.cy.js * Update Contact.cy.js --------- Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>
* Update pagenavigation.xml * Delete pagenavigation.php * Create provider.php * Create PageNavigation.php * Update default.php * Update default.php * correction * correction * Delete PageNavigation.php * Delete provider.php * correction wrong folder * correction wrong folder * correction wrong file * removed @phpcs:disable .... * use Text methods instead * oops __DEPLOY_VERSION__ _DEPLOY_VERSION__ becomes __DEPLOY_VERSION__ --------- Co-authored-by: Martin Carl Kopp <6154099+MacJoom@users.noreply.github.com>
…er>src</folder> (#40204) * swap services to src * swap services to src * swap services to src * swap services to src * swap services to src * swap services to src
* Split the back end CRUD tests into single tests * change to install * cs * types * login * id? * cache login * cs * clear on logout
* add test for field com_contact * updates * changes * changes * updates * updates * adding more default values * updates * updates * Update db.js --------- Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>
…0178) * add categories view for contacts * changes * changes * updates * updates * adding more default values * Update db.js * Update Categories.cy.js * Update db.js --------- Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>
* Test not featured articles * cs * strict * fix ---------
…0224) * Introduce local variables to replace repeating method calls * CS * Move variable higher
* Set a higher timeout for cypress verification * debug * map * simpler commands * wrong
Mohammadkhan18
requested review from
laoneo,
rdeutz,
Hackwar,
fancyFranci,
zero-24 and
wilsonge
as code owners
joomla-cms-bot
added
Composer Dependency Changed
Language Change
* change JPATH_PLATFORM * change JPATH_PLATFORM * change JPATH_PLATFORM * change JPATH_PLATFORM * change JPATH_PLATFORM * change JPATH_PLATFORM
* Convert user plugins to service provider * form path * Update plugins/user/contactcreator/services/provider.php Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update plugins/user/joomla/services/provider.php Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update plugins/user/profile/services/provider.php Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update plugins/user/terms/services/provider.php Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update plugins/user/token/services/provider.php Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update plugins/user/joomla/src/Extension/Joomla.php Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update plugins/user/joomla/src/Extension/Joomla.php Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * revert debug * private * Fix account notification email language (#28) * Update plugins/user/joomla/src/Extension/Joomla.php Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * minor change --------- Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> Co-authored-by: Tuan Pham Ngoc <github@joomdonation.com>
* Convert privacy plugins to service provider * Update plugins/privacy/contact/services/provider.php Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update plugins/privacy/content/services/provider.php Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update plugins/privacy/content/services/provider.php Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update plugins/privacy/message/services/provider.php Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update plugins/privacy/message/src/Extension/Message.php Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * rename --------- Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
|
@Mohammadkhan18 Can it be that you have made this PR for the wrong branch? It is made against the 4.3-dev branch of the CMS but from the 4.4-dev branch of your repo, and it shows all differences between 4.4-dev and 4.3-dev, too, when you check the changes of your PR on GitHub. So I think you should change the base branch. You can do that by using the "Edit" button right beside the title of your PR on GitHub. And does your PR solve issue #37926 ? If so, please change the Thanks in advance. |
Mohammadkhan18
changed the title
Yeah I have tried changing my base to 4.4 but doesn't allowing me to do that |
@Mohammadkhan18 I see. That's because you have used your 4.4-dev branch for that PR. Could you create a new branch based on the 4.4-dev branch and then do your changes again and make a new PR? You can find here some information on how to use GitHub to do that: https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests . Thanks in advance. |
|
Oh ok thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #37926
Issue with navigation menu and breakpoints
Clean installation of joomla 4.1.4 without any changes.
I noticed that on screens with resolutions between 768px (medium) and 992px (large), the navigation menu does not collapse to hamburger menu.
so i have change the bootstrap class it will automatically turn into a hamburger menu at smaller screen
related to #37926
Summary of Changes
After changing the class now the nav is responsive
Actual result BEFORE applying this Pull Request
No hamburger menu is created
Expected result AFTER applying this Pull Request
Automatically hamburger menu will created when screen size is reduced
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed