Move API system tests to cypress #40135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
Composer Dependency Changed
NPM Resource Changed
|
@dgrammatiko can you have a look here if the lint:testjs command can somehow be merged into the lint:js command? Thanks. |
|
You could add another line that fires the existing tasks ie: "lint:js": "npm run lints-src && lint:testjs",
"lint:js-src": "eslint --config build/.eslintrc --ignore-pattern '/media/' --ext .es6.js,.es6,.vue,.cy.js .",
"lint:testjs": "eslint --config build/.eslintrc --ext .js tests/cypress",or combine these as one task, ie: "lint:js": "eslint --config build/.eslintrc --ignore-pattern '/media/' --ext .es6.js,.es6,.vue,.cy.js . && eslint --config build/.eslintrc --ext .js tests/cypress", |
brianteeman
reviewed
Mar 16, 2023
brianteeman
reviewed
Mar 16, 2023
brianteeman
reviewed
Mar 16, 2023
laoneo
changed the title
Co-authored-by: Brian Teeman <brian@teeman.net>
wilsonge
reviewed
Mar 20, 2023
| @@ -146,7 +146,7 @@ private function checkMimeType($mime, $component = 'com_media'): bool | |||
| ); | |||
|
|
|||
| // Get the mime type configuration | |||
| $allowedMime = array_map('trim', explode(',', $allowedMime)); | |||
| $allowedMime = array_map('trim', explode(',', str_replace('\\', '', $allowedMime))); | |||
There was a problem hiding this comment.
I'm sorry if you've had to change the code here as part of this PR it needs properly testing. Merging stuff without any changes when you're changing library code is wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the Joomla API tests to cypress and removes the whole codeception dependency. There is only one remaining system tests for the back end media manager. As these tests are not executed in drone they will be ported in a second step.
Beside that it renames the tests/cypress folder to tests/System to be more inline with Unit and Integration.