Cypress test for contact form in com_contact. #40171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you directly open the contact details page instead of going through the list? |
laoneo
reviewed
Mar 22, 2023
tests/System/integration/site/components/com_contact/Form.cy.js
Outdated
Show resolved
Hide resolved
laoneo
reviewed
Mar 22, 2023
tests/System/integration/site/components/com_contact/Form.cy.js
Outdated
Show resolved
Hide resolved
laoneo
reviewed
Mar 22, 2023
tests/System/integration/site/components/com_contact/Form.cy.js
Outdated
Show resolved
Hide resolved
laoneo
reviewed
Mar 22, 2023
laoneo
reviewed
Mar 22, 2023
laoneo
reviewed
Mar 23, 2023
tests/System/integration/site/components/com_contact/Form.cy.js
Outdated
Show resolved
Hide resolved
|
Can you also rename the file to Contact.cy.js as it is the contact details page, just showing the form. |
|
To fit the current naming strategy, Contact.cy.js would be enough for the file name. The rest looks ok. |
laoneo
reviewed
Mar 23, 2023
tests/System/integration/site/components/com_contact/Contact.cy.js
Outdated
Show resolved
Hide resolved
laoneo
reviewed
Mar 23, 2023
tests/System/integration/site/components/com_contact/Contact.cy.js
Outdated
Show resolved
Hide resolved
|
Thanks! |
|
Thanks a lot for merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test for contact form in com_contact.