-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.4] Rebuild plugin PageNavigation with new Joomla 4 structure #40142
Conversation
wrong folder
wrong folder
wrong file
plugins/content/pagenavigation/src/Extension/PageNavigation.php
Outdated
Show resolved
Hide resolved
I have tested this item ✅ successfully on 6564797 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40142. |
I have tested this item ✅ successfully on ba76e94 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40142. |
@toivo Could you please help testing this PR again? Thanks. |
Related to #40146 to get consistent code |
I have tested this item ✅ successfully on ba76e94 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40142. |
RTC. If decision is using This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40142. |
_DEPLOY_VERSION__ becomes __DEPLOY_VERSION__
Slip of the pen, (last) correction in code 😅 |
* Add deleted files from #40066 , #40092 , #40142 and #40146 * Add deleted files from #40180 and #40174 * Add deleted files from #39527 , #39535 , #40169 and #40173 * Add deleted files from #39552 , #39931 , #39628 and #40328 * Add deleted files from #40216 * Add deleted files from #40561 , #40190 and #40205
Pull Request for Issue # .
Summary of Changes
Rebuild plugin PageNavigation with new Joomla 4 structure
Replacing (some) deprecated classes
Testing Instructions
Code review
Just try to use it as usual
Actual result BEFORE applying this Pull Request
Plugin works
Expected result AFTER applying this Pull Request
Plugin works
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed