Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Rebuild plugin PageNavigation with new Joomla 4 structure #40142

Merged
merged 19 commits into from
Mar 23, 2023

Conversation

sandewt
Copy link
Contributor

@sandewt sandewt commented Mar 17, 2023

Pull Request for Issue # .

Summary of Changes

Rebuild plugin PageNavigation with new Joomla 4 structure
Replacing (some) deprecated classes

Testing Instructions

Code review
Just try to use it as usual

Actual result BEFORE applying this Pull Request

Plugin works

Expected result AFTER applying this Pull Request

Plugin works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@phpcs:disable ....
@toivo
Copy link
Contributor

toivo commented Mar 18, 2023

I have tested this item ✅ successfully on 6564797

Tested successfully in Joomla 4.4.0-dev of 18 March using PHP 8.1.10


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40142.

@joomdonation
Copy link
Contributor

I have tested this item ✅ successfully on ba76e94

Works well. Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40142.

@joomdonation
Copy link
Contributor

@toivo Could you please help testing this PR again? Thanks.

@sandewt
Copy link
Contributor Author

sandewt commented Mar 19, 2023

Related to #40146 to get consistent code

@toivo
Copy link
Contributor

toivo commented Mar 20, 2023

I have tested this item ✅ successfully on ba76e94

Tested successfully in Joomla 4.4.0-dev of 20 March using PHP 8.1.10


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40142.

@joomdonation
Copy link
Contributor

joomdonation commented Mar 20, 2023

RTC. If decision is using $lang->_ method instead of Text::_, we can do a a separate PR to change plugin layoutfile.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40142.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 20, 2023
@MacJoom MacJoom self-assigned this Mar 22, 2023
MacJoom and others added 2 commits March 22, 2023 10:11
_DEPLOY_VERSION__
becomes
__DEPLOY_VERSION__
@sandewt
Copy link
Contributor Author

sandewt commented Mar 22, 2023

Slip of the pen, (last) correction in code 😅

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 23, 2023
@MacJoom MacJoom added this to the Joomla! 4.4.0 milestone Mar 23, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 29, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 29, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 30, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Apr 4, 2023
@sandewt sandewt deleted the patch-5 branch April 26, 2023 08:57
richard67 added a commit to richard67/joomla-cms that referenced this pull request Apr 30, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 9, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 22, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 23, 2023
laoneo pushed a commit that referenced this pull request May 23, 2023
* Add deleted files from #40066 , #40092 , #40142 and #40146

* Add deleted files from #40180 and #40174

* Add deleted files from #39527 , #39535 , #40169 and #40173

* Add deleted files from #39552 , #39931 , #39628 and #40328

* Add deleted files from #40216

* Add deleted files from #40561 , #40190 and #40205
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 27, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 3, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 8, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 23, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 3, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 23, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 12, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 19, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 20, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 22, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 1, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 4, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 4, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 14, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 19, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 26, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants