Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert mod_articles_category to new structure #39527

Merged
merged 41 commits into from
Apr 3, 2023

Conversation

carlitorweb
Copy link
Member

Summary of Changes

This PR converts mod_articles_category to the new structure

Testing Instructions

  • Use Joomla 4.3
  • Create an instance of the module Articles Category. Note how it works.
  • Apply patch
  • Delete administrator/cache/autoload_psr4.php
  • Refresh the page, make sure the module still displays the same as before.

@richard67
Copy link
Member

@carlitorweb Unfortunately you have made the moving of the file and the changes inside the moved file with the same one commit, so GitHub does not show a moved and changed file but a deleted and a new file, so the history got lost. To avoid that, moving a file and changing its content have to be made with 2 separate commits. It’s not a big problem, but please remember that for future PR‘s.

@carlitorweb
Copy link
Member Author

@carlitorweb Unfortunately you have made the moving of the file and the changes inside the moved file with the same one commit, so GitHub does not show a moved and changed file but a deleted and a new file, so the history got lost. To avoid that, moving a file and changing its content have to be made with 2 separate commits. It’s not a big problem, but please remember that for future PR‘s.

Copy that. Really not notice this when doing the changes, sorry. If is neccessary I can do all again, not problem.

@richard67
Copy link
Member

If is neccessary I can do all again, not problem.

@carlitorweb Not necessary. All ok.

@laoneo laoneo added the Maintainers Checked Used if the PR is conceptional useful label Dec 31, 2022
@laoneo
Copy link
Member

laoneo commented Dec 31, 2022

@richard67 sometimes, even when you rename a file and do a lot of changes, git is not able to detect the rename.

@carlitorweb thank you very much, now we need the two tests to get it merged.

@carlitorweb
Copy link
Member Author

@laoneo you are welcome, glad to help. I will continue with the rest.

@ReLater
Copy link
Contributor

ReLater commented Dec 31, 2022

I don't know how "hungry" $db = $this->getDatabase(); is, but as far as I see $db is only used once. Maybe it's more efficient to move this->getDatabase down to the place where it's used (if it's used)?

                case 'random':
                    $articlesModel->setState('list.ordering', $this->getDatabase()->getQuery(true)->rand());
                    break;

@carlitorweb carlitorweb changed the base branch from 4.3-dev to 4.4-dev March 11, 2023 21:12
@laoneo laoneo self-assigned this Mar 20, 2023
@laoneo
Copy link
Member

laoneo commented Mar 21, 2023

Would it be possible to write also a system test for this module, similar as we did in #40092? If you need help how to get started with system tests, you can find some information here.

@Quy Quy added this to the Joomla! 4.4.0 milestone Apr 4, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Apr 4, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Apr 4, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Apr 30, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 9, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 22, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 23, 2023
laoneo pushed a commit that referenced this pull request May 23, 2023
* Add deleted files from #40066 , #40092 , #40142 and #40146

* Add deleted files from #40180 and #40174

* Add deleted files from #39527 , #39535 , #40169 and #40173

* Add deleted files from #39552 , #39931 , #39628 and #40328

* Add deleted files from #40216

* Add deleted files from #40561 , #40190 and #40205
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 27, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 3, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 8, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 23, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 3, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 23, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 12, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 19, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 20, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 22, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 1, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 4, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 4, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 14, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 19, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 26, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Oct 1, 2023
@carlitorweb carlitorweb deleted the convert_mod_articles_category branch May 12, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants