-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert mod_articles_category to new structure #39527
Convert mod_articles_category to new structure #39527
Conversation
@carlitorweb Unfortunately you have made the moving of the file and the changes inside the moved file with the same one commit, so GitHub does not show a moved and changed file but a deleted and a new file, so the history got lost. To avoid that, moving a file and changing its content have to be made with 2 separate commits. It’s not a big problem, but please remember that for future PR‘s. |
Copy that. Really not notice this when doing the changes, sorry. If is neccessary I can do all again, not problem. |
@carlitorweb Not necessary. All ok. |
@richard67 sometimes, even when you rename a file and do a lot of changes, git is not able to detect the rename. @carlitorweb thank you very much, now we need the two tests to get it merged. |
@laoneo you are welcome, glad to help. I will continue with the rest. |
I don't know how "hungry"
|
…rlitorweb/joomla-cms into convert_mod_articles_category
* Add deleted files from #40066 , #40092 , #40142 and #40146 * Add deleted files from #40180 and #40174 * Add deleted files from #39527 , #39535 , #40169 and #40173 * Add deleted files from #39552 , #39931 , #39628 and #40328 * Add deleted files from #40216 * Add deleted files from #40561 , #40190 and #40205
Summary of Changes
This PR converts mod_articles_category to the new structure
Testing Instructions