Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert sampledata plugins to service provider #40173

Merged
merged 5 commits into from
Apr 3, 2023

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Mar 22, 2023

Summary of Changes

Converts the media action plugins to service providers.

Testing Instructions

Install sample data from the control panel of joomla.

Actual result BEFORE applying this Pull Request

All works.

Expected result AFTER applying this Pull Request

All works.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@ghazal
Copy link
Contributor

ghazal commented Mar 24, 2023

I have tested this item ✅ successfully on 2b4d0a4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40173.

@MacJoom MacJoom self-assigned this Mar 28, 2023
@heelc29
Copy link
Contributor

heelc29 commented Apr 1, 2023

I have tested this item ✅ successfully on 57f89a8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40173.

@joomdonation
Copy link
Contributor

I have tested this item ✅ successfully on 57f89a8

Code review. Real testing by installing blog and multilingual sample data, all works well.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40173.

@joomdonation
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40173.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 2, 2023
@MacJoom MacJoom merged commit f7e458f into joomla:4.4-dev Apr 3, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 3, 2023
@MacJoom MacJoom added this to the Joomla! 4.4.0 milestone Apr 3, 2023
@laoneo laoneo deleted the provider/plugins/sampledata branch April 4, 2023 05:59
richard67 added a commit to richard67/joomla-cms that referenced this pull request Apr 4, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Apr 4, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Apr 30, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 9, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 22, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 23, 2023
laoneo pushed a commit that referenced this pull request May 23, 2023
* Add deleted files from #40066 , #40092 , #40142 and #40146

* Add deleted files from #40180 and #40174

* Add deleted files from #39527 , #39535 , #40169 and #40173

* Add deleted files from #39552 , #39931 , #39628 and #40328

* Add deleted files from #40216

* Add deleted files from #40561 , #40190 and #40205
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 27, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 3, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 8, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 23, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 3, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 23, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 12, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 19, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 20, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 22, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 1, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 4, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 4, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 14, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 19, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 26, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants