Rebuild mod_custom with new Joomla 4 structure #39931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@richard67 what does the drone not like? |
richard67
reviewed
Feb 25, 2023
richard67
reviewed
Feb 25, 2023
sandewt
reviewed
Feb 25, 2023
sandewt
reviewed
Feb 25, 2023
sandewt
reviewed
Feb 25, 2023
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
sandewt
reviewed
Feb 25, 2023
richard67
reviewed
Feb 27, 2023
laoneo
reviewed
Feb 28, 2023
|
As only code style issues are fixed since the tests and the new custom module system test is passing. I'm going to merge this one. @sergeytolkachyov thank you very much for your contribution. Just a small remark. In the future I would do an independent branch for your next pull request and not directly the 4.3-dev (or any other -dev) branch. |
Hello. Thanks for remark. So, how will I do: create fork, then create branch? |
|
Yes, create a branch from the 4.4 branch, which must be identically to the one from this repository. |
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
May 1, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
May 1, 2023
2 tasks
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
May 9, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
May 22, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
May 23, 2023
laoneo
pushed a commit
that referenced
this pull request
May 23, 2023
* Add deleted files from #40066 , #40092 , #40142 and #40146 * Add deleted files from #40180 and #40174 * Add deleted files from #39527 , #39535 , #40169 and #40173 * Add deleted files from #39552 , #39931 , #39628 and #40328 * Add deleted files from #40216 * Add deleted files from #40561 , #40190 and #40205
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
May 27, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jun 3, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jun 8, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jun 23, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jul 3, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jul 23, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Aug 12, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Aug 19, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Aug 20, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Aug 22, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 1, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 4, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 4, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 14, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 19, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 26, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Module Custom HTML has rebuilded with new Joomla 4 structure
Testing Instructions
Just try to use it as usual.
Actual result BEFORE applying this Pull Request
Module works
Expected result AFTER applying this Pull Request
Module works
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed