[4.4] Make UsersLatestHelper backward compatible #40143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, can you add the deprecated version like we do in #38657. And the target version should be 6.0. |
Done. |
|
Thanks! |
|
Thks |
sandewt
reviewed
Mar 20, 2023
Comment on lines
+88
to
98
| * @deprecated __DEPLOY_VERSION__ will be removed in 6.0 | ||
| * Use the none static method getLatestUsers | ||
| * Example: Factory::getApplication()->bootModule('mod_users_latest', 'site') | ||
| * ->getHelper('UsersLatestHelper') | ||
| * ->getLatestUsers($params, Factory::getApplication()) | ||
| */ | ||
| public static function getUsers($params) | ||
| { | ||
| return (new self())->getLatestUsers($params, Factory::getApplication()); | ||
| } | ||
| } |
There was a problem hiding this comment.
Some modules have already been modified in the past. I assume that the depreated text of the static method also needs to be adjusted.
To know: @deprecated 5.0 Use the none static function getArticles to @deprecated __DEPLOY_VERSION__ will be removed in 6.0 and so on.
It concerns the following helper files:
ArticlesLatestHelper.php, see link:
ArticlesNewsHelper.phpArticlesPopularHelper.php
If yes, then a new PR is needed.
There was a problem hiding this comment.
@sandewt Yes. Please make PR to change deprecated note for these files.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
This is a follow up for PR #40092 to make it backward compatible. Can be merged by code review @laoneo . See #40092 (comment) for information
Testing Instructions
Code review
Actual result BEFORE applying this Pull Request
Works, but not backward compatible
Expected result AFTER applying this Pull Request
Works.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed