Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with navigation menu and breakpoints between medium and large screens. #37926

Closed
mariantanase opened this issue May 30, 2022 · 10 comments
Closed

Comments

@mariantanase
Copy link

mariantanase commented May 30, 2022

Steps to reproduce the issue

Clean installation of joomla 4.1.4 without any changes.
I noticed that on screens with resolutions between 768px (medium) and 992px (large), the navigation menu does not collapse to hamburger menu.

Expected result

Actual result

joomla-breakpoint

System information (as much as possible)

Joomla 4.1.4
PHP 8.0.13
MySQL 8.0.27

Additional comments

@ChristineWk
Copy link

That could be a possible solution. Written by a user in the German Joomla forum:

`@media (min-width: 768px) and (max-width: 991px) {
.navbar-expand-md .navbar-collapse:not(.show) {
display: none !important;
}
}

@media (max-width: 991px) {
.navbar-expand-md .navbar-toggler {
display: block !important;
}
}
`

@mariantanase
Copy link
Author

Thanks @ChristineWk
This fix resolved the issue. However, it would be better if it can be implemented in the future directly in the joomla core.

@ChristineWk
Copy link

@mariantanase

Unfortunately, I can't tell you how to proceed here. let's wait for more information

@mariantanase
Copy link
Author

I notice that the issue is still present on the most recent nightly build, Joomla_4.2.0-beta1-dev-Development-Full_Package.

@TAGarrison
Copy link

I don't know if it helps or not, but the same issue includes sidebars - they are not hidden in the 1024px mobile size, which is the iPad Pro 12.9 inch. It works in all other sizes properly.
I can also confirm that the menu issue is still a problem. I found the CSS here and that fixed things for me, but not the sidebar. You can hide the bar itself, but you cannot hide the container, so there's a huge white-bar in the iPad Pro 12.9.

@Sieger66
Copy link
Contributor

Sieger66 commented Jan 5, 2023

I think it is a bug in the PR #36900
in line 18 in templates/cassiopeia/html/mod_menu/collapse-metismenu.php

-md in class and before Joomla 4.1.3 it was -lg

I think better is:

<nav class="navbar navbar-expand-lg" aria-label="<?php echo htmlspecialchars($module->title, ENT_QUOTES, 'UTF-8'); ?>">


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37926.

@Mohammadkhan18
Copy link

Is this issue is still open? ,because adding some bootstrap classes will automatically resolve the issue i think


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37926.

@alikon
Copy link
Contributor

alikon commented Mar 29, 2023

yes, feel free to submit a pull request

@hans2103
Copy link
Contributor

PR #40574 created

@richard67
Copy link
Member

Closing as having a pull request. Please test #40574 . Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests