[4.1] Add label to the collapsible menu

[brianteeman]

This PR takes the module title and uses it as an aria-label for the nav container of the default collapsible menu and the collapse-metismenu override in cassiopeia.

Pull Request for Issue #36839

[chmst]

@Worti2 this looks good to me. Could you please test this with your user?

[BertaOctech]

I have tested this item ✅ successfully on 0cf0845

I applied the patch and in fact the title of the module was included in the nav item as aria-label, as described. I marked the test as successful.

However, I wonder if this could be confusing. The title of the menu module is not always shown in the frontend. Either because the menu is in the menu position and not in the sidebar or because the author has decided to hide it. In this case you are using a label which is not visible in the screen.

I guess we should choose appropriate names for our menu modules in any case.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36900.}

[RickR2H]

I have tested this item ✅ successfully on 0cf0845

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36900.}

[RickR2H]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36900.}

[bembelimen]

Is this tested that the whole site does not break, if the title contains a quote ( " )?

[brianteeman]

Is this tested that the whole site does not break, if the title contains a quote ( " )?

Good spot. I will update it to address that

[brianteeman]

Just to point out - nothing breaks with any extra " - its just the aria label that gets truncated - still needs fixing but not disruptive

[brianteeman]

Updated.

If a module title contains a " then the aria label was truncated at the ".

This update just strips the "

before aria-label="module title " here"
after aria-label="module title here"

[chmst]

Back to pending

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36900.}

[brianteeman]

Please retest

[Quy]

I have tested this item ✅ successfully on ce09280

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36900.}

[pabloarias]

I have tested this item ✅ successfully on ce09280

Tested in Joomla 4.1.1-dev with PHP 8.0.15.

I agree with @BertaOctech: if you choose to not show module title, aria label is still showed. Maybe it shouldn't.

Thanks

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36900.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36900.}

[laoneo]

Thanks!