Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lints the cypress system tests #40076

Merged
merged 6 commits into from
Mar 11, 2023
Merged

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Mar 10, 2023

Adds he cypress specs to the linter for testing. The override is needed in the config file, so all the functions and the global "cy" variable are not reported as undefined.

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.4-dev Unit/System Tests labels Mar 10, 2023
@laoneo
Copy link
Member Author

laoneo commented Mar 10, 2023

@dgrammatiko can yo have a look here if did not miss anything?

@dgrammatiko
Copy link
Contributor

LGTM

FWIW if you want to be way more strict what could be done is:

@laoneo
Copy link
Member Author

laoneo commented Mar 11, 2023

For now I would leave it as it is, without adding another dev dependency. We can do that later when we have the need for it.

@MacJoom MacJoom merged commit 90435d6 into joomla:4.4-dev Mar 11, 2023
@laoneo laoneo deleted the lint/tests branch March 11, 2023 15:41
@laoneo laoneo added this to the Joomla! 4.4.0 milestone Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.4-dev Unit/System Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants