Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Make code consistent, change <folder>services</folder> to <folder>src</folder> #40204

Merged
merged 7 commits into from
Mar 28, 2023

Conversation

sandewt
Copy link
Contributor

@sandewt sandewt commented Mar 26, 2023

Pull Request for Issue # .

Summary of Changes

Match code in some .xml files with what is most common in Joomla
Swap services to src

Testing Instructions

  • works
  • code review

Actual result BEFORE applying this Pull Request

Module(s)

<folder module="mod_example">src</folder>
<folder>services</folder>

Plugin(s)

<folder>services</folder>
<folder plugin="example">src</folder>

Expected result AFTER applying this Pull Request

Module(s)

<folder module="mod_example">services</folder>
<folder>src</folder>

Plugin(s)

<folder plugin="example">services</folder>
<folder>src</folder>

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@laoneo
Copy link
Member

laoneo commented Mar 26, 2023

Cool, I did it that way to have the folders in alpha order too.

@laoneo laoneo merged commit 20ff4df into joomla:4.4-dev Mar 28, 2023
@laoneo laoneo added this to the Joomla! 4.4.0 milestone Mar 28, 2023
@laoneo
Copy link
Member

laoneo commented Mar 28, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants