Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

cluster: tests multiple open of ports in workers #8027

Closed
wants to merge 144 commits into from
Closed

cluster: tests multiple open of ports in workers #8027

wants to merge 144 commits into from

Commits on Sep 17, 2014

  1. doc: http.request() improved code example

    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    Reviewed-by: Fedor Indutny <fedor@indutny.com>
    guisouza authored and trevnorris committed Sep 17, 2014
    2 Configuration menu
    Copy the full SHA
    468fb54 View commit details
    Browse the repository at this point in the history
  2. doc: console example improvement

    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    Reviewed-by: Fedor Indutny <fedor@indutny.com>
    guisouza authored and trevnorris committed Sep 17, 2014
    Configuration menu
    Copy the full SHA
    378d972 View commit details
    Browse the repository at this point in the history
  3. win: manifest node.exe for Windows 8.1

    Adding a compatibility section to node.exe embedded manifest so that
    Node is declared explicitly compatible with Windows 8.1. Required so
    that os.release() can return the correct version on Windows 8.1.
    
    See http://msdn.microsoft.com/en-us/library/windows/desktop/ms724451(v=vs.85).aspx
    
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    orangemocha authored and trevnorris committed Sep 17, 2014
    Configuration menu
    Copy the full SHA
    03e9352 View commit details
    Browse the repository at this point in the history
  4. crypto: clarify RandomBytes() error msg

    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    Mickael van der Beek authored and trevnorris committed Sep 17, 2014
    Configuration menu
    Copy the full SHA
    c615545 View commit details
    Browse the repository at this point in the history
  5. crypto: never store pointer to conn in SSL_CTX

    SSL_CTX is shared between multiple connections and is not a right place
    to store per-connection data.
    
    fix #8348
    
    Reviewed-By: Trevor Norris
    indutny committed Sep 17, 2014
    Configuration menu
    Copy the full SHA
    cb4ed3c View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2014

  1. test: add test for cluster.worker.destroy()

    Add a simple test to cover workers' implementation of
    Worker.prototype.destroy(). Before adding this test, this code wouldn't
    be covered by the tests suite, and any regression introduced in workers'
    implementation of Worker.prototype.destroy wouldn't be caught.
    
    Fixes: #8223
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    Julien Gilli authored and trevnorris committed Sep 18, 2014
    Configuration menu
    Copy the full SHA
    9c992bd View commit details
    Browse the repository at this point in the history
  2. node: support v8 microtask queue

    When V8 started supporting Promises natively it also introduced a
    microtack queue. This feature operates similar to process.nextTick(),
    and created an issue where neither knew when the other had run. This
    patch has nextTick() call the microtask queue runner at the end of
    processing callbacks in the nextTickQueue.
    
    Fixes: #7714
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    vkurchatkin authored and trevnorris committed Sep 18, 2014
    Configuration menu
    Copy the full SHA
    30bd7b6 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2014

  1. doc: corrected typo in vm docs

    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    ateich authored and trevnorris committed Sep 19, 2014
    Configuration menu
    Copy the full SHA
    d66adf0 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2014

  1. buffer: improve Buffer constructor

    Increase the performance of new Buffer construction by initializing all
    properties before SetIndexedPropertiesToExternalArrayData call.
    
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    kennyluck authored and trevnorris committed Sep 20, 2014
    Configuration menu
    Copy the full SHA
    4c9b30d View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2014

  1. http: write() after end() emits an error.

    When calling write() after end() has been called on an OutgoingMessage,
    an error is emitted and the write's callback is called with an instance
    of Error.
    
    Fix #7477.
    
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    Julien Gilli authored and indutny committed Sep 23, 2014
    Configuration menu
    Copy the full SHA
    64d6de9 View commit details
    Browse the repository at this point in the history
  2. crypto: export externals to internal structs

    Export External getters for a internal structs: SSL, SSL_CTX.
    indutny committed Sep 23, 2014
    Configuration menu
    Copy the full SHA
    6e08bb9 View commit details
    Browse the repository at this point in the history
  3. deps: update uv to v1.0.0-rc1

    indutny authored and tjfontaine committed Sep 23, 2014
    Configuration menu
    Copy the full SHA
    c5f5d4c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7fd35e6 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2014

  1. buffer: fix map and set parent to undefined

    In 4c9b30d removal of the prototype attributes meant NativeBuffer() no
    longer had the same object map as Buffer(). By now setting the same
    properties in the same order both constructors will produce the same
    map.
    
    The same commit changed "parent" from undefined to null. This caused a
    failure in Buffer#slice() where it was checked if parent === undefined.
    Causing the incorrect parent to be set.
    
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    trevnorris committed Sep 24, 2014
    1 Configuration menu
    Copy the full SHA
    7c3c51b View commit details
    Browse the repository at this point in the history
  2. tls_wrap: ensure that TLSCallbacks are gc-able

    Call `MakeWeak()` to destruct TLSCallbacks when the js-object dies.
    
    fix #8416
    
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    indutny committed Sep 24, 2014
    Configuration menu
    Copy the full SHA
    4dbb84f View commit details
    Browse the repository at this point in the history
  3. tests: add test for buffer.slice.

    4c9b30d introduced a regression in buffer.slice that 7c3c51b fixed, but
    no test had been added to make sure that a similar regression is caught
    by the tests suite in the future.
    Julien Gilli authored and tjfontaine committed Sep 24, 2014
    Configuration menu
    Copy the full SHA
    2f7234d View commit details
    Browse the repository at this point in the history
  4. test: disable dgram-bind-shared-ports on win32

    Windows currently doesn't support clustered dgram sockets, when it does
    re-enable this test
    tjfontaine committed Sep 24, 2014
    Configuration menu
    Copy the full SHA
    f773fb4 View commit details
    Browse the repository at this point in the history
  5. benchmark: add test for module loader

    Adds a test for benchmarking the module loader, needed for benchmarking
    changes / refacortings in the module loader.
    
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    Reviewed-by: Timothy J Fontaine <tjfontaine@gmail.com>
    robertkowalski authored and trevnorris committed Sep 24, 2014
    Configuration menu
    Copy the full SHA
    efa47e5 View commit details
    Browse the repository at this point in the history
  6. net: Make server.connections un-enumerable

    The property server.connections should no longer be enumerable because
    it has been deprecated. This will prevent deprecation warnings when
    server objects are accessed by functions such as JSON.stringify.
    
    Fixes: #8373
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    pfmooney authored and trevnorris committed Sep 24, 2014
    Configuration menu
    Copy the full SHA
    b26dd4e View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2014

  1. deps: upgrade npm to 2.0.0

    tjfontaine committed Sep 25, 2014
    Configuration menu
    Copy the full SHA
    9fad895 View commit details
    Browse the repository at this point in the history
  2. 2014.09.24, Version 0.11.14 (Unstable)

    * uv: Upgrade to v1.0.0-rc1
    
    * http_parser: Upgrade to v2.3.0
    
    * npm: Upgrade to v2.0.0
    
    * openssl: Upgrade to v1.0.1i
    
    * v8: Upgrade to 3.26.33
    
    * Add fast path for simple URL parsing (Gabriel Wicke)
    
    * Added support for options parameter in console.dir() (Xavi Magrinyà)
    
    * Cluster: fix shared handles on Windows (Alexis Campailla)
    
    * buffer: Fix incorrect Buffer.compare behavior (Feross Aboukhadijeh)
    
    * buffer: construct new buffer from buffer toJSON() output (cjihrig)
    
    * buffer: improve Buffer constructor (Kang-Hao Kenny)
    
    * build: linking CoreFoundation framework for OSX (Thorsten Lorenz)
    
    * child_process: accept uid/gid everywhere (Fedor Indutny)
    
    * child_process: add path to spawn ENOENT Error (Ryan Cole)
    
    * child_process: copy spawnSync() cwd option to proper buffer (cjihrig)
    
    * child_process: do not access stderr when stdio set to 'ignore' (cjihrig)
    
    * child_process: don't throw on EAGAIN (Charles)
    
    * child_process: don't throw on EMFILE/ENFILE (Ben Noordhuis)
    
    * child_process: use full path for cmd.exe on Win32 (Ed Morley)
    
    * cluster: allow multiple calls to setupMaster() (Ryan Graham)
    
    * cluster: centralize removal from workers list. (Julien Gilli)
    
    * cluster: enable error/message events using .worker (cjihrig)
    
    * cluster: include settings object in 'setup' event (Ryan Graham)
    
    * cluster: restore v0.10.x setupMaster() behaviour (Ryan Graham)
    
    * cluster: support options in Worker constructor (cjihrig)
    
    * cluster: test events emit on cluster.worker (Sam Roberts)
    
    * console: console.dir() accepts options object (Xavi Magrinyà)
    
    * crypto: add `honorCipherOrder` argument (Fedor Indutny)
    
    * crypto: allow padding in RSA methods (Fedor Indutny)
    
    * crypto: clarify RandomBytes() error msg (Mickael van der Beek)
    
    * crypto: never store pointer to conn in SSL_CTX (Fedor Indutny)
    
    * crypto: unsigned value can't be negative (Brian White)
    
    * dgram: remove new keyword from errnoException (Jackson Tian)
    
    * dns: always set variable family in lookup() (cjihrig)
    
    * dns: include host name in error message if available (Maciej Małecki)
    
    * dns: introduce lookupService function (Saúl Ibarra Corretgé)
    
    * dns: send lookup c-ares errors to callback (Chris Dickinson)
    
    * dns: throw if hostname is not string or falsey (cjihrig)
    
    * events: Output the event that is leaking (Arnout Kazemier)
    
    * fs: close file if fstat() fails in readFile() (cjihrig)
    
    * fs: fs.readFile should not throw uncaughtException (Jackson Tian)
    
    * http: add 308 status_code, see RFC7238 (Yazhong Liu)
    
    * http: don't default OPTIONS to chunked encoding (Nick Muerdter)
    
    * http: fix bailout for writeHead (Alex Kocharin)
    
    * http: remove unused code block (Fedor Indutny)
    
    * http: write() after end() emits an error. (Julien Gilli)
    
    * lib, src: add vm.runInDebugContext() (Ben Noordhuis)
    
    * lib: noisy deprecation of child_process customFds (Ryan Graham)
    
    * module: don't require fs several times (Robert Kowalski)
    
    * net,dgram: workers can listen on exclusive ports (cjihrig)
    
    * net,stream: add isPaused, don't read() when paused (Chris Dickinson)
    
    * net: Ensure consistent binding to IPV6 if address is absent (Raymond Feng)
    
    * net: add remoteFamily for socket (Jackson Tian)
    
    * net: don't emit listening if handle is closed (Eli Skeggs)
    
    * net: don't prefer IPv4 addresses during resolution (cjihrig)
    
    * net: don't throw on net.Server.close() (cjihrig)
    
    * net: reset `errorEmitted` on reconnect (Ed Umansky)
    
    * node: set names for prototype methods (Trevor Norris)
    
    * node: support v8 microtask queue (Vladimir Kurchatkin)
    
    * path: fix slice OOB in trim (Lucio M. Tato)
    
    * path: isAbsolute() should always return boolean (Herman Lee)
    
    * process: throw TypeError if kill pid not a number (Sam Roberts)
    
    * querystring: custom encode and decode (fengmk2)
    
    * querystring: do not add sep for empty array (cjihrig)
    
    * querystring: remove prepended ? from query field (Ezequiel Rabinovich)
    
    * readline: fix close event of readline.Interface() (Yazhong Liu)
    
    * readline: fixes scoping bug (Dan Kaplun)
    
    * readline: implements keypress buffering (Dan Kaplun)
    
    * repl: fix multi-line input (Fedor Indutny)
    
    * repl: fix overwrite for this._prompt (Yazhong Liu)
    
    * repl: proper `setPrompt()` and `multiline` support (Fedor Indutny)
    
    * stream: don't try to finish if buffer is not empty (Vladimir Kurchatkin)
    
    * stream: only end reading on null, not undefined (Jonathan Reem)
    
    * streams: set default hwm properly for Duplex (Andrew Oppenlander)
    
    * string_bytes: ucs2 support big endian (Andrew Low)
    
    * tls, crypto: add DHE support (Shigeki Ohtsu)
    
    * tls: `checkServerIdentity` option (Trevor Livingston)
    
    * tls: add DHE-RSA-AES128-SHA256 to the def ciphers (Shigeki Ohtsu)
    
    * tls: better error reporting at cert validation (Fedor Indutny)
    
    * tls: support multiple keys/certs (Fedor Indutny)
    
    * tls: throw an error, not string (Jackson Tian)
    
    * udp: make it possible to receive empty udp packets (Andrius Bentkus)
    
    * url: treat  the same as / (isaacs)
    tjfontaine committed Sep 25, 2014
    Configuration menu
    Copy the full SHA
    fd896d5 View commit details
    Browse the repository at this point in the history
  3. Now working on 0.11.15

    tjfontaine committed Sep 25, 2014
    Configuration menu
    Copy the full SHA
    8e4fc88 View commit details
    Browse the repository at this point in the history
  4. doc: fix brackets for optional parameters

    Documentation incorrectly used bracket notation for optional parameters.
    This caused inconsistencies in usage because of examples like the
    following:
    
        fs.write(fd, data[, position[, encoding]], callback)
    
    This simply fixes all uses of bracket notation in documentation.
    
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    Reviewed-by: Fedor Indutny <fedor@indutny.com>
    trevnorris committed Sep 25, 2014
    Configuration menu
    Copy the full SHA
    51b6b68 View commit details
    Browse the repository at this point in the history
  5. readline: fix performance issue when large line

    Only run lineEnding.test() on the newly acquired chunk of string instead
    of on the entire line buffer.
    
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    Jicheng Li authored and trevnorris committed Sep 25, 2014
    Configuration menu
    Copy the full SHA
    f3473d7 View commit details
    Browse the repository at this point in the history
  6. child_process: improve spawn() argument handling

    Add stricter argument type checking to normalizeSpawnArguments().
    
    Removes a number of extraneous checks in spawn().
    
    Fix regression in handling of the optional args argument.
    
    Add more thorough testing of spawn() arguments.
    
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    cjihrig authored and trevnorris committed Sep 25, 2014
    Configuration menu
    Copy the full SHA
    9d95774 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2014

  1. crypto: lower RSS usage for TLSCallbacks

    Don't allocate any BIO buffers initially, do this on a first read from
    the TCP connection. Allocate different amount of data for initial read
    and for consequent reads: small buffer for hello+certificate, big buffer
    for better throughput.
    
    see #8416
    indutny committed Sep 26, 2014
    Configuration menu
    Copy the full SHA
    2122a77 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2014

  1. timer_wrap: remove HandleScopes, check return size

    Calls from JS to C++ have an implicit HandleScope. So there is no need
    to instantiate a new HandleScope in these basic cases.
    
    Check if the returned int64_t is an SMI and cast the return value to
    uint32_t instead of a double. Prevents needing to box the return value,
    and saves a small amount of execution time.
    
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    trevnorris committed Sep 29, 2014
    Configuration menu
    Copy the full SHA
    de312cf View commit details
    Browse the repository at this point in the history
  2. http: cleanup setHeader()

    Several fields on OutgoingMessage were set after instantiation. These
    have been included in the constructor to prevent mutation of the object
    map after instantiation.
    
    "name" is now explicitly checked to be a string. Where before if a
    non-string was passed the following cryptic error was thrown:
    
        _http_outgoing.js:334
          var key = name.toLowerCase();
                         ^
        TypeError: undefined is not a function
    
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    trevnorris committed Sep 29, 2014
    Configuration menu
    Copy the full SHA
    979d0ca View commit details
    Browse the repository at this point in the history
  3. readme: grammer fix

    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    jamesanthonyferguson authored and trevnorris committed Sep 29, 2014
    Configuration menu
    Copy the full SHA
    f4df805 View commit details
    Browse the repository at this point in the history
  4. src: fix VC++ warning C4244

    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    zerhacken authored and trevnorris committed Sep 29, 2014
    Configuration menu
    Copy the full SHA
    734fb49 View commit details
    Browse the repository at this point in the history
  5. doc: fix optional parameter parsing

    The parameter parser specifically looked for the old bracket syntax.
    This generated a lot of warnings when building the docs. Those warnings
    have been fixed by changing the parsing logic.
    
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    trevnorris committed Sep 29, 2014
    Configuration menu
    Copy the full SHA
    f2a78de View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2014

  1. buffer: fix and cleanup fill()

    Running fill() with an empty string would cause Node to hang
    indefinitely. Now it will return without having operated on the buffer.
    
    User facing function has been pulled into JS to perform all initial
    value checks and coercions. The C++ method has been placed on the
    "internal" object.
    
    Coerced non-string values to numbers to match v0.10 support.
    
    Simplified logic and changed a couple variable names.
    
    Added tests for fill() and moved them all to the beginning of
    buffer-test.js since many other tests depend on fill() working properly.
    
    Fixes: #8469
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    trevnorris committed Sep 30, 2014
    Configuration menu
    Copy the full SHA
    57ed3da View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2014

  1. http: Improve _addHeaderLines method

    Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    JacksonTian authored and chrisdickinson committed Oct 1, 2014
    Configuration menu
    Copy the full SHA
    1781c8b View commit details
    Browse the repository at this point in the history
  2. doc: note stdout and stderr special behaviors.

    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
    julien-f authored and chrisdickinson committed Oct 1, 2014
    Configuration menu
    Copy the full SHA
    95726b0 View commit details
    Browse the repository at this point in the history
  3. build, i18n: improve Intl build, add "--with-intl"

    The two main goals of this change are:
     - To make it easier to build the Intl option using ICU (particularly,
       using a newer ICU than v8/Chromium's version)
     - To enable a much smaller ICU build with only English support The goal
       here is to get node.js binaries built this way by default so that the
       Intl API can be used. Additional data can be added at execution time
       (see Readme and wiki)
    
    More details are at #7719
    
    In particular, this change adds the "--with-intl=" configure option to
    provide more ways of building "Intl":
     - "full-icu" picks up an ICU from deps/icu
     - "small-icu" is similar, but builds only English
     - "system-icu" uses pkg-config to find an installed ICU
     - "none" does nothing (no Intl)
    
    For Windows builds, the "full-icu" or "small-icu" options are added to
    vcbuild.bat.
    
    Note that the existing "--with-icu-path" option is not removed from
    configure, but may not be used alongside the new option.
    
    Wiki changes have already been made on
     https://github.com/joyent/node/wiki/Installation
    and a new page created at
     https://github.com/joyent/node/wiki/Intl
    (marked as provisional until this change lands.)
    
    Summary of changes:
    
    * README.md : doc updates
    
    * .gitignore : added "deps/icu" as this is the location where ICU is
      unpacked to.
    
    * Makefile : added the tools/icu/* files to cpplint, but excluded a
      problematic file.
    
    * configure : added the "--with-intl" option mentioned above.
      Calculate at config time the list of ICU source files to use and data
      packaging options.
    
    * node.gyp : add the new files src/node_i18n.cc/.h as well as ICU
      linkage.
    
    * src/node.cc : add call into
      node::i18n::InitializeICUDirectory(icu_data_dir) as well as new
      --icu-data-dir option and NODE_ICU_DATA env variable to configure ICU
      data loading. This loading is only relevant in the "small"
      configuration.
    
    * src/node_i18n.cc : new source file for the above Initialize..
      function, to setup ICU as needed.
    
    * tools/icu : new directory with some tools needed for this build.
    
    * tools/icu/icu-generic.gyp : new .gyp file that builds ICU in some new
      ways, both on unix/mac and windows.
    
    * tools/icu/icu-system.gyp : new .gyp file to build node against a
      pkg-config detected ICU.
    
    * tools/icu/icu_small.json : new config file for the "English-only" small
      build.
    
    * tools/icu/icutrim.py : new tool for trimming down ICU data. Reads the
      above .json file.
    
    * tools/icu/iculslocs.cc : new tool for repairing ICU data manifests
      after trim operation.
    
    * tools/icu/no-op.cc : dummy file to force .gyp into using a C++ linker.
    
    * vcbuild.bat : added small-icu and full-icu options, to call into
      configure.
    
    * Fixed toolset dependencies, see
      #7719 (comment)
    
    Note that because of a bug in gyp {CC,CXX}_host must also be set.
    Otherwise gcc/g++ will be used by default for part of the build.
    
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    Reviewed-by: Fedor Indutny <fedor@indutny.com>
    srl295 authored and trevnorris committed Oct 1, 2014
    Configuration menu
    Copy the full SHA
    ac2857b View commit details
    Browse the repository at this point in the history
  4. url: make query() consistent

    Match the behavior of the slow path by setting url.query to an empty
    object when the url contains no query, but query parsing is requested.
    
    Also add a test for this case, and update the documents to clearly
    reflect this behavior.
    
    Fixes: #8332
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    gwicke authored and trevnorris committed Oct 1, 2014
    Configuration menu
    Copy the full SHA
    b705b73 View commit details
    Browse the repository at this point in the history
  5. node: avoid automatic microtask runs

    Since we are taking control of the microtask queue it makes sense to
    disable autorun and only run microtasks when necessary. Just setting
    isolate->SetAutorunMicrotasks(false) would cause _tickCallback() not to
    be called.
    
    Automatically running the microtask queue will cause it to run:
    
    * After callback invocation
    * Inside _tickCallback()
    * After _tickCallback() invocation
    
    The third one is unnecessary as the microtask queue is guaranteed to be
    empty at this point. The first only needs to be run manually when
    _tickCallback() isn't going to be called by MakeCallback().
    
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    vkurchatkin authored and trevnorris committed Oct 1, 2014
    Configuration menu
    Copy the full SHA
    8dc6be1 View commit details
    Browse the repository at this point in the history
  6. readline: should not require an output stream.

    Passing null as the output stream to readline.Interface()'s constructor
    is now supported. Any output written by readline is just discarded. It
    makes it easier to use readline just as a line parser.
    
    Fixes: #4408
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    Julien Gilli authored and trevnorris committed Oct 1, 2014
    Configuration menu
    Copy the full SHA
    862cc28 View commit details
    Browse the repository at this point in the history
  7. buffer: mv floating point read/write checks to JS

    Performance improvement by moving checks for floating point operations
    to JS and doing the operation on a protected internal function that
    assumes all arguments are correct. Still abort if the operation
    overflows memory. This can only be caused if the Buffer's length
    property isn't the same as the actual internal length.
    
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    trevnorris committed Oct 1, 2014
    Configuration menu
    Copy the full SHA
    e9ca7b9 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2014

  1. buffer: add generic functions for (u)int ops

    Add generic functions for (U)Int read/write operations on Buffers. These
    support up to and including 48 bit reads and writes.
    
    Include documentation and tests.
    
    Additional work done by Trevor Norris to include 40 and 48 bit write
    support. Because bitwise operations cannot be used on values greater
    than 32 bits, the operations have been replaced with mathematical
    calculations. Regardless, they are still faster than floating point
    operations.
    
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    yorkie authored and trevnorris committed Oct 3, 2014
    Configuration menu
    Copy the full SHA
    83d7d9e View commit details
    Browse the repository at this point in the history
  2. util: add es6 Symbol support for util.inspect

    * `util.inspect` cannot accept es6 symbol primitive
    * It will throw exception if do `util.inspect(Symbol())`
    * This also affects repl, console.log, etc.
    
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
    gyson authored and chrisdickinson committed Oct 3, 2014
    Configuration menu
    Copy the full SHA
    cb97bcd View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2014

  1. doc: Update net.markdown

    Associates link to dns.lookup() with proper URL.
    
    Fixes: #8018
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
    OpenSourceSteve authored and chrisdickinson committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    87ce067 View commit details
    Browse the repository at this point in the history
  2. doc: improve readLine.pause()

    The docs for readLine.pause are misleading. I seriously spent hours on this. If
    it isn't a bug, at least it should be well documented.
    
    Someone else stumbled on this too:
    http://stackoverflow.com/questions/21341050/pausing-readline-in-node-js
    
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
    Victor Widell authored and chrisdickinson committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    8392e8c View commit details
    Browse the repository at this point in the history
  3. url: fixed encoding for slash switching emulation.

    Fixes: #8458
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
    Evan Rutledge Borden authored and chrisdickinson committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    640ad63 View commit details
    Browse the repository at this point in the history
  4. build: i18n: move noisy variables to separate gypi

    Fixes: #7676 (comment)
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    srl295 authored and trevnorris committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    f769d13 View commit details
    Browse the repository at this point in the history
  5. build: i18n: py27 -> py26 dependency

    Move from argparse to optparse for dependency management.
    
    Fixes: #7719 (comment)
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    srl295 authored and trevnorris committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    0a22ed4 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2014

  1. streams: set default encoding for writable streams

    Add API Writable#setDefaultEncoding().
    
    PR-URL: #8483
    Fixes: #7159
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    Johnny Ray authored and trevnorris committed Oct 8, 2014
    Configuration menu
    Copy the full SHA
    f04f3a0 View commit details
    Browse the repository at this point in the history
  2. doc: add missing semicolons

    PR-URL: #8498
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    stevemao authored and trevnorris committed Oct 8, 2014
    Configuration menu
    Copy the full SHA
    6e4bd49 View commit details
    Browse the repository at this point in the history
  3. smalloc: update use of ExternalArrayType constants

    The constants in enum v8::ExternalArrayType have been changed. The old
    values are there for legacy reasons, but it's best to update anyway.
    
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    trevnorris committed Oct 8, 2014
    Configuration menu
    Copy the full SHA
    4809c7a View commit details
    Browse the repository at this point in the history
  4. src: fix jslint warning

    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    trevnorris committed Oct 8, 2014
    Configuration menu
    Copy the full SHA
    7b4a540 View commit details
    Browse the repository at this point in the history
  5. tools: fix for testing openssl integrations

    Windows doesn't resolve ".." the way we expect it for symlinks and
    junctions.
    
    PR-URL: #8489
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    Reviewed-by: Fedor Indutny <fedor@indutny.com>
    refack authored and trevnorris committed Oct 8, 2014
    Configuration menu
    Copy the full SHA
    573e6af View commit details
    Browse the repository at this point in the history
  6. src: update use of ExternalArrayType constants

    Continuation of 4809c7a to update the use of v8::ExternalArrayType.
    
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    trevnorris committed Oct 8, 2014
    Configuration menu
    Copy the full SHA
    bdc2ea4 View commit details
    Browse the repository at this point in the history
  7. buffer, doc: misc. fix and cleanup

    * Add official documentation that a Buffer instance is a viable
      argument when instantiating a new Buffer.
    * Properly set the poolOffset when a buffer needs to be truncated.
    * Add comments clarifying specific peculiar coding choices.
    * Remove a level of unnecessary indentation.
    
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    trevnorris committed Oct 8, 2014
    Configuration menu
    Copy the full SHA
    6462519 View commit details
    Browse the repository at this point in the history
  8. tls_wrap: ignore ZERO_RETURN after close_notify

    Do not call SSL_read() and ignore ZERO_RETURN if the connection was
    shutdown and there could not be any reads.
    
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    PR-URL: #8519
    indutny committed Oct 8, 2014
    Configuration menu
    Copy the full SHA
    a2a3fd4 View commit details
    Browse the repository at this point in the history
  9. deps: update v8 to 3.28.73

    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    PR-URL: #8476
    refack authored and indutny committed Oct 8, 2014
    Configuration menu
    Copy the full SHA
    9116b24 View commit details
    Browse the repository at this point in the history
  10. deps: apply floating irhydra patch to v8

    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    PR-URL: #8476
    indutny committed Oct 8, 2014
    Configuration menu
    Copy the full SHA
    270e998 View commit details
    Browse the repository at this point in the history
  11. deps: fix postmortem-metadata generator in v8

    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    PR-URL: #8476
    refack authored and indutny committed Oct 8, 2014
    Configuration menu
    Copy the full SHA
    8efcc7f View commit details
    Browse the repository at this point in the history
  12. deps: re-implement debugger-agent

    Reviewed-By: Trevor Norris <trevnorris@gmail.com>
    PR-URL: #8476
    indutny committed Oct 8, 2014
    Configuration menu
    Copy the full SHA
    7a0cfe9 View commit details
    Browse the repository at this point in the history
  13. cluster: do not signal children in debug mode

    Do not send signal to children if they are already in debug mode.
    Node.js on Windows does not register signal handler, and thus calling
    `process._debugProcess()` will throw an error.
    
    Reviewed-By: Trevor Norris <trevnorris@gmail.com>
    PR-URL: #8476
    indutny committed Oct 8, 2014
    Configuration menu
    Copy the full SHA
    42ecd48 View commit details
    Browse the repository at this point in the history
  14. src, test: fixup after v8 update

    Because of behavior change of some V8 APIs (they mostly became more
        strict), following modules needed to be fixed:
    
    * crypto: duplicate prototype methods are not allowed anymore
    * contextify: some TryCatch trickery, the binding was using it
    incorrectly
    * util: maximum call stack error is now crashing in a different place
    
    Reviewed-By: Trevor Norris <trevnorris@gmail.com>
    PR-URL: #8476
    indutny committed Oct 8, 2014
    Configuration menu
    Copy the full SHA
    685ac09 View commit details
    Browse the repository at this point in the history
  15. test: fix debug-signal-cluster after da update

    The cluster children are hitting breakpoint at `cluster.onread` and
    hanging on a Semaphore wait now. This prevents them from disconnecting
    gracefully. Considering that the test is checking different thing, the
    cluster children needs to be force killed from the grand parent process.
    
    Reviewed-By: Trevor Norris <trevnorris@gmail.com>
    PR-URL: #8476
    indutny committed Oct 8, 2014
    Configuration menu
    Copy the full SHA
    d87480b View commit details
    Browse the repository at this point in the history
  16. crypto: createDiffieHellman throw for bad args

    Previously crypto.createDiffieHellman() would fail silently when a bad
    argument was passed for prime/prime_length. Now throws TypeError.
    
    Fixes: #8480
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    trevnorris committed Oct 8, 2014
    Configuration menu
    Copy the full SHA
    1a4a189 View commit details
    Browse the repository at this point in the history
  17. doc: fix wording and punctuation in modules

    [trev.norris@gmail.com: break lines at 80 characters]
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    stiliyan authored and trevnorris committed Oct 8, 2014
    Configuration menu
    Copy the full SHA
    47f119c View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2014

  1. test: fix test-child-process-spawn-typeerror

    You cannot spawn 'dir' on Windows because it's not an executable.  Also,
    some people might have 'ls' on their path on Windows, so I changed
    invalidCmd to something that's highly unlikely to exist.
    
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    orangemocha authored and trevnorris committed Oct 9, 2014
    Configuration menu
    Copy the full SHA
    61dd74b View commit details
    Browse the repository at this point in the history
  2. doc: correct createSecureContext

    Remove incorrect stablity indication of tls.createSecureContext, and
    format stablity indication of crypto.createCredentials.
    
    Fixes: e50749 "doc: document `tls.createSecureContext`"
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    cynron authored and trevnorris committed Oct 9, 2014
    Configuration menu
    Copy the full SHA
    db7df57 View commit details
    Browse the repository at this point in the history
  3. streams: make setDefaultEncoding() throw

    PR-URL: #8529
    Fixes: f04f3a0 "streams: set default encoding for writable streams"
    [trev.norris@gmail.com: update tests to check if throws]
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    mscdex authored and trevnorris committed Oct 9, 2014
    Configuration menu
    Copy the full SHA
    874dd59 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2014

  1. build: vcbuild fix "The input line is too long."

    vcbuild.bat is calling vcvars.bat, which doesn't detect if the environment
    has already been set. This causes repeated entries to be added to the PATH,
    which after a few invocations will lead to an error:
    The input line is too long.
    orangemocha committed Oct 10, 2014
    Configuration menu
    Copy the full SHA
    d22637c View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2014

  1. path: resolve normalize drive letter to lower case

    make path.resolve work the same as path.normalize
    dead-horse authored and orangemocha committed Oct 20, 2014
    Configuration menu
    Copy the full SHA
    f6e5740 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2014

  1. lint: fix whitespace issues

    Fixes: f6e5740 "path: resolve normalize drive letter to lower case"
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    trevnorris committed Oct 25, 2014
    Configuration menu
    Copy the full SHA
    6a68d64 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2014

  1. docs: fix smalloc.dispose() example

    Also couple of additions about dispose and limitations of smalloc'ed
    objects.
    
    Fixes: #8625
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    vkurchatkin authored and trevnorris committed Oct 27, 2014
    1 Configuration menu
    Copy the full SHA
    15aa47e View commit details
    Browse the repository at this point in the history
  2. net: add pauseOnConnect option to createServer()

    Currently when a server receives a new connection the underlying socket
    handle begins reading data immediately. This causes problems when
    sockets are passed between processes, as data can be read by the first
    process and thus never read by the second process.
    
    This commit allows sockets that are constructed with a handle to be
    paused initially.
    
    PR-URL: #8576
    Fixes: #7905
    Fixes: #7784
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    cjihrig authored and trevnorris committed Oct 27, 2014
    Configuration menu
    Copy the full SHA
    c2b4f48 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2014

  1. smalloc: fix copyOnto optimization

    copyOnto is broken when one argument has 1 byte size and the other > 1
    byte.
    
    PR-URL: #8637
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    vkurchatkin authored and trevnorris committed Oct 30, 2014
    Configuration menu
    Copy the full SHA
    849fcde View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2014

  1. smalloc: check if obj has external data

    PR-URL: #8655
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    vkurchatkin authored and trevnorris committed Nov 5, 2014
    Configuration menu
    Copy the full SHA
    f65a5cb View commit details
    Browse the repository at this point in the history
  2. build: fix build for SmartOS

    This change in V8: https://code.google.com/p/v8/source/detail?r=22210
    has introduced a method named OS::GetCurrentThreadId which fails to
    compile on OSes where a "gettid" syscall does not exist.
    
    This build issue has been fixed upstream by several changes:
    - https://code.google.com/p/v8/source/detail?r=23459.
    - https://codereview.chromium.org/649553002
    - https://codereview.chromium.org/642223003
    
    Another minor fix to the upstream changes was also necessary.
    See https://code.google.com/p/v8/issues/detail?id=3620 for
    more information.
    
    The other build issue was due to the fact that alloca.h is not included
    by other system includes on SmartOS, which is assumed by V8.
    
    Built and tested on Linux, MacOS X, Windows and SmartOS.
    Julien Gilli authored and tjfontaine committed Nov 5, 2014
    1 Configuration menu
    Copy the full SHA
    3589a62 View commit details
    Browse the repository at this point in the history
  3. test: more thorough tests for npm

    othiym23 authored and tjfontaine committed Nov 5, 2014
    Configuration menu
    Copy the full SHA
    272aa58 View commit details
    Browse the repository at this point in the history
  4. npm: Upgrade to v2.1.6

    tjfontaine committed Nov 5, 2014
    Configuration menu
    Copy the full SHA
    28ae70e View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2014

  1. deps: update uv to v1.0.0-rc2

    PR-URL: #8566
    Reviewed-by: Fedor Indutny <fedor@indutny.com>
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    saghul authored and trevnorris committed Nov 6, 2014
    Configuration menu
    Copy the full SHA
    ce112c2 View commit details
    Browse the repository at this point in the history
  2. core: replace uv_fs_readdir with uv_fs_scandir

    PR-URL: #8566
    Reviewed-by: Fedor Indutny <fedor@indutny.com>
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    saghul authored and trevnorris committed Nov 6, 2014
    Configuration menu
    Copy the full SHA
    a5f1307 View commit details
    Browse the repository at this point in the history
  3. core: fix usage of uv_cwd

    It was modified in libuv to be consistent with uv_exepath and not
    include the trailing NULL byte in the returned size.
    
    PR-URL: #8566
    Reviewed-by: Fedor Indutny <fedor@indutny.com>
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    saghul authored and trevnorris committed Nov 6, 2014
    Configuration menu
    Copy the full SHA
    e46cbaa View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2014

  1. uv: revert change causing build failures

    Revert uv_thread_self() to return unsigned long instead of uv_thread_t.
    This was causing a build failure on Windows and is only a temporary fix
    until the proper patch lands upstream.
    
    Reverts: joyent/libuv@59658a8
    Fixes: ce112c2 "deps: update uv to v1.0.0-rc2"
    trevnorris committed Nov 7, 2014
    Configuration menu
    Copy the full SHA
    5845a6b View commit details
    Browse the repository at this point in the history
  2. doc: remove tls.createSecurePair deprecation

    pending tls.TLSSocket growing the ability to work
    with streams, createSecurePair will remain.
    
    PR-URL: #8695
    Reviewed-by: Fedor Indutny <fedor@indutny.com>
    chrisdickinson committed Nov 7, 2014
    Configuration menu
    Copy the full SHA
    03bae7b View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2014

  1. tls: remove tls.createSecurePair code deprecation

    In https://github.com/joyent/node/pulls/8695, the deprecation was
    removed from doc.  This removes the deprecation from the code.
    
    PR-URL: #8700
    Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
    JacksonTian authored and chrisdickinson committed Nov 10, 2014
    Configuration menu
    Copy the full SHA
    d8a3c4a View commit details
    Browse the repository at this point in the history
  2. doc: note ability to require files within packages

    Adding note to api/modules.markdown about ability to
    load arbitrary path from modules from node_module path
    by adding reference to path after module name in call
    to require()
    
    PR-URL: #7794
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    Reviewed-by: Fedor Indutny <fedor@indutny.com>
    Reviewed-by: Timothy J Fontaine <tjfontaine@gmail.com>
    sudodoki authored and chrisdickinson committed Nov 10, 2014
    Configuration menu
    Copy the full SHA
    fd22268 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2014

  1. build: i18n: fix build on OSX

    Fix config option that doesn't work with OSX.
    
    Fixes: #8521
    PR-URL: #8602
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    srl295 authored and trevnorris committed Nov 12, 2014
    Configuration menu
    Copy the full SHA
    0339446 View commit details
    Browse the repository at this point in the history
  2. build: i18n: fix icu toolset dependencies

    So what I did here is to make the icutools library actually contain the
    entire ICU dependencies needed for host-side tools. Sadly, this will
    build ICU twice, but avoids conflicts between host and target side.
    This all seems like a gyp bug of some sort, but without docs for
    toolsets, who’s to say?
    
    I removed the icuio library as a separate target, because it was only
    used by the host-side tools.
    
    PR-URL: #8681
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    srl295 authored and trevnorris committed Nov 12, 2014
    Configuration menu
    Copy the full SHA
    ea4dc7d View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2014

  1. build: i18n: support little-endian machines

    Note that this may not affect anything until powerpc support lands in
    v8.
    
    Related: https://github.com/srl295/node/issues/7
    Related: srl295/node@ba8ab91
    PR-URL: #8712
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    srl295 authored and trevnorris committed Nov 13, 2014
    Configuration menu
    Copy the full SHA
    855b1c9 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2014

  1. module: correct the order of the assertions

    this puts the type-checking assertions in require
    into proper order.
    
    PR-URL: #8333
    Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
    Reviewed-by: Fedor Indutny <fedor@indutny.com>
    haoxin authored and chrisdickinson committed Nov 14, 2014
    Configuration menu
    Copy the full SHA
    00d7b13 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2014

  1. fs: fix symlink error message

    the arguments were swapped, so fs.symlink{Sync,} would
    report that the wrong file EEXIST'd in error.
    
    Fixes: #8651
    Fixes: #4314
    Fixes: #5381
    PR-URL: #8657
    Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
    vkurchatkin authored and chrisdickinson committed Nov 16, 2014
    Configuration menu
    Copy the full SHA
    f6556b6 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2014

  1. process: pid can be a string in process.kill()

    Not allowing string was a change from v0.10 behaviour, commented on in
    #7991. Allow them again, but still check that argument is
    numberish. Also, simplify the fragile and non-portable test code
    introduced in 832ec1c that required fixups 2a41535, and
    ef3c4ed.
    
    PR-URL: #8531
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    sam-github authored and trevnorris committed Nov 17, 2014
    Configuration menu
    Copy the full SHA
    743a009 View commit details
    Browse the repository at this point in the history
  2. dns: propagate domain for c-ares methods

    Fixes: #5471
    PR-URL: #8732
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    chrisdickinson committed Nov 17, 2014
    Configuration menu
    Copy the full SHA
    0fef250 View commit details
    Browse the repository at this point in the history
  3. doc: fix typos in http.markdown

    PR-URL: #4784
    Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
    cistov authored and chrisdickinson committed Nov 17, 2014
    Configuration menu
    Copy the full SHA
    adc0206 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2014

  1. doc: clarify return value of http.createServer

    PR-URL: #6054
    Reviewed-by: Isaac Z. Schlueter <i@izs.me>
    Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
    msafi authored and chrisdickinson committed Nov 19, 2014
    Configuration menu
    Copy the full SHA
    6a67823 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2014

  1. doc: correct broken link in net.markdown

    Fixes broken link to Readable Stream documentation.
    
    Fixes: #8464
    PR-URL: #8756
    Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
    OpenSourceSteve authored and chrisdickinson committed Nov 20, 2014
    Configuration menu
    Copy the full SHA
    4dc8b26 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2014

  1. path: allow calling platform specific methods

    Add path.posix and path.win32 which have the specific methods like
    resolve and normalize so you can specifically normalize or resolve
    based on the target platform.
    
    PR-URL: #5661
    Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
    tjfontaine authored and chrisdickinson committed Nov 21, 2014
    Configuration menu
    Copy the full SHA
    6a90a06 View commit details
    Browse the repository at this point in the history
  2. path: added parse() and format() functions

    The parse() function splits a path and returns an object
    with the different elements. The format() function is the
    reverse of this and adds an objects corresponding path
    elements to make up a string. Fixes #6976.
    
    Fixes: #6976
    PR-URL: #8750
    Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
    roryrjb authored and chrisdickinson committed Nov 21, 2014
    Configuration menu
    Copy the full SHA
    2d17193 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2014

  1. deps: update libuv to 1.0.0

    PR-URL: #8762
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    saghul authored and trevnorris committed Nov 26, 2014
    5 Configuration menu
    Copy the full SHA
    9d9ed61 View commit details
    Browse the repository at this point in the history
  2. path: refactor normalizeArray()

    The normalizeArray() function now avoids using the slow Array#splice()
    method to improve performance and now also filters out empty path parts.
    
    Code that pre-filtered empty parts has been removed.
    
    PR-URL: #8724
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    nwoltman authored and trevnorris committed Nov 26, 2014
    Configuration menu
    Copy the full SHA
    e0a0e91 View commit details
    Browse the repository at this point in the history
  3. smalloc: don't allow to dispose typed arrays

    PR-URL: #8743
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    vkurchatkin authored and trevnorris committed Nov 26, 2014
    Configuration menu
    Copy the full SHA
    bf3e0f4 View commit details
    Browse the repository at this point in the history
  4. deps: update libuv to 1.0.1

    PR-URL: #8785
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    saghul authored and trevnorris committed Nov 26, 2014
    Configuration menu
    Copy the full SHA
    69904c8 View commit details
    Browse the repository at this point in the history
  5. crypto: cast uv_thread_t to unsigned long

    Should work in all platforms and it fixes this compilation problem
    on OSX:
    
    ../src/node_crypto.cc:154:3: error: no matching function for call to
    'CRYPTO_THREADID_set_numeric'
      CRYPTO_THREADID_set_numeric(tid, uv_thread_self());
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~
        ../deps/openssl/openssl/include/openssl/../../crypto/crypto.h:435:6:
        note: candidate function not viable: no known conversion from
              'uv_thread_t' (aka '_opaque_pthread_t *') to 'unsigned long'
              for 2nd argument
              void CRYPTO_THREADID_set_numeric(CRYPTO_THREADID *id, unsigned
              long val);
                   ^
                   1 error generated.
    
    PR-URL: #8785
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    saghul authored and trevnorris committed Nov 26, 2014
    Configuration menu
    Copy the full SHA
    0308ad2 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2014

  1. Revert "crypto: cast uv_thread_t to unsigned long"

    This reverts commit 0308ad2.
    orangemocha committed Nov 28, 2014
    Configuration menu
    Copy the full SHA
    cb8cadb View commit details
    Browse the repository at this point in the history
  2. crypto: store thread id as pointer-sized

    In https://github.com/MSOpenTech/libuv/commit/59658a8de7cc05a58327a164fd2ed4b050f8b4f4
    the return of uv_thread_self() was changed from unsigned long to
    uv_thread_t.
    
    uv_thread_t is a HANDLE (pointer-sized) on Windows, which means that
    on Win64 it cannot be stored with CRYPTO_THREADID_set_numeric without
    data loss.
    
    Furthermore, without this change there will be a build break on Windows
    when the libuv change is integrated into Node, because of the
    conversion from HANDLE to unsigned long.
    
    Other related commits:
    5845a6b
    https://github.com/MSOpenTech/libuv/commit/919d8ec63ac53566ad1f090058ec15966bd0e960
    orangemocha committed Nov 28, 2014
    Configuration menu
    Copy the full SHA
    304c0b4 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2014

  1. modules: adding load linked modules feature

    - introduced NM_F_LINKED flag to identify linked modules
    - setting node_is_initialized after calling V8::Initialize in order to
      make the right decision during initial module registration
    - introduced modlist_linked in order to track modules that were
      pre-registered in order to complete it once node is initialized
    - completing registration of linked module similarly to the way it's
      done inside DLOpen
    
    PR-URL: #8386
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    thlorenz authored and trevnorris committed Dec 1, 2014
    Configuration menu
    Copy the full SHA
    c131c1f View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2014

  1. url: support path for url.format

    this adds support for a "path" field that overrides
    "query", "search", and "pathname" if given.
    
    Fixes: #8722
    PR-URL: #8755
    Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
    yorkie authored and chrisdickinson committed Dec 2, 2014
    Configuration menu
    Copy the full SHA
    d312b6d View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2014

  1. lint: fix code style

    Couple code style fixes to pass cpplint
    
    Fixes: 304c0b4 "crypto: store thread id as pointer-sized"
    trevnorris committed Dec 3, 2014
    Configuration menu
    Copy the full SHA
    c4f6c22 View commit details
    Browse the repository at this point in the history
  2. url: change hostname regex to negate invalid chars

    Regarding #8520
    
    This changes hostname validation from a whitelist regex approach
    to a blacklist regex approach as described in https://url.spec.whatwg.org/#host-parsing.
    
    url.parse misinterpreted `https://good.com+.evil.org/`
    as `https://good.com/+.evil.org/`.  If we use url.parse to check the
    validity of the hostname, the test passes, but in the browser the
    user is redirected to the evil.org website.
    jondavidjohn authored and trevnorris committed Dec 3, 2014
    Configuration menu
    Copy the full SHA
    6120472 View commit details
    Browse the repository at this point in the history
  3. doc: set logical umask in process.umask example

    0644 seems to be the desired mode for new files (as it is a very weird
    umask), and to achieve that the correct umask would be 0022.
    
    PR-URL: #8039
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    Carlos Campderrós authored and trevnorris committed Dec 3, 2014
    Configuration menu
    Copy the full SHA
    4815873 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2014

  1. node: fix bad assert

    It was my mistake to change an assert check. This changes it back to how
    the assert was originally done.
    
    Fixes: c131c1f "modules: adding load linked modules feature"
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    trevnorris committed Dec 4, 2014
    Configuration menu
    Copy the full SHA
    e67db01 View commit details
    Browse the repository at this point in the history
  2. test: runner support for flaky tests

    Adding --flaky-tests option, to allow regarding flaky tests failures
    as non-fatal.
    
    Currently only observed by the TapProgressIndicator, which will
    add a # TODO directive to tests classified as flaky. According to the
    TAP specification, the test harness is supposed to treat failures
    that have a # TODO directive as non-fatal.
    orangemocha committed Dec 4, 2014
    Configuration menu
    Copy the full SHA
    df3a2b2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0674cba View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2014

  1. src: remove Async Listener

    Async Listener was the name of the user-facing JS API, and is being
    completely removed. Instead low level hooks directly into the mechanism
    that AL used will be introduced in a future commit.
    
    PR-URL: #8110
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    Reviewed-by: Fedor Indutny <fedor@indutny.com>
    Reviewed-by: Alexis Campailla <alexis@janeasystems.com>
    Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
    trevnorris committed Dec 5, 2014
    Configuration menu
    Copy the full SHA
    b655955 View commit details
    Browse the repository at this point in the history
  2. async-wrap: move MakeCallback to .cc

    MakeCallback is too large a function to be inlined. Likewise, only
    having header files will not allow for any part of AsyncWrap to be
    exposed cleanly via NODE_MODULE_CONTEXT_AWARE_BUILTIN().
    
    PR-URL: #8110
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    Reviewed-by: Fedor Indutny <fedor@indutny.com>
    Reviewed-by: Alexis Campailla <alexis@janeasystems.com>
    Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
    trevnorris committed Dec 5, 2014
    Configuration menu
    Copy the full SHA
    2593c14 View commit details
    Browse the repository at this point in the history
  3. node, async-wrap: remove MakeDomainCallback

    C++ won't deoptimize like JS if specific conditional branches are
    sporadically met in the future. Combined with the amount of code
    duplication removal and simplified maintenance complexity, it makes more
    sense to merge MakeCallback and MakeDomainCallback.
    
    Additionally, type casting in V8 before verifying what that type is will
    cause V8 to abort in debug mode if that type isn't what was expected.
    Fix this by first checking the v8::Value before casting.
    
    PR-URL: #8110
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    Reviewed-by: Fedor Indutny <fedor@indutny.com>
    Reviewed-by: Alexis Campailla <alexis@janeasystems.com>
    Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
    trevnorris committed Dec 5, 2014
    Configuration menu
    Copy the full SHA
    42df679 View commit details
    Browse the repository at this point in the history
  4. node: fix throws before timer module is loaded

    An edge case could occur when the setImmediate() in _fatalException()
    would fire before the timers module had been loaded globally, causing
    Node to crash.
    
    PR-URL: #8110
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    Reviewed-by: Fedor Indutny <fedor@indutny.com>
    Reviewed-by: Alexis Campailla <alexis@janeasystems.com>
    Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
    trevnorris committed Dec 5, 2014
    Configuration menu
    Copy the full SHA
    b1e9d33 View commit details
    Browse the repository at this point in the history
  5. src: all wrap's now use actual FunctionTemplate

    Instead of simply creating a new v8::Object to contain the connection
    information, instantiate a new instance of a FunctionTemplate. This will
    allow future improvements for debugging and performance probes.
    
    Additionally, the "provider" argument in the ReqWrap constructor is no
    longer optional.
    
    PR-URL: #8110
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    Reviewed-by: Fedor Indutny <fedor@indutny.com>
    Reviewed-by: Alexis Campailla <alexis@janeasystems.com>
    Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
    trevnorris committed Dec 5, 2014
    Configuration menu
    Copy the full SHA
    5962dbe View commit details
    Browse the repository at this point in the history
  6. src: remove unnecessary template parameter

    The template class information is received via the type of the first
    argument. So there is no need to use Wrap<T>(handle).
    
    PR-URL: #8110
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    Reviewed-by: Fedor Indutny <fedor@indutny.com>
    Reviewed-by: Alexis Campailla <alexis@janeasystems.com>
    Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
    trevnorris committed Dec 5, 2014
    Configuration menu
    Copy the full SHA
    add955e View commit details
    Browse the repository at this point in the history
  7. async-wrap: expose async-wrap as binding

    Expose basic hooks for AsyncWrap via the async_wrap binding. Right now
    only the PROVIDER types are exposed. This is a preliminary step before
    more functionality is added.
    
    PR-URL: #8110
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    Reviewed-by: Fedor Indutny <fedor@indutny.com>
    Reviewed-by: Alexis Campailla <alexis@janeasystems.com>
    Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
    trevnorris committed Dec 5, 2014
    Configuration menu
    Copy the full SHA
    1293f0a View commit details
    Browse the repository at this point in the history
  8. async-wrap: explicitly pass parent

    When instantiating a new AsyncWrap allow the parent AsyncWrap to be
    passed. This is useful for cases like TCP incoming connections, so the
    connection can be tied to the server receiving the connection.
    
    Because the current architecture instantiates the *Wrap inside a
    v8::FunctionCallback, the parent pointer is currently wrapped inside a
    new v8::External every time and passed as an argument. This adds ~80ns
    to instantiation time.
    
    A future optimization would be to add the v8::External as the data field
    when creating the v8::FunctionTemplate, change the pointer just before
    making the call then NULL'ing it out afterwards. This adds enough code
    complexity that it will not be attempted until the current approach
    demonstrates it is a bottle neck.
    
    PR-URL: #8110
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    Reviewed-by: Fedor Indutny <fedor@indutny.com>
    Reviewed-by: Alexis Campailla <alexis@janeasystems.com>
    Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
    trevnorris committed Dec 5, 2014
    Configuration menu
    Copy the full SHA
    419f18d View commit details
    Browse the repository at this point in the history
  9. async-wrap: add event hooks

    Call a user-defined callback at specific points in the lifetime of an
    asynchronous event. Which are on instantiation, just before/after the
    callback has been run.
    
    **If any of these callbacks throws an exception, there is no forgiveness
    or recovery. A message will be displayed and a core file dumped.**
    
    Currently these only tie into AsyncWrap, meaning no call to a hook
    callback will be made for timers or process.nextTick() events. Though
    those will be added in a future commit.
    
    Here are a few notes on how to make the hooks work:
    
    - The "this" of all event hook callbacks is the request object.
    
    - The zero field (kCallInitHook) of the flags object passed to
      setupHooks() must be set != 0 before the init callback will be called.
    
    - kCallInitHook only affects the calling of the init callback. If the
      request object has been run through the create callback it will always
      run the before/after callbacks. Regardless of kCallInitHook.
    
    - In the init callback the property "_asyncQueue" must be attached to
      the request object. e.g.
    
      function initHook() {
        this._asyncQueue = {};
      }
    
    - DO NOT inspect the properties of the object in the init callback.
      Since the object is in the middle of being instantiated there are some
      cases when a getter is not complete, and doing so will cause Node to
      crash.
    
    PR-URL: #8110
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    Reviewed-by: Fedor Indutny <fedor@indutny.com>
    Reviewed-by: Alexis Campailla <alexis@janeasystems.com>
    Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
    trevnorris committed Dec 5, 2014
    Configuration menu
    Copy the full SHA
    709fc16 View commit details
    Browse the repository at this point in the history
  10. uv: float patch to revert tty breakage

    Float libuv/libuv@484a3a9 to fix incorrect
    indentation in REPL.
    trevnorris committed Dec 5, 2014
    Configuration menu
    Copy the full SHA
    fe6d5be View commit details
    Browse the repository at this point in the history
  11. doc: mention callback for http res/req write & end

    Add documentation for the callback parameter of http.ClientRequest's and
    http.ServerResponse's write and end methods.
    JacksonTian authored and Julien Gilli committed Dec 5, 2014
    7 Configuration menu
    Copy the full SHA
    9653c4b View commit details
    Browse the repository at this point in the history
  12. doc: fix grammar and wording in tls and timers

    In `tls.markdown`, there was a misuse of 'a' which has been replaced
    with 'an'.
    
    In `timers.markdown`...
      line 31: misuse of 'a', replaced with 'an'
      line 59: unclear wording, haywire 'a', added new comma
    brendanashworth authored and Julien Gilli committed Dec 5, 2014
    Configuration menu
    Copy the full SHA
    70195ac View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2014

  1. build: do not generate support for libuv's probes

    Dtrace probes were removed from libuv recently, but their usage by node
    was not completely removed, causing build breaks on SmartOS.
    
    Even though the build is working on other platforms, these probes are
    not fired by libuv anymore, so there's no point in using them on these
    platforms too.
    
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    Julien Gilli committed Dec 9, 2014
    Configuration menu
    Copy the full SHA
    4dc660e View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2014

  1. deps: update libuv to 1.0.2

    PR-URL: #8847
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    saghul authored and trevnorris committed Dec 10, 2014
    Configuration menu
    Copy the full SHA
    20a7088 View commit details
    Browse the repository at this point in the history
  2. test: mark more tests as flaky

    Marking these two tests as flaky, since they have been failing
    intermittenly in recent builds:
    test-debug-signal-cluster
    test-cluster-basic
    orangemocha committed Dec 10, 2014
    Configuration menu
    Copy the full SHA
    8708c7a View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2014

  1. lib,src: fix spawnSync ignoring its 'env' option

    PR-URL: #8546
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    juamedgod authored and trevnorris committed Dec 11, 2014
    Configuration menu
    Copy the full SHA
    946cec7 View commit details
    Browse the repository at this point in the history
  2. test: add test for spawnSync() env option

    PR-URL: #8845
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    cjihrig authored and trevnorris committed Dec 11, 2014
    Configuration menu
    Copy the full SHA
    4bba870 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2014

  1. doc: clarify create{Read,Write}Stream fd option

    Clarify the fd option: it is preferred to the path parameter, omits
    the "open" event if given, and is available on WriteStreams as well.
    
    PR-URL: #7707
    Fixes: #7707
    Fixes: #7708
    Fixes: #4367
    Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
    benjamincburns authored and chrisdickinson committed Dec 16, 2014
    Configuration menu
    Copy the full SHA
    5b9e5bd View commit details
    Browse the repository at this point in the history
  2. zlib: support concatenated gzip files

    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    PR-URL: #6442
    eendeego authored and chrisdickinson committed Dec 16, 2014
    Configuration menu
    Copy the full SHA
    6f6a979 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2014

  1. debugger: fix unhandled error in setBreakpoint

    Fix Interface.setBreakpoint() to correctly handle an attempt to set a
    breakpoint in the current script when there is no current script.
    This usually happens when the debugged process is not paused.
    
    Fixes: #6453
    PR-URL: #6460
    Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
    bajtos authored and chrisdickinson committed Dec 17, 2014
    Configuration menu
    Copy the full SHA
    e93ff4f View commit details
    Browse the repository at this point in the history
  2. src: fix windows build error

    Fix a Windows-only build error that was introduced in
    commit 1183ba4 ("zlib: support concatenated gzip files").
    
    Rename the NO_ERROR and FAILED enumerations, they conflict
    with macros of the same name in <winerror.h>.
    
    PR-URL: #8893
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    Reviewed-By: Rod Vagg <rod@vagg.org>
    Reviewed-by: Timothy J Fontaine <tjfontaine@gmail.com>
    bnoordhuis authored and chrisdickinson committed Dec 17, 2014
    Configuration menu
    Copy the full SHA
    93533e9 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2014

  1. stream: switch _writableState.buffer to queue

    In cases where many small writes are made to a stream
    lacking _writev, the array data structure backing the
    WriteReq buffer would greatly increase GC pressure.
    
    Specifically, in the fs.WriteStream case, the
    clearBuffer routine would only clear a single WriteReq
    from the buffer before exiting, but would cause the
    entire backing array to be GC'd. Switching to [].shift
    lessened pressure, but still the bulk of the time was
    spent in memcpy.
    
    This replaces that structure with a linked list-backed
    queue so that adding and removing from the queue is O(1).
    In the _writev case, collecting the buffer requires an
    O(N) loop over the buffer, but that was already being
    performed to collect callbacks, so slowdown should be
    neglible.
    
    PR-URL: #8826
    Reviewed-by: Timothy J Fontaine <tjfontaine@gmail.com>
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    chrisdickinson committed Dec 18, 2014
    1 Configuration menu
    Copy the full SHA
    9158666 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2014

  1. doc: add details for http res/req end callback

    Add documentation for the callback parameter of http.ClientRequest's and
    http.ServerResponse's end methods.
    
    Signed-off-by: Julien Gilli <julien.gilli@joyent.com>
    JacksonTian authored and Julien Gilli committed Dec 19, 2014
    Configuration menu
    Copy the full SHA
    890baa0 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2014

  1. url: improve parsing speed

    The url.parse() function now checks whether an escapable character is in
    the URL before trying to escape it.
    
    PR-URL: #8638
    [trev.norris@gmail.com: Switch to use continue instead of if]
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    CGavrila authored and trevnorris committed Dec 30, 2014
    Configuration menu
    Copy the full SHA
    6a03fce View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2015

  1. build: i18n: add icu config options

    Make "--with-intl=none" the default and add "intl-none" option to
    vcbuild.bat.
    
    If icu data is missing print a warning unless either --download=all or
    --download=icu is set. If set then automatically download, verify (MD5)
    and unpack the ICU data if not already available.
    
    There's a "list" of URLs being used, but right now only the first is
    picked up. The logic works something like this:
    
    * If there is no directory deps/icu,
      * If no zip file (currently icu4c-54_1-src.zip),
        * Download zip file (icu-project.org -> sf.net)
      * Verify the MD5 sum of the zipfile
        * If bad, print error and exit
      * Unpack the zipfile into deps/icu
    * If deps/icu now exists, use it, else fail with help text
    
    Add the configuration option "--with-icu-source=..."
    
    Usage:
      * --with-icu-source=/path/to/my/other/icu
      * --with-icu-source=/path/to/icu54.zip
      * --with-icu-source=/path/to/icu54.tgz
      * --with-icu-source=http://example.com/icu54.tar.bz2
    
    Add the configuration option "--with-icu-locals=...".  Allows choosing
    which locales are used in the "small-icu" case.
    
    Example:
        configure --with-intl=small-icu --with-icu-locales=tlh,grc,nl
    
    (Also note that as of this writing, neither Klingon nor Ancient Greek
    are in upstream CLDR data. Serving suggestion only.)
    
    Don't use hard coded ../../out paths on windows. This was suggested by
    @misterdjules as it causes test failures.  With this fix, "out" is no
    longer created on windows and the following can run properly:
    
        python tools/test.py simple
    
    Reduce space by about 1MB with ICU 54 (over without this patch). Also
    trims a few other source files, but only conditional on the exact ICU
    version used. This is to future-proof - a file that is unneeded now may
    be needed in future ICUs.
    
    Also:
      * Update distclean to remove icu related files
      * Refactor some code into tools/configure.d/nodedownload.py
      * Update docs
      * Add test
    
    PR-URL: #8719
    Fixes: #7676 (comment)
    [trev.norris@gmail.com small change to test's whitespace and logic]
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    srl295 authored and trevnorris committed Jan 3, 2015
    2 Configuration menu
    Copy the full SHA
    a308395 View commit details
    Browse the repository at this point in the history
  2. docs: update to authors file

    PR-URL: #8964
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    srl295 authored and trevnorris committed Jan 3, 2015
    Configuration menu
    Copy the full SHA
    8cfbeed View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2015

  1. net: make connect() input validation synchronous

    Socket.prototype.connect() sometimes throws on bad inputs
    after an asynchronous operation. This commit makes the input
    validation synchronous. This commit also removes some hard
    coded IP addresses.
    
    PR-URL: #8180
    Fixes: #8140
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
    cjihrig committed Jan 4, 2015
    Configuration menu
    Copy the full SHA
    b636ba8 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2015

  1. smalloc: fix bad assert for zero length data

    If the data length passed to smalloc.alloc() the array_length will be
    zero, causing an overflow check to fail. This prevents that from
    happening.
    
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    trevnorris committed Jan 5, 2015
    Configuration menu
    Copy the full SHA
    372a2f5 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2015

  1. src,zlib: revert concatenated-stream changes

    Revert "src: fix windows build error" and "zlib: support
    concatenated gzip files". Treating subsequent data as a
    concatenated stream breaks npm install.
    
    This reverts commits 93533e9
    and 6f6a979.
    
    Fixes: #8962
    PR-URL: #8985
    Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
    chrisdickinson committed Jan 7, 2015
    Configuration menu
    Copy the full SHA
    c8ef97e View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2015

  1. test: fix test-process-active-wraps.js

    b636ba8 caused a regression
    on Windows due to the way server handles are cleaned up. This
    commit fixes the test by allowing the handle to be cleaned up.
    
    Fixes: #8986
    PR-URL: #8998
    Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
    Reviewed-By: Bert Belder <bertbelder@gmail.com>
    cjihrig committed Jan 8, 2015
    Configuration menu
    Copy the full SHA
    1fad373 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2015

  1. Configuration menu
    Copy the full SHA
    4ef09c6 View commit details
    Browse the repository at this point in the history
  2. cluster: tests multiple open of ports in workers

    Note that test/simple/test-cluster-dgram-4.js is a simplified case, since
    dgram.send() for clients does an implict .bind(0), so it could also be written
    as:
    
      A = dgram.createSocket('udp4')
      A.send(...)
      A.close();
      ... time passes...
      B = dgram.createSocket('udp4')
      B.send(...)
      B.close();
    
    Above was the original form, dscape/lynx kills the cluster master when run in
    a worker.
    
    IMO, dgram-4 is the most serious of this, using multiple dgram client sockets
    is currently impossible with cluster.
    
    Also note test/simple/test-cluster-net-listen-2.js, the TCP equivalent of
    dgram-4, passes, because TCP close causes the cluster master to be notified,
    UDP close does not.
    
    Also, note that I use the ephemeral "flag" port `0` in the tests, the same
    failure is seen with any port.
    sam-github committed Jan 12, 2015
    Configuration menu
    Copy the full SHA
    bc34188 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8a6e79f View commit details
    Browse the repository at this point in the history
  4. fixup! wait for close event on A before opening B

    In case that would help the tests pass... but it does not.
    sam-github committed Jan 12, 2015
    Configuration menu
    Copy the full SHA
    1e1aa91 View commit details
    Browse the repository at this point in the history