-
Notifications
You must be signed in to change notification settings - Fork 7.3k
cluster: tests multiple open of ports in workers #8027
cluster: tests multiple open of ports in workers #8027
Commits on Sep 17, 2014
-
doc: http.request() improved code example
Reviewed-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Fedor Indutny <fedor@indutny.com>
2Configuration menu - View commit details
-
Copy full SHA for 468fb54 - Browse repository at this point
Copy the full SHA 468fb54View commit details -
doc: console example improvement
Reviewed-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Fedor Indutny <fedor@indutny.com>
Configuration menu - View commit details
-
Copy full SHA for 378d972 - Browse repository at this point
Copy the full SHA 378d972View commit details -
win: manifest node.exe for Windows 8.1
Adding a compatibility section to node.exe embedded manifest so that Node is declared explicitly compatible with Windows 8.1. Required so that os.release() can return the correct version on Windows 8.1. See http://msdn.microsoft.com/en-us/library/windows/desktop/ms724451(v=vs.85).aspx Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 03e9352 - Browse repository at this point
Copy the full SHA 03e9352View commit details -
crypto: clarify RandomBytes() error msg
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c615545 - Browse repository at this point
Copy the full SHA c615545View commit details -
crypto: never store pointer to conn in SSL_CTX
SSL_CTX is shared between multiple connections and is not a right place to store per-connection data. fix #8348 Reviewed-By: Trevor Norris
Configuration menu - View commit details
-
Copy full SHA for cb4ed3c - Browse repository at this point
Copy the full SHA cb4ed3cView commit details
Commits on Sep 18, 2014
-
test: add test for cluster.worker.destroy()
Add a simple test to cover workers' implementation of Worker.prototype.destroy(). Before adding this test, this code wouldn't be covered by the tests suite, and any regression introduced in workers' implementation of Worker.prototype.destroy wouldn't be caught. Fixes: #8223 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9c992bd - Browse repository at this point
Copy the full SHA 9c992bdView commit details -
node: support v8 microtask queue
When V8 started supporting Promises natively it also introduced a microtack queue. This feature operates similar to process.nextTick(), and created an issue where neither knew when the other had run. This patch has nextTick() call the microtask queue runner at the end of processing callbacks in the nextTickQueue. Fixes: #7714 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 30bd7b6 - Browse repository at this point
Copy the full SHA 30bd7b6View commit details
Commits on Sep 19, 2014
-
doc: corrected typo in vm docs
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d66adf0 - Browse repository at this point
Copy the full SHA d66adf0View commit details
Commits on Sep 20, 2014
-
buffer: improve Buffer constructor
Increase the performance of new Buffer construction by initializing all properties before SetIndexedPropertiesToExternalArrayData call. Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4c9b30d - Browse repository at this point
Copy the full SHA 4c9b30dView commit details
Commits on Sep 23, 2014
-
http: write() after end() emits an error.
When calling write() after end() has been called on an OutgoingMessage, an error is emitted and the write's callback is called with an instance of Error. Fix #7477. Reviewed-By: Fedor Indutny <fedor@indutny.com>
Configuration menu - View commit details
-
Copy full SHA for 64d6de9 - Browse repository at this point
Copy the full SHA 64d6de9View commit details -
crypto: export externals to internal structs
Export External getters for a internal structs: SSL, SSL_CTX.
Configuration menu - View commit details
-
Copy full SHA for 6e08bb9 - Browse repository at this point
Copy the full SHA 6e08bb9View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5f5d4c - Browse repository at this point
Copy the full SHA c5f5d4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7fd35e6 - Browse repository at this point
Copy the full SHA 7fd35e6View commit details
Commits on Sep 24, 2014
-
buffer: fix map and set parent to undefined
In 4c9b30d removal of the prototype attributes meant NativeBuffer() no longer had the same object map as Buffer(). By now setting the same properties in the same order both constructors will produce the same map. The same commit changed "parent" from undefined to null. This caused a failure in Buffer#slice() where it was checked if parent === undefined. Causing the incorrect parent to be set. Signed-off-by: Trevor Norris <trev.norris@gmail.com>
1Configuration menu - View commit details
-
Copy full SHA for 7c3c51b - Browse repository at this point
Copy the full SHA 7c3c51bView commit details -
tls_wrap: ensure that TLSCallbacks are gc-able
Call `MakeWeak()` to destruct TLSCallbacks when the js-object dies. fix #8416 Reviewed-By: Fedor Indutny <fedor@indutny.com>
Configuration menu - View commit details
-
Copy full SHA for 4dbb84f - Browse repository at this point
Copy the full SHA 4dbb84fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f7234d - Browse repository at this point
Copy the full SHA 2f7234dView commit details -
test: disable dgram-bind-shared-ports on win32
Windows currently doesn't support clustered dgram sockets, when it does re-enable this test
Configuration menu - View commit details
-
Copy full SHA for f773fb4 - Browse repository at this point
Copy the full SHA f773fb4View commit details -
benchmark: add test for module loader
Adds a test for benchmarking the module loader, needed for benchmarking changes / refacortings in the module loader. Reviewed-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Timothy J Fontaine <tjfontaine@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for efa47e5 - Browse repository at this point
Copy the full SHA efa47e5View commit details -
net: Make server.connections un-enumerable
The property server.connections should no longer be enumerable because it has been deprecated. This will prevent deprecation warnings when server objects are accessed by functions such as JSON.stringify. Fixes: #8373 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b26dd4e - Browse repository at this point
Copy the full SHA b26dd4eView commit details
Commits on Sep 25, 2014
-
Configuration menu - View commit details
-
Copy full SHA for 9fad895 - Browse repository at this point
Copy the full SHA 9fad895View commit details -
2014.09.24, Version 0.11.14 (Unstable)
* uv: Upgrade to v1.0.0-rc1 * http_parser: Upgrade to v2.3.0 * npm: Upgrade to v2.0.0 * openssl: Upgrade to v1.0.1i * v8: Upgrade to 3.26.33 * Add fast path for simple URL parsing (Gabriel Wicke) * Added support for options parameter in console.dir() (Xavi Magrinyà) * Cluster: fix shared handles on Windows (Alexis Campailla) * buffer: Fix incorrect Buffer.compare behavior (Feross Aboukhadijeh) * buffer: construct new buffer from buffer toJSON() output (cjihrig) * buffer: improve Buffer constructor (Kang-Hao Kenny) * build: linking CoreFoundation framework for OSX (Thorsten Lorenz) * child_process: accept uid/gid everywhere (Fedor Indutny) * child_process: add path to spawn ENOENT Error (Ryan Cole) * child_process: copy spawnSync() cwd option to proper buffer (cjihrig) * child_process: do not access stderr when stdio set to 'ignore' (cjihrig) * child_process: don't throw on EAGAIN (Charles) * child_process: don't throw on EMFILE/ENFILE (Ben Noordhuis) * child_process: use full path for cmd.exe on Win32 (Ed Morley) * cluster: allow multiple calls to setupMaster() (Ryan Graham) * cluster: centralize removal from workers list. (Julien Gilli) * cluster: enable error/message events using .worker (cjihrig) * cluster: include settings object in 'setup' event (Ryan Graham) * cluster: restore v0.10.x setupMaster() behaviour (Ryan Graham) * cluster: support options in Worker constructor (cjihrig) * cluster: test events emit on cluster.worker (Sam Roberts) * console: console.dir() accepts options object (Xavi Magrinyà) * crypto: add `honorCipherOrder` argument (Fedor Indutny) * crypto: allow padding in RSA methods (Fedor Indutny) * crypto: clarify RandomBytes() error msg (Mickael van der Beek) * crypto: never store pointer to conn in SSL_CTX (Fedor Indutny) * crypto: unsigned value can't be negative (Brian White) * dgram: remove new keyword from errnoException (Jackson Tian) * dns: always set variable family in lookup() (cjihrig) * dns: include host name in error message if available (Maciej Małecki) * dns: introduce lookupService function (Saúl Ibarra Corretgé) * dns: send lookup c-ares errors to callback (Chris Dickinson) * dns: throw if hostname is not string or falsey (cjihrig) * events: Output the event that is leaking (Arnout Kazemier) * fs: close file if fstat() fails in readFile() (cjihrig) * fs: fs.readFile should not throw uncaughtException (Jackson Tian) * http: add 308 status_code, see RFC7238 (Yazhong Liu) * http: don't default OPTIONS to chunked encoding (Nick Muerdter) * http: fix bailout for writeHead (Alex Kocharin) * http: remove unused code block (Fedor Indutny) * http: write() after end() emits an error. (Julien Gilli) * lib, src: add vm.runInDebugContext() (Ben Noordhuis) * lib: noisy deprecation of child_process customFds (Ryan Graham) * module: don't require fs several times (Robert Kowalski) * net,dgram: workers can listen on exclusive ports (cjihrig) * net,stream: add isPaused, don't read() when paused (Chris Dickinson) * net: Ensure consistent binding to IPV6 if address is absent (Raymond Feng) * net: add remoteFamily for socket (Jackson Tian) * net: don't emit listening if handle is closed (Eli Skeggs) * net: don't prefer IPv4 addresses during resolution (cjihrig) * net: don't throw on net.Server.close() (cjihrig) * net: reset `errorEmitted` on reconnect (Ed Umansky) * node: set names for prototype methods (Trevor Norris) * node: support v8 microtask queue (Vladimir Kurchatkin) * path: fix slice OOB in trim (Lucio M. Tato) * path: isAbsolute() should always return boolean (Herman Lee) * process: throw TypeError if kill pid not a number (Sam Roberts) * querystring: custom encode and decode (fengmk2) * querystring: do not add sep for empty array (cjihrig) * querystring: remove prepended ? from query field (Ezequiel Rabinovich) * readline: fix close event of readline.Interface() (Yazhong Liu) * readline: fixes scoping bug (Dan Kaplun) * readline: implements keypress buffering (Dan Kaplun) * repl: fix multi-line input (Fedor Indutny) * repl: fix overwrite for this._prompt (Yazhong Liu) * repl: proper `setPrompt()` and `multiline` support (Fedor Indutny) * stream: don't try to finish if buffer is not empty (Vladimir Kurchatkin) * stream: only end reading on null, not undefined (Jonathan Reem) * streams: set default hwm properly for Duplex (Andrew Oppenlander) * string_bytes: ucs2 support big endian (Andrew Low) * tls, crypto: add DHE support (Shigeki Ohtsu) * tls: `checkServerIdentity` option (Trevor Livingston) * tls: add DHE-RSA-AES128-SHA256 to the def ciphers (Shigeki Ohtsu) * tls: better error reporting at cert validation (Fedor Indutny) * tls: support multiple keys/certs (Fedor Indutny) * tls: throw an error, not string (Jackson Tian) * udp: make it possible to receive empty udp packets (Andrius Bentkus) * url: treat the same as / (isaacs)
Configuration menu - View commit details
-
Copy full SHA for fd896d5 - Browse repository at this point
Copy the full SHA fd896d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e4fc88 - Browse repository at this point
Copy the full SHA 8e4fc88View commit details -
doc: fix brackets for optional parameters
Documentation incorrectly used bracket notation for optional parameters. This caused inconsistencies in usage because of examples like the following: fs.write(fd, data[, position[, encoding]], callback) This simply fixes all uses of bracket notation in documentation. Signed-off-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Fedor Indutny <fedor@indutny.com>
Configuration menu - View commit details
-
Copy full SHA for 51b6b68 - Browse repository at this point
Copy the full SHA 51b6b68View commit details -
readline: fix performance issue when large line
Only run lineEnding.test() on the newly acquired chunk of string instead of on the entire line buffer. Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f3473d7 - Browse repository at this point
Copy the full SHA f3473d7View commit details -
child_process: improve spawn() argument handling
Add stricter argument type checking to normalizeSpawnArguments(). Removes a number of extraneous checks in spawn(). Fix regression in handling of the optional args argument. Add more thorough testing of spawn() arguments. Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9d95774 - Browse repository at this point
Copy the full SHA 9d95774View commit details
Commits on Sep 26, 2014
-
crypto: lower RSS usage for TLSCallbacks
Don't allocate any BIO buffers initially, do this on a first read from the TCP connection. Allocate different amount of data for initial read and for consequent reads: small buffer for hello+certificate, big buffer for better throughput. see #8416
Configuration menu - View commit details
-
Copy full SHA for 2122a77 - Browse repository at this point
Copy the full SHA 2122a77View commit details
Commits on Sep 29, 2014
-
timer_wrap: remove HandleScopes, check return size
Calls from JS to C++ have an implicit HandleScope. So there is no need to instantiate a new HandleScope in these basic cases. Check if the returned int64_t is an SMI and cast the return value to uint32_t instead of a double. Prevents needing to box the return value, and saves a small amount of execution time. Signed-off-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for de312cf - Browse repository at this point
Copy the full SHA de312cfView commit details -
Several fields on OutgoingMessage were set after instantiation. These have been included in the constructor to prevent mutation of the object map after instantiation. "name" is now explicitly checked to be a string. Where before if a non-string was passed the following cryptic error was thrown: _http_outgoing.js:334 var key = name.toLowerCase(); ^ TypeError: undefined is not a function Signed-off-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 979d0ca - Browse repository at this point
Copy the full SHA 979d0caView commit details -
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f4df805 - Browse repository at this point
Copy the full SHA f4df805View commit details -
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 734fb49 - Browse repository at this point
Copy the full SHA 734fb49View commit details -
doc: fix optional parameter parsing
The parameter parser specifically looked for the old bracket syntax. This generated a lot of warnings when building the docs. Those warnings have been fixed by changing the parsing logic. Signed-off-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f2a78de - Browse repository at this point
Copy the full SHA f2a78deView commit details
Commits on Sep 30, 2014
-
buffer: fix and cleanup fill()
Running fill() with an empty string would cause Node to hang indefinitely. Now it will return without having operated on the buffer. User facing function has been pulled into JS to perform all initial value checks and coercions. The C++ method has been placed on the "internal" object. Coerced non-string values to numbers to match v0.10 support. Simplified logic and changed a couple variable names. Added tests for fill() and moved them all to the beginning of buffer-test.js since many other tests depend on fill() working properly. Fixes: #8469 Signed-off-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 57ed3da - Browse repository at this point
Copy the full SHA 57ed3daView commit details
Commits on Oct 1, 2014
-
http: Improve _addHeaderLines method
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1781c8b - Browse repository at this point
Copy the full SHA 1781c8bView commit details -
doc: note stdout and stderr special behaviors.
Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 95726b0 - Browse repository at this point
Copy the full SHA 95726b0View commit details -
build, i18n: improve Intl build, add "--with-intl"
The two main goals of this change are: - To make it easier to build the Intl option using ICU (particularly, using a newer ICU than v8/Chromium's version) - To enable a much smaller ICU build with only English support The goal here is to get node.js binaries built this way by default so that the Intl API can be used. Additional data can be added at execution time (see Readme and wiki) More details are at #7719 In particular, this change adds the "--with-intl=" configure option to provide more ways of building "Intl": - "full-icu" picks up an ICU from deps/icu - "small-icu" is similar, but builds only English - "system-icu" uses pkg-config to find an installed ICU - "none" does nothing (no Intl) For Windows builds, the "full-icu" or "small-icu" options are added to vcbuild.bat. Note that the existing "--with-icu-path" option is not removed from configure, but may not be used alongside the new option. Wiki changes have already been made on https://github.com/joyent/node/wiki/Installation and a new page created at https://github.com/joyent/node/wiki/Intl (marked as provisional until this change lands.) Summary of changes: * README.md : doc updates * .gitignore : added "deps/icu" as this is the location where ICU is unpacked to. * Makefile : added the tools/icu/* files to cpplint, but excluded a problematic file. * configure : added the "--with-intl" option mentioned above. Calculate at config time the list of ICU source files to use and data packaging options. * node.gyp : add the new files src/node_i18n.cc/.h as well as ICU linkage. * src/node.cc : add call into node::i18n::InitializeICUDirectory(icu_data_dir) as well as new --icu-data-dir option and NODE_ICU_DATA env variable to configure ICU data loading. This loading is only relevant in the "small" configuration. * src/node_i18n.cc : new source file for the above Initialize.. function, to setup ICU as needed. * tools/icu : new directory with some tools needed for this build. * tools/icu/icu-generic.gyp : new .gyp file that builds ICU in some new ways, both on unix/mac and windows. * tools/icu/icu-system.gyp : new .gyp file to build node against a pkg-config detected ICU. * tools/icu/icu_small.json : new config file for the "English-only" small build. * tools/icu/icutrim.py : new tool for trimming down ICU data. Reads the above .json file. * tools/icu/iculslocs.cc : new tool for repairing ICU data manifests after trim operation. * tools/icu/no-op.cc : dummy file to force .gyp into using a C++ linker. * vcbuild.bat : added small-icu and full-icu options, to call into configure. * Fixed toolset dependencies, see #7719 (comment) Note that because of a bug in gyp {CC,CXX}_host must also be set. Otherwise gcc/g++ will be used by default for part of the build. Reviewed-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Fedor Indutny <fedor@indutny.com>
Configuration menu - View commit details
-
Copy full SHA for ac2857b - Browse repository at this point
Copy the full SHA ac2857bView commit details -
Match the behavior of the slow path by setting url.query to an empty object when the url contains no query, but query parsing is requested. Also add a test for this case, and update the documents to clearly reflect this behavior. Fixes: #8332 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b705b73 - Browse repository at this point
Copy the full SHA b705b73View commit details -
node: avoid automatic microtask runs
Since we are taking control of the microtask queue it makes sense to disable autorun and only run microtasks when necessary. Just setting isolate->SetAutorunMicrotasks(false) would cause _tickCallback() not to be called. Automatically running the microtask queue will cause it to run: * After callback invocation * Inside _tickCallback() * After _tickCallback() invocation The third one is unnecessary as the microtask queue is guaranteed to be empty at this point. The first only needs to be run manually when _tickCallback() isn't going to be called by MakeCallback(). Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8dc6be1 - Browse repository at this point
Copy the full SHA 8dc6be1View commit details -
readline: should not require an output stream.
Passing null as the output stream to readline.Interface()'s constructor is now supported. Any output written by readline is just discarded. It makes it easier to use readline just as a line parser. Fixes: #4408 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 862cc28 - Browse repository at this point
Copy the full SHA 862cc28View commit details -
buffer: mv floating point read/write checks to JS
Performance improvement by moving checks for floating point operations to JS and doing the operation on a protected internal function that assumes all arguments are correct. Still abort if the operation overflows memory. This can only be caused if the Buffer's length property isn't the same as the actual internal length. Signed-off-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e9ca7b9 - Browse repository at this point
Copy the full SHA e9ca7b9View commit details
Commits on Oct 3, 2014
-
buffer: add generic functions for (u)int ops
Add generic functions for (U)Int read/write operations on Buffers. These support up to and including 48 bit reads and writes. Include documentation and tests. Additional work done by Trevor Norris to include 40 and 48 bit write support. Because bitwise operations cannot be used on values greater than 32 bits, the operations have been replaced with mathematical calculations. Regardless, they are still faster than floating point operations. Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 83d7d9e - Browse repository at this point
Copy the full SHA 83d7d9eView commit details -
util: add es6 Symbol support for
util.inspect
* `util.inspect` cannot accept es6 symbol primitive * It will throw exception if do `util.inspect(Symbol())` * This also affects repl, console.log, etc. Reviewed-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cb97bcd - Browse repository at this point
Copy the full SHA cb97bcdView commit details
Commits on Oct 7, 2014
-
Associates link to dns.lookup() with proper URL. Fixes: #8018 Reviewed-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 87ce067 - Browse repository at this point
Copy the full SHA 87ce067View commit details -
The docs for readLine.pause are misleading. I seriously spent hours on this. If it isn't a bug, at least it should be well documented. Someone else stumbled on this too: http://stackoverflow.com/questions/21341050/pausing-readline-in-node-js Reviewed-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8392e8c - Browse repository at this point
Copy the full SHA 8392e8cView commit details -
url: fixed encoding for slash switching emulation.
Fixes: #8458 Reviewed-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 640ad63 - Browse repository at this point
Copy the full SHA 640ad63View commit details -
build: i18n: move noisy variables to separate gypi
Fixes: #7676 (comment) Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f769d13 - Browse repository at this point
Copy the full SHA f769d13View commit details -
build: i18n: py27 -> py26 dependency
Move from argparse to optparse for dependency management. Fixes: #7719 (comment) Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0a22ed4 - Browse repository at this point
Copy the full SHA 0a22ed4View commit details
Commits on Oct 8, 2014
-
Configuration menu - View commit details
-
Copy full SHA for f04f3a0 - Browse repository at this point
Copy the full SHA f04f3a0View commit details -
PR-URL: #8498 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6e4bd49 - Browse repository at this point
Copy the full SHA 6e4bd49View commit details -
smalloc: update use of ExternalArrayType constants
The constants in enum v8::ExternalArrayType have been changed. The old values are there for legacy reasons, but it's best to update anyway. Signed-off-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4809c7a - Browse repository at this point
Copy the full SHA 4809c7aView commit details -
Signed-off-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7b4a540 - Browse repository at this point
Copy the full SHA 7b4a540View commit details -
tools: fix for testing openssl integrations
Windows doesn't resolve ".." the way we expect it for symlinks and junctions. PR-URL: #8489 Reviewed-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Fedor Indutny <fedor@indutny.com>
Configuration menu - View commit details
-
Copy full SHA for 573e6af - Browse repository at this point
Copy the full SHA 573e6afView commit details -
src: update use of ExternalArrayType constants
Continuation of 4809c7a to update the use of v8::ExternalArrayType. Signed-off-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for bdc2ea4 - Browse repository at this point
Copy the full SHA bdc2ea4View commit details -
buffer, doc: misc. fix and cleanup
* Add official documentation that a Buffer instance is a viable argument when instantiating a new Buffer. * Properly set the poolOffset when a buffer needs to be truncated. * Add comments clarifying specific peculiar coding choices. * Remove a level of unnecessary indentation. Signed-off-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6462519 - Browse repository at this point
Copy the full SHA 6462519View commit details -
tls_wrap: ignore ZERO_RETURN after close_notify
Do not call SSL_read() and ignore ZERO_RETURN if the connection was shutdown and there could not be any reads. Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> PR-URL: #8519
Configuration menu - View commit details
-
Copy full SHA for a2a3fd4 - Browse repository at this point
Copy the full SHA a2a3fd4View commit details -
Reviewed-By: Fedor Indutny <fedor@indutny.com> PR-URL: #8476
Configuration menu - View commit details
-
Copy full SHA for 9116b24 - Browse repository at this point
Copy the full SHA 9116b24View commit details -
deps: apply floating irhydra patch to v8
Reviewed-By: Fedor Indutny <fedor@indutny.com> PR-URL: #8476
Configuration menu - View commit details
-
Copy full SHA for 270e998 - Browse repository at this point
Copy the full SHA 270e998View commit details -
deps: fix postmortem-metadata generator in v8
Reviewed-By: Fedor Indutny <fedor@indutny.com> PR-URL: #8476
Configuration menu - View commit details
-
Copy full SHA for 8efcc7f - Browse repository at this point
Copy the full SHA 8efcc7fView commit details -
deps: re-implement debugger-agent
Reviewed-By: Trevor Norris <trevnorris@gmail.com> PR-URL: #8476
Configuration menu - View commit details
-
Copy full SHA for 7a0cfe9 - Browse repository at this point
Copy the full SHA 7a0cfe9View commit details -
cluster: do not signal children in debug mode
Do not send signal to children if they are already in debug mode. Node.js on Windows does not register signal handler, and thus calling `process._debugProcess()` will throw an error. Reviewed-By: Trevor Norris <trevnorris@gmail.com> PR-URL: #8476
Configuration menu - View commit details
-
Copy full SHA for 42ecd48 - Browse repository at this point
Copy the full SHA 42ecd48View commit details -
src, test: fixup after v8 update
Because of behavior change of some V8 APIs (they mostly became more strict), following modules needed to be fixed: * crypto: duplicate prototype methods are not allowed anymore * contextify: some TryCatch trickery, the binding was using it incorrectly * util: maximum call stack error is now crashing in a different place Reviewed-By: Trevor Norris <trevnorris@gmail.com> PR-URL: #8476
Configuration menu - View commit details
-
Copy full SHA for 685ac09 - Browse repository at this point
Copy the full SHA 685ac09View commit details -
test: fix debug-signal-cluster after da update
The cluster children are hitting breakpoint at `cluster.onread` and hanging on a Semaphore wait now. This prevents them from disconnecting gracefully. Considering that the test is checking different thing, the cluster children needs to be force killed from the grand parent process. Reviewed-By: Trevor Norris <trevnorris@gmail.com> PR-URL: #8476
Configuration menu - View commit details
-
Copy full SHA for d87480b - Browse repository at this point
Copy the full SHA d87480bView commit details -
crypto: createDiffieHellman throw for bad args
Previously crypto.createDiffieHellman() would fail silently when a bad argument was passed for prime/prime_length. Now throws TypeError. Fixes: #8480 Signed-off-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1a4a189 - Browse repository at this point
Copy the full SHA 1a4a189View commit details -
doc: fix wording and punctuation in modules
[trev.norris@gmail.com: break lines at 80 characters] Signed-off-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 47f119c - Browse repository at this point
Copy the full SHA 47f119cView commit details
Commits on Oct 9, 2014
-
test: fix test-child-process-spawn-typeerror
You cannot spawn 'dir' on Windows because it's not an executable. Also, some people might have 'ls' on their path on Windows, so I changed invalidCmd to something that's highly unlikely to exist. Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 61dd74b - Browse repository at this point
Copy the full SHA 61dd74bView commit details -
doc: correct createSecureContext
Remove incorrect stablity indication of tls.createSecureContext, and format stablity indication of crypto.createCredentials. Fixes: e50749 "doc: document `tls.createSecureContext`" Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for db7df57 - Browse repository at this point
Copy the full SHA db7df57View commit details -
Configuration menu - View commit details
-
Copy full SHA for 874dd59 - Browse repository at this point
Copy the full SHA 874dd59View commit details
Commits on Oct 10, 2014
-
build: vcbuild fix "The input line is too long."
vcbuild.bat is calling vcvars.bat, which doesn't detect if the environment has already been set. This causes repeated entries to be added to the PATH, which after a few invocations will lead to an error: The input line is too long.
Configuration menu - View commit details
-
Copy full SHA for d22637c - Browse repository at this point
Copy the full SHA d22637cView commit details
Commits on Oct 20, 2014
-
path: resolve normalize drive letter to lower case
make path.resolve work the same as path.normalize
Configuration menu - View commit details
-
Copy full SHA for f6e5740 - Browse repository at this point
Copy the full SHA f6e5740View commit details
Commits on Oct 25, 2014
-
Fixes: f6e5740 "path: resolve normalize drive letter to lower case" Signed-off-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6a68d64 - Browse repository at this point
Copy the full SHA 6a68d64View commit details
Commits on Oct 27, 2014
-
docs: fix smalloc.dispose() example
Also couple of additions about dispose and limitations of smalloc'ed objects. Fixes: #8625 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
1Configuration menu - View commit details
-
Copy full SHA for 15aa47e - Browse repository at this point
Copy the full SHA 15aa47eView commit details -
net: add pauseOnConnect option to createServer()
Currently when a server receives a new connection the underlying socket handle begins reading data immediately. This causes problems when sockets are passed between processes, as data can be read by the first process and thus never read by the second process. This commit allows sockets that are constructed with a handle to be paused initially. PR-URL: #8576 Fixes: #7905 Fixes: #7784 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c2b4f48 - Browse repository at this point
Copy the full SHA c2b4f48View commit details
Commits on Oct 30, 2014
-
smalloc: fix copyOnto optimization
copyOnto is broken when one argument has 1 byte size and the other > 1 byte. PR-URL: #8637 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 849fcde - Browse repository at this point
Copy the full SHA 849fcdeView commit details
Commits on Nov 5, 2014
-
smalloc: check if obj has external data
PR-URL: #8655 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f65a5cb - Browse repository at this point
Copy the full SHA f65a5cbView commit details -
This change in V8: https://code.google.com/p/v8/source/detail?r=22210 has introduced a method named OS::GetCurrentThreadId which fails to compile on OSes where a "gettid" syscall does not exist. This build issue has been fixed upstream by several changes: - https://code.google.com/p/v8/source/detail?r=23459. - https://codereview.chromium.org/649553002 - https://codereview.chromium.org/642223003 Another minor fix to the upstream changes was also necessary. See https://code.google.com/p/v8/issues/detail?id=3620 for more information. The other build issue was due to the fact that alloca.h is not included by other system includes on SmartOS, which is assumed by V8. Built and tested on Linux, MacOS X, Windows and SmartOS.
1Configuration menu - View commit details
-
Copy full SHA for 3589a62 - Browse repository at this point
Copy the full SHA 3589a62View commit details -
Configuration menu - View commit details
-
Copy full SHA for 272aa58 - Browse repository at this point
Copy the full SHA 272aa58View commit details -
Configuration menu - View commit details
-
Copy full SHA for 28ae70e - Browse repository at this point
Copy the full SHA 28ae70eView commit details
Commits on Nov 6, 2014
-
PR-URL: #8566 Reviewed-by: Fedor Indutny <fedor@indutny.com> Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ce112c2 - Browse repository at this point
Copy the full SHA ce112c2View commit details -
core: replace uv_fs_readdir with uv_fs_scandir
PR-URL: #8566 Reviewed-by: Fedor Indutny <fedor@indutny.com> Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a5f1307 - Browse repository at this point
Copy the full SHA a5f1307View commit details -
It was modified in libuv to be consistent with uv_exepath and not include the trailing NULL byte in the returned size. PR-URL: #8566 Reviewed-by: Fedor Indutny <fedor@indutny.com> Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e46cbaa - Browse repository at this point
Copy the full SHA e46cbaaView commit details
Commits on Nov 7, 2014
-
uv: revert change causing build failures
Revert uv_thread_self() to return unsigned long instead of uv_thread_t. This was causing a build failure on Windows and is only a temporary fix until the proper patch lands upstream. Reverts: joyent/libuv@59658a8 Fixes: ce112c2 "deps: update uv to v1.0.0-rc2"
Configuration menu - View commit details
-
Copy full SHA for 5845a6b - Browse repository at this point
Copy the full SHA 5845a6bView commit details -
doc: remove tls.createSecurePair deprecation
pending tls.TLSSocket growing the ability to work with streams, createSecurePair will remain. PR-URL: #8695 Reviewed-by: Fedor Indutny <fedor@indutny.com>
Configuration menu - View commit details
-
Copy full SHA for 03bae7b - Browse repository at this point
Copy the full SHA 03bae7bView commit details
Commits on Nov 10, 2014
-
tls: remove tls.createSecurePair code deprecation
In https://github.com/joyent/node/pulls/8695, the deprecation was removed from doc. This removes the deprecation from the code. PR-URL: #8700 Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d8a3c4a - Browse repository at this point
Copy the full SHA d8a3c4aView commit details -
doc: note ability to require files within packages
Adding note to api/modules.markdown about ability to load arbitrary path from modules from node_module path by adding reference to path after module name in call to require() PR-URL: #7794 Reviewed-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Fedor Indutny <fedor@indutny.com> Reviewed-by: Timothy J Fontaine <tjfontaine@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fd22268 - Browse repository at this point
Copy the full SHA fd22268View commit details
Commits on Nov 12, 2014
-
Configuration menu - View commit details
-
Copy full SHA for 0339446 - Browse repository at this point
Copy the full SHA 0339446View commit details -
build: i18n: fix icu toolset dependencies
So what I did here is to make the icutools library actually contain the entire ICU dependencies needed for host-side tools. Sadly, this will build ICU twice, but avoids conflicts between host and target side. This all seems like a gyp bug of some sort, but without docs for toolsets, who’s to say? I removed the icuio library as a separate target, because it was only used by the host-side tools. PR-URL: #8681 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ea4dc7d - Browse repository at this point
Copy the full SHA ea4dc7dView commit details
Commits on Nov 13, 2014
-
build: i18n: support little-endian machines
Note that this may not affect anything until powerpc support lands in v8. Related: https://github.com/srl295/node/issues/7 Related: srl295/node@ba8ab91 PR-URL: #8712 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 855b1c9 - Browse repository at this point
Copy the full SHA 855b1c9View commit details
Commits on Nov 14, 2014
-
module: correct the order of the assertions
this puts the type-checking assertions in require into proper order. PR-URL: #8333 Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com> Reviewed-by: Fedor Indutny <fedor@indutny.com>
Configuration menu - View commit details
-
Copy full SHA for 00d7b13 - Browse repository at this point
Copy the full SHA 00d7b13View commit details
Commits on Nov 16, 2014
-
Configuration menu - View commit details
-
Copy full SHA for f6556b6 - Browse repository at this point
Copy the full SHA f6556b6View commit details
Commits on Nov 17, 2014
-
process: pid can be a string in process.kill()
Not allowing string was a change from v0.10 behaviour, commented on in #7991. Allow them again, but still check that argument is numberish. Also, simplify the fragile and non-portable test code introduced in 832ec1c that required fixups 2a41535, and ef3c4ed. PR-URL: #8531 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 743a009 - Browse repository at this point
Copy the full SHA 743a009View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fef250 - Browse repository at this point
Copy the full SHA 0fef250View commit details -
doc: fix typos in http.markdown
PR-URL: #4784 Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for adc0206 - Browse repository at this point
Copy the full SHA adc0206View commit details
Commits on Nov 19, 2014
-
doc: clarify return value of http.createServer
PR-URL: #6054 Reviewed-by: Isaac Z. Schlueter <i@izs.me> Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6a67823 - Browse repository at this point
Copy the full SHA 6a67823View commit details
Commits on Nov 20, 2014
-
Configuration menu - View commit details
-
Copy full SHA for 4dc8b26 - Browse repository at this point
Copy the full SHA 4dc8b26View commit details
Commits on Nov 21, 2014
-
path: allow calling platform specific methods
Add path.posix and path.win32 which have the specific methods like resolve and normalize so you can specifically normalize or resolve based on the target platform. PR-URL: #5661 Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6a90a06 - Browse repository at this point
Copy the full SHA 6a90a06View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d17193 - Browse repository at this point
Copy the full SHA 2d17193View commit details
Commits on Nov 26, 2014
-
PR-URL: #8762 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
5Configuration menu - View commit details
-
Copy full SHA for 9d9ed61 - Browse repository at this point
Copy the full SHA 9d9ed61View commit details -
path: refactor normalizeArray()
The normalizeArray() function now avoids using the slow Array#splice() method to improve performance and now also filters out empty path parts. Code that pre-filtered empty parts has been removed. PR-URL: #8724 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e0a0e91 - Browse repository at this point
Copy the full SHA e0a0e91View commit details -
smalloc: don't allow to dispose typed arrays
PR-URL: #8743 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for bf3e0f4 - Browse repository at this point
Copy the full SHA bf3e0f4View commit details -
PR-URL: #8785 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 69904c8 - Browse repository at this point
Copy the full SHA 69904c8View commit details -
crypto: cast uv_thread_t to unsigned long
Should work in all platforms and it fixes this compilation problem on OSX: ../src/node_crypto.cc:154:3: error: no matching function for call to 'CRYPTO_THREADID_set_numeric' CRYPTO_THREADID_set_numeric(tid, uv_thread_self()); ^~~~~~~~~~~~~~~~~~~~~~~~~~~ ../deps/openssl/openssl/include/openssl/../../crypto/crypto.h:435:6: note: candidate function not viable: no known conversion from 'uv_thread_t' (aka '_opaque_pthread_t *') to 'unsigned long' for 2nd argument void CRYPTO_THREADID_set_numeric(CRYPTO_THREADID *id, unsigned long val); ^ 1 error generated. PR-URL: #8785 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0308ad2 - Browse repository at this point
Copy the full SHA 0308ad2View commit details
Commits on Nov 28, 2014
-
Revert "crypto: cast uv_thread_t to unsigned long"
This reverts commit 0308ad2.
Configuration menu - View commit details
-
Copy full SHA for cb8cadb - Browse repository at this point
Copy the full SHA cb8cadbView commit details -
crypto: store thread id as pointer-sized
In https://github.com/MSOpenTech/libuv/commit/59658a8de7cc05a58327a164fd2ed4b050f8b4f4 the return of uv_thread_self() was changed from unsigned long to uv_thread_t. uv_thread_t is a HANDLE (pointer-sized) on Windows, which means that on Win64 it cannot be stored with CRYPTO_THREADID_set_numeric without data loss. Furthermore, without this change there will be a build break on Windows when the libuv change is integrated into Node, because of the conversion from HANDLE to unsigned long. Other related commits: 5845a6b https://github.com/MSOpenTech/libuv/commit/919d8ec63ac53566ad1f090058ec15966bd0e960
Configuration menu - View commit details
-
Copy full SHA for 304c0b4 - Browse repository at this point
Copy the full SHA 304c0b4View commit details
Commits on Dec 1, 2014
-
modules: adding load linked modules feature
- introduced NM_F_LINKED flag to identify linked modules - setting node_is_initialized after calling V8::Initialize in order to make the right decision during initial module registration - introduced modlist_linked in order to track modules that were pre-registered in order to complete it once node is initialized - completing registration of linked module similarly to the way it's done inside DLOpen PR-URL: #8386 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c131c1f - Browse repository at this point
Copy the full SHA c131c1fView commit details
Commits on Dec 2, 2014
-
Configuration menu - View commit details
-
Copy full SHA for d312b6d - Browse repository at this point
Copy the full SHA d312b6dView commit details
Commits on Dec 3, 2014
-
Couple code style fixes to pass cpplint Fixes: 304c0b4 "crypto: store thread id as pointer-sized"
Configuration menu - View commit details
-
Copy full SHA for c4f6c22 - Browse repository at this point
Copy the full SHA c4f6c22View commit details -
url: change hostname regex to negate invalid chars
Regarding #8520 This changes hostname validation from a whitelist regex approach to a blacklist regex approach as described in https://url.spec.whatwg.org/#host-parsing. url.parse misinterpreted `https://good.com+.evil.org/` as `https://good.com/+.evil.org/`. If we use url.parse to check the validity of the hostname, the test passes, but in the browser the user is redirected to the evil.org website.
Configuration menu - View commit details
-
Copy full SHA for 6120472 - Browse repository at this point
Copy the full SHA 6120472View commit details -
doc: set logical umask in process.umask example
0644 seems to be the desired mode for new files (as it is a very weird umask), and to achieve that the correct umask would be 0022. PR-URL: #8039 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4815873 - Browse repository at this point
Copy the full SHA 4815873View commit details
Commits on Dec 4, 2014
-
It was my mistake to change an assert check. This changes it back to how the assert was originally done. Fixes: c131c1f "modules: adding load linked modules feature" Signed-off-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e67db01 - Browse repository at this point
Copy the full SHA e67db01View commit details -
test: runner support for flaky tests
Adding --flaky-tests option, to allow regarding flaky tests failures as non-fatal. Currently only observed by the TapProgressIndicator, which will add a # TODO directive to tests classified as flaky. According to the TAP specification, the test harness is supposed to treat failures that have a # TODO directive as non-fatal.
Configuration menu - View commit details
-
Copy full SHA for df3a2b2 - Browse repository at this point
Copy the full SHA df3a2b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0674cba - Browse repository at this point
Copy the full SHA 0674cbaView commit details
Commits on Dec 5, 2014
-
Async Listener was the name of the user-facing JS API, and is being completely removed. Instead low level hooks directly into the mechanism that AL used will be introduced in a future commit. PR-URL: #8110 Signed-off-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Fedor Indutny <fedor@indutny.com> Reviewed-by: Alexis Campailla <alexis@janeasystems.com> Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
Configuration menu - View commit details
-
Copy full SHA for b655955 - Browse repository at this point
Copy the full SHA b655955View commit details -
async-wrap: move MakeCallback to .cc
MakeCallback is too large a function to be inlined. Likewise, only having header files will not allow for any part of AsyncWrap to be exposed cleanly via NODE_MODULE_CONTEXT_AWARE_BUILTIN(). PR-URL: #8110 Signed-off-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Fedor Indutny <fedor@indutny.com> Reviewed-by: Alexis Campailla <alexis@janeasystems.com> Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
Configuration menu - View commit details
-
Copy full SHA for 2593c14 - Browse repository at this point
Copy the full SHA 2593c14View commit details -
node, async-wrap: remove MakeDomainCallback
C++ won't deoptimize like JS if specific conditional branches are sporadically met in the future. Combined with the amount of code duplication removal and simplified maintenance complexity, it makes more sense to merge MakeCallback and MakeDomainCallback. Additionally, type casting in V8 before verifying what that type is will cause V8 to abort in debug mode if that type isn't what was expected. Fix this by first checking the v8::Value before casting. PR-URL: #8110 Signed-off-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Fedor Indutny <fedor@indutny.com> Reviewed-by: Alexis Campailla <alexis@janeasystems.com> Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
Configuration menu - View commit details
-
Copy full SHA for 42df679 - Browse repository at this point
Copy the full SHA 42df679View commit details -
node: fix throws before timer module is loaded
An edge case could occur when the setImmediate() in _fatalException() would fire before the timers module had been loaded globally, causing Node to crash. PR-URL: #8110 Signed-off-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Fedor Indutny <fedor@indutny.com> Reviewed-by: Alexis Campailla <alexis@janeasystems.com> Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
Configuration menu - View commit details
-
Copy full SHA for b1e9d33 - Browse repository at this point
Copy the full SHA b1e9d33View commit details -
src: all wrap's now use actual FunctionTemplate
Instead of simply creating a new v8::Object to contain the connection information, instantiate a new instance of a FunctionTemplate. This will allow future improvements for debugging and performance probes. Additionally, the "provider" argument in the ReqWrap constructor is no longer optional. PR-URL: #8110 Signed-off-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Fedor Indutny <fedor@indutny.com> Reviewed-by: Alexis Campailla <alexis@janeasystems.com> Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
Configuration menu - View commit details
-
Copy full SHA for 5962dbe - Browse repository at this point
Copy the full SHA 5962dbeView commit details -
src: remove unnecessary template parameter
The template class information is received via the type of the first argument. So there is no need to use Wrap<T>(handle). PR-URL: #8110 Signed-off-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Fedor Indutny <fedor@indutny.com> Reviewed-by: Alexis Campailla <alexis@janeasystems.com> Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
Configuration menu - View commit details
-
Copy full SHA for add955e - Browse repository at this point
Copy the full SHA add955eView commit details -
async-wrap: expose async-wrap as binding
Expose basic hooks for AsyncWrap via the async_wrap binding. Right now only the PROVIDER types are exposed. This is a preliminary step before more functionality is added. PR-URL: #8110 Signed-off-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Fedor Indutny <fedor@indutny.com> Reviewed-by: Alexis Campailla <alexis@janeasystems.com> Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
Configuration menu - View commit details
-
Copy full SHA for 1293f0a - Browse repository at this point
Copy the full SHA 1293f0aView commit details -
async-wrap: explicitly pass parent
When instantiating a new AsyncWrap allow the parent AsyncWrap to be passed. This is useful for cases like TCP incoming connections, so the connection can be tied to the server receiving the connection. Because the current architecture instantiates the *Wrap inside a v8::FunctionCallback, the parent pointer is currently wrapped inside a new v8::External every time and passed as an argument. This adds ~80ns to instantiation time. A future optimization would be to add the v8::External as the data field when creating the v8::FunctionTemplate, change the pointer just before making the call then NULL'ing it out afterwards. This adds enough code complexity that it will not be attempted until the current approach demonstrates it is a bottle neck. PR-URL: #8110 Signed-off-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Fedor Indutny <fedor@indutny.com> Reviewed-by: Alexis Campailla <alexis@janeasystems.com> Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
Configuration menu - View commit details
-
Copy full SHA for 419f18d - Browse repository at this point
Copy the full SHA 419f18dView commit details -
Call a user-defined callback at specific points in the lifetime of an asynchronous event. Which are on instantiation, just before/after the callback has been run. **If any of these callbacks throws an exception, there is no forgiveness or recovery. A message will be displayed and a core file dumped.** Currently these only tie into AsyncWrap, meaning no call to a hook callback will be made for timers or process.nextTick() events. Though those will be added in a future commit. Here are a few notes on how to make the hooks work: - The "this" of all event hook callbacks is the request object. - The zero field (kCallInitHook) of the flags object passed to setupHooks() must be set != 0 before the init callback will be called. - kCallInitHook only affects the calling of the init callback. If the request object has been run through the create callback it will always run the before/after callbacks. Regardless of kCallInitHook. - In the init callback the property "_asyncQueue" must be attached to the request object. e.g. function initHook() { this._asyncQueue = {}; } - DO NOT inspect the properties of the object in the init callback. Since the object is in the middle of being instantiated there are some cases when a getter is not complete, and doing so will cause Node to crash. PR-URL: #8110 Signed-off-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Fedor Indutny <fedor@indutny.com> Reviewed-by: Alexis Campailla <alexis@janeasystems.com> Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
Configuration menu - View commit details
-
Copy full SHA for 709fc16 - Browse repository at this point
Copy the full SHA 709fc16View commit details -
uv: float patch to revert tty breakage
Float libuv/libuv@484a3a9 to fix incorrect indentation in REPL.
Configuration menu - View commit details
-
Copy full SHA for fe6d5be - Browse repository at this point
Copy the full SHA fe6d5beView commit details -
doc: mention callback for http res/req write & end
Add documentation for the callback parameter of http.ClientRequest's and http.ServerResponse's write and end methods.
7Configuration menu - View commit details
-
Copy full SHA for 9653c4b - Browse repository at this point
Copy the full SHA 9653c4bView commit details -
doc: fix grammar and wording in tls and timers
In `tls.markdown`, there was a misuse of 'a' which has been replaced with 'an'. In `timers.markdown`... line 31: misuse of 'a', replaced with 'an' line 59: unclear wording, haywire 'a', added new comma
Configuration menu - View commit details
-
Copy full SHA for 70195ac - Browse repository at this point
Copy the full SHA 70195acView commit details
Commits on Dec 9, 2014
-
build: do not generate support for libuv's probes
Dtrace probes were removed from libuv recently, but their usage by node was not completely removed, causing build breaks on SmartOS. Even though the build is working on other platforms, these probes are not fired by libuv anymore, so there's no point in using them on these platforms too. Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Julien Gilli committedDec 9, 2014 Configuration menu - View commit details
-
Copy full SHA for 4dc660e - Browse repository at this point
Copy the full SHA 4dc660eView commit details
Commits on Dec 10, 2014
-
PR-URL: #8847 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 20a7088 - Browse repository at this point
Copy the full SHA 20a7088View commit details -
test: mark more tests as flaky
Marking these two tests as flaky, since they have been failing intermittenly in recent builds: test-debug-signal-cluster test-cluster-basic
Configuration menu - View commit details
-
Copy full SHA for 8708c7a - Browse repository at this point
Copy the full SHA 8708c7aView commit details
Commits on Dec 11, 2014
-
lib,src: fix spawnSync ignoring its 'env' option
PR-URL: #8546 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 946cec7 - Browse repository at this point
Copy the full SHA 946cec7View commit details -
test: add test for spawnSync() env option
PR-URL: #8845 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4bba870 - Browse repository at this point
Copy the full SHA 4bba870View commit details
Commits on Dec 16, 2014
-
Configuration menu - View commit details
-
Copy full SHA for 5b9e5bd - Browse repository at this point
Copy the full SHA 5b9e5bdView commit details -
zlib: support concatenated gzip files
Reviewed-By: Fedor Indutny <fedor@indutny.com> PR-URL: #6442
Configuration menu - View commit details
-
Copy full SHA for 6f6a979 - Browse repository at this point
Copy the full SHA 6f6a979View commit details
Commits on Dec 17, 2014
-
Configuration menu - View commit details
-
Copy full SHA for e93ff4f - Browse repository at this point
Copy the full SHA e93ff4fView commit details -
Fix a Windows-only build error that was introduced in commit 1183ba4 ("zlib: support concatenated gzip files"). Rename the NO_ERROR and FAILED enumerations, they conflict with macros of the same name in <winerror.h>. PR-URL: #8893 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-by: Timothy J Fontaine <tjfontaine@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 93533e9 - Browse repository at this point
Copy the full SHA 93533e9View commit details
Commits on Dec 18, 2014
-
stream: switch _writableState.buffer to queue
In cases where many small writes are made to a stream lacking _writev, the array data structure backing the WriteReq buffer would greatly increase GC pressure. Specifically, in the fs.WriteStream case, the clearBuffer routine would only clear a single WriteReq from the buffer before exiting, but would cause the entire backing array to be GC'd. Switching to [].shift lessened pressure, but still the bulk of the time was spent in memcpy. This replaces that structure with a linked list-backed queue so that adding and removing from the queue is O(1). In the _writev case, collecting the buffer requires an O(N) loop over the buffer, but that was already being performed to collect callbacks, so slowdown should be neglible. PR-URL: #8826 Reviewed-by: Timothy J Fontaine <tjfontaine@gmail.com> Reviewed-by: Trevor Norris <trev.norris@gmail.com>
1Configuration menu - View commit details
-
Copy full SHA for 9158666 - Browse repository at this point
Copy the full SHA 9158666View commit details
Commits on Dec 19, 2014
-
doc: add details for http res/req end callback
Add documentation for the callback parameter of http.ClientRequest's and http.ServerResponse's end methods. Signed-off-by: Julien Gilli <julien.gilli@joyent.com>
Configuration menu - View commit details
-
Copy full SHA for 890baa0 - Browse repository at this point
Copy the full SHA 890baa0View commit details
Commits on Dec 30, 2014
-
The url.parse() function now checks whether an escapable character is in the URL before trying to escape it. PR-URL: #8638 [trev.norris@gmail.com: Switch to use continue instead of if] Signed-off-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6a03fce - Browse repository at this point
Copy the full SHA 6a03fceView commit details
Commits on Jan 3, 2015
-
build: i18n: add icu config options
Make "--with-intl=none" the default and add "intl-none" option to vcbuild.bat. If icu data is missing print a warning unless either --download=all or --download=icu is set. If set then automatically download, verify (MD5) and unpack the ICU data if not already available. There's a "list" of URLs being used, but right now only the first is picked up. The logic works something like this: * If there is no directory deps/icu, * If no zip file (currently icu4c-54_1-src.zip), * Download zip file (icu-project.org -> sf.net) * Verify the MD5 sum of the zipfile * If bad, print error and exit * Unpack the zipfile into deps/icu * If deps/icu now exists, use it, else fail with help text Add the configuration option "--with-icu-source=..." Usage: * --with-icu-source=/path/to/my/other/icu * --with-icu-source=/path/to/icu54.zip * --with-icu-source=/path/to/icu54.tgz * --with-icu-source=http://example.com/icu54.tar.bz2 Add the configuration option "--with-icu-locals=...". Allows choosing which locales are used in the "small-icu" case. Example: configure --with-intl=small-icu --with-icu-locales=tlh,grc,nl (Also note that as of this writing, neither Klingon nor Ancient Greek are in upstream CLDR data. Serving suggestion only.) Don't use hard coded ../../out paths on windows. This was suggested by @misterdjules as it causes test failures. With this fix, "out" is no longer created on windows and the following can run properly: python tools/test.py simple Reduce space by about 1MB with ICU 54 (over without this patch). Also trims a few other source files, but only conditional on the exact ICU version used. This is to future-proof - a file that is unneeded now may be needed in future ICUs. Also: * Update distclean to remove icu related files * Refactor some code into tools/configure.d/nodedownload.py * Update docs * Add test PR-URL: #8719 Fixes: #7676 (comment) [trev.norris@gmail.com small change to test's whitespace and logic] Signed-off-by: Trevor Norris <trev.norris@gmail.com>
2Configuration menu - View commit details
-
Copy full SHA for a308395 - Browse repository at this point
Copy the full SHA a308395View commit details -
PR-URL: #8964 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8cfbeed - Browse repository at this point
Copy the full SHA 8cfbeedView commit details
Commits on Jan 4, 2015
-
net: make connect() input validation synchronous
Socket.prototype.connect() sometimes throws on bad inputs after an asynchronous operation. This commit makes the input validation synchronous. This commit also removes some hard coded IP addresses. PR-URL: #8180 Fixes: #8140 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b636ba8 - Browse repository at this point
Copy the full SHA b636ba8View commit details
Commits on Jan 5, 2015
-
smalloc: fix bad assert for zero length data
If the data length passed to smalloc.alloc() the array_length will be zero, causing an overflow check to fail. This prevents that from happening. Signed-off-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 372a2f5 - Browse repository at this point
Copy the full SHA 372a2f5View commit details
Commits on Jan 7, 2015
-
Configuration menu - View commit details
-
Copy full SHA for c8ef97e - Browse repository at this point
Copy the full SHA c8ef97eView commit details
Commits on Jan 8, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 1fad373 - Browse repository at this point
Copy the full SHA 1fad373View commit details
Commits on Jan 12, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 4ef09c6 - Browse repository at this point
Copy the full SHA 4ef09c6View commit details -
cluster: tests multiple open of ports in workers
Note that test/simple/test-cluster-dgram-4.js is a simplified case, since dgram.send() for clients does an implict .bind(0), so it could also be written as: A = dgram.createSocket('udp4') A.send(...) A.close(); ... time passes... B = dgram.createSocket('udp4') B.send(...) B.close(); Above was the original form, dscape/lynx kills the cluster master when run in a worker. IMO, dgram-4 is the most serious of this, using multiple dgram client sockets is currently impossible with cluster. Also note test/simple/test-cluster-net-listen-2.js, the TCP equivalent of dgram-4, passes, because TCP close causes the cluster master to be notified, UDP close does not. Also, note that I use the ephemeral "flag" port `0` in the tests, the same failure is seen with any port.
Configuration menu - View commit details
-
Copy full SHA for bc34188 - Browse repository at this point
Copy the full SHA bc34188View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a6e79f - Browse repository at this point
Copy the full SHA 8a6e79fView commit details -
fixup! wait for close event on A before opening B
In case that would help the tests pass... but it does not.
Configuration menu - View commit details
-
Copy full SHA for 1e1aa91 - Browse repository at this point
Copy the full SHA 1e1aa91View commit details