Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

What is a "web server" object? #6054

Closed
wants to merge 1 commit into from
Closed

What is a "web server" object? #6054

wants to merge 1 commit into from

Conversation

msafi
Copy link

@msafi msafi commented Aug 14, 2013

Saying that http.createServer returns a "web server" object isn't really clear. A newbie, like me, wouldn't know where to look to study this "web server" object.

Saying that http.createServer returns a "web server" object isn't really clear. A newbie, like me, wouldn't know where to look to study this "web server" object.
@Nodejs-Jenkins
Copy link

Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion.

Commit msafi/node@6fa4f2ddf75c2b82582c897c16ec62b3dda9d6b0 has the following error(s):

  • Commit message must indicate the subsystem this commit changes
  • Commit message line too long: 2

The following commiters were not found in the CLA:

  • MK Safi

You can fix all these things without opening another issue.

Please see CONTRIBUTING.md for more information

@isaacs
Copy link

isaacs commented Aug 19, 2013

@msafi This looks fine to me, and I can update the commit message easily enough, but please sign the CLA before I can accept this: http://nodejs.org/cla.html You can do it online, and it takes 5 minutes.

Thanks!

@msafi
Copy link
Author

msafi commented Aug 19, 2013

@isaacs Cool! Submitted. :)

chrisdickinson pushed a commit that referenced this pull request Nov 19, 2014
PR-URL: #6054
Reviewed-by: Isaac Z. Schlueter <i@izs.me>
Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
@chrisdickinson
Copy link

Merged in 6a67823. Thanks for your patience!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants