This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
path: refactor normalizeArray() - improve performance #8724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwoltman
force-pushed
the
path-normalize
branch
from
9f5b260
to
7d69047
Compare
|
:) didn't notice that @trevnorris reply #8342 |
|
Code looks good, but haven't tested it yet. /cc @indutny @tjfontaine Ping back in a week if no response. |
The normalizeArray() function now avoids using the slow Array#splice() method to improve performance and now also filters out empty path parts. Code that pre-filtered empty parts has been removed.
nwoltman
force-pushed
the
path-normalize
branch
from
7d69047
to
367210b
Compare
|
week passed. Ping @trevnorris :) |
|
/cc @indutny @tjfontaine |
trevnorris
pushed a commit
that referenced
this pull request
Nov 26, 2014
The normalizeArray() function now avoids using the slow Array#splice() method to improve performance and now also filters out empty path parts. Code that pre-filtered empty parts has been removed. PR-URL: #8724 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
|
Thanks. Landed in e0a0e91. |
piscisaureus
pushed a commit
to piscisaureus/node2
that referenced
this pull request
Dec 9, 2014
The normalizeArray() function now avoids using the slow Array#splice() method to improve performance and now also filters out empty path parts. Code that pre-filtered empty parts has been removed. PR-URL: nodejs/node-v0.x-archive#8724 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
piscisaureus
pushed a commit
to nodejs/node
that referenced
this pull request
Dec 9, 2014
The normalizeArray() function now avoids using the slow Array#splice() method to improve performance and now also filters out empty path parts. Code that pre-filtered empty parts has been removed. PR-URL: nodejs/node-v0.x-archive#8724 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves performance of
path.normalize()andpath.resolve()(up to 3x faster in some cases).#8342 didn't look like anyone was paying attention to it anymore so I came up with a solution that addresses @trevnorris's issue with it.
I used @dead-horse's same test code to obtain the following benchmarks:
Addressing @trevnorris's issue with using
Array#reverse()didn't affect the first 4 tests much but removing it seems to have improved performance on the last 2 tests.