Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

sync vs async error message for fs.symlink #5381

Closed
jkroso opened this issue Apr 29, 2013 · 1 comment
Closed

sync vs async error message for fs.symlink #5381

jkroso opened this issue Apr 29, 2013 · 1 comment

Comments

@jkroso
Copy link

jkroso commented Apr 29, 2013

the sync version gives me ENOENT, no such file or directory {dstpath}
the async version gives me ENOENT, symlink {srcpath}

since the problem can only ever be with the dstpath when with an ENOENT I guess the sync message is the better one.
@vkurchatkin vkurchatkin mentioned this issue Nov 1, 2014
Closed
chrisdickinson pushed a commit that referenced this issue Nov 16, 2014
@vkurchatkin @chrisdickinson
fs: fix symlink error message
f6556b6 
the arguments were swapped, so fs.symlink{Sync,} would
report that the wrong file EEXIST'd in error.

Fixes: #8651
Fixes: #4314
Fixes: #5381
PR-URL: #8657
Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
@chrisdickinson
Copy link

This should be fixed for v0.12 by f6556b6. Thanks for the report!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrisdickinson @jkroso