src: zlib: revert concatenated-stream changes

[chrisdickinson]

This addresses the immediate problem seen in #8962. I may try to reintroduce this feature with a flagged option if desired.

[misterdjules]

LGTM. A few comments:

• I'm not sure if using src: zlib: in the first line of the commit message breaks the contributing rules. Maybe reword the first line and just mention the sha1 of the reverted commits in the commit message?
• Can we mention issue number zlib auto-reset on trailing data causes repeated flushing #8962 in the commit message?
• How was this tested? Could we ask some people following Node / io.js v0.12 HEAD breaks npm install npm/npm#7043 to test it?

Thanks!

[chrisdickinson]

I'm not sure if using src: zlib: in the first line of the commit message breaks the contributing rules. Maybe reword the first line and just mention the sha1 of the reverted commits in the commit message?

Looks like we do <subsystem>, <subsystem>: <message> when multiple subsystems are affected. Willfix!

Can we mention issue number #8962 in the commit message?

Yep! That will be part of the commit metadata (the Fixes: <url> part).

How was this tested? Could we ask some people following npm/npm#7043 to test it?

This was tested with both the reduced test case as well as the steps listed on the original issue. But, the more eyes, the better! /cc @othiym23.

[othiym23]

I can confirm that this fixes the crashes that I was seeing when this issue was pointed out to me by @wraithan. @wraithan, does this fix your issues with node-newrelic as well?

[wraithan]

I'll test this in a couple hours when I get to work, just saw this email to test this branch

[wraithan]

@chrisdickinson @othiym23 This fixes the problem for us. Thanks a ton to both of you for looking into this and fixing it up for me!

[misterdjules]

@othiym23 @wraithan @chrisdickinson Thank you very much! Now LGTM without any comment :)

[chrisdickinson]

Merged in c8ef97e. Thanks all!