Calling write() after calling end() not raising an error

[luiscvega]

According to docs, the code below should raise an error.

"Calling write() after calling end() will raise an error." (http://nodejs.org/api/stream.html#stream_writable_end_chunk_encoding_callback)

var http = require("http");

http.createServer(function (req, res) {
  res.write("This should write.");
  res.end();
  res.write("This should raise an error but it does not.");
}).listen(3000);

[indutny]

Heh, thanks for catching this. It is actually a http module weirdness. I wish we would fix it after initial v0.12 release.

[luiscvega]

Cool. I think ending an already ended response should also error, but doesn't right now. And I think all this is the same for the request.

Glad to be of help. :)

[misterdjules]

@luiscvega @indutny I just created a PR that fixes this issue.

[mscdex]

Should we really emit 'error' if they've already supplied a callback and we're passing the error to that callback?

[misterdjules]

@mscdex My implementation was modeled after _stream_writable.js' writeAfterEnd, but now that you ask the question it also feels like it's a bit too much to ask for. @indutny @tjfontaine What do you think?

[indutny]

@mscdex I think they follow streams2 approach, whatever it is right now.

[trevnorris]

Fixed by 64d6de9.