This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
http: write() after end() emits an error. #8422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling write() after end() has been called on an OutgoingMessage, an error is emitted and the write's callback is called with an instance of Error. Fix nodejs#7477.
| var self = this; | ||
|
|
||
| if (this.finished) { | ||
| var err = new Error('write after end'); |
There was a problem hiding this comment.
Any reason not to have this inside the nextTick()?
There was a problem hiding this comment.
Some properties of the Error instance, like Error.prototype.stack, depends on where the Error instance is created.
Even if this behavior might depend on the implementation, to me it makes sense since the error happens within the write function, not in nextTick's callback.
There was a problem hiding this comment.
Some interesting pointers on this matter: https://mail.mozilla.org/pipermail/es-discuss/2014-May/037226.html. It seems it may be standardized someday.
|
I hate how |
|
Landed in 64d6de9 |
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling write() after end() has been called on an OutgoingMessage,
an error is emitted and the write's callback is called with an instance
of Error.
Fix #7477.