This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
process: pid can be a string in process.kill() #8531
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -641,8 +641,8 @@ | |||
| process.kill = function(pid, sig) { | |||
| var err; | |||
|
|
|||
| if (typeof pid !== 'number' || !isFinite(pid)) { | |||
| throw new TypeError('pid must be a number'); | |||
| if (pid != (pid | 0)) { | |||
There was a problem hiding this comment.
Prefer pid >>> 0. That is the only way to do uint coercion, and since you can't have a negative pid makes sense to do it this way. :)
There was a problem hiding this comment.
You can send signals to negative pids (see man 2 kill), and negative numbers are tested for in the test, and supported by node/libuv.
There was a problem hiding this comment.
ah, whoops. I'm thinking of fd's. sorry. :)
|
@sam-github one more small nit. Thanks |
|
@trevnorris ping |
|
Thanks. Merged in 743a009. |
trevnorris
pushed a commit
that referenced
this pull request
Nov 17, 2014
Not allowing string was a change from v0.10 behaviour, commented on in #7991. Allow them again, but still check that argument is numberish. Also, simplify the fragile and non-portable test code introduced in 832ec1c that required fixups 2a41535, and ef3c4ed. PR-URL: #8531 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
|
Thanks, @trevnorris |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not allowing string was a change from v0.10 behaviour, commented on in
#7991. Allow them again, but still check that argument is
numberish. Also, simplify the fragile and non-portable test code
introduced in 832ec1c that required fixups 2a41535, and
ef3c4ed.
Sorry about the test awfulness I introduced, @misterdjules @tjfontaine.