Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checkstyle line length suppressions #34884

Closed
33 tasks done
dakrone opened this issue Oct 25, 2018 · 3 comments
Closed
33 tasks done

Remove checkstyle line length suppressions #34884

dakrone opened this issue Oct 25, 2018 · 3 comments

Comments

@dakrone
Copy link
Member

dakrone commented Oct 25, 2018

We've carried these suppressions around for a long time, so this is a meta issue to track removal of the suppressions

They are roughly separated into the following packages (when you assign one, please do the work for both master and 6.x branches):

jakelandis added a commit to jakelandis/elasticsearch that referenced this issue Oct 25, 2018
dakrone added a commit to dakrone/elasticsearch that referenced this issue Oct 25, 2018
This removes the checkstyle suppressions for things in the `common` package.

Relates to elastic#34884
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this issue Oct 25, 2018
* Fix linelength suppressions in index.fielddata
  * Some lines that were too long were dead code => Removed them and all code that became dead because of it
* Relates elastic#34884
@colings86 colings86 added the :Core/Infra/Core Core issues without another label label Oct 26, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@colings86
Copy link
Contributor

Please remember to add relevant labels to all issues created. At the very least this should include an area label since without and area label issues may fall through the cracks and be missed by teams

original-brownbear added a commit that referenced this issue Oct 26, 2018
* Fix linelength suppressions in index.fielddata
  * Some lines that were too long were dead code => Removed them and all code that became dead because of it
* Relates #34884
imotov added a commit to imotov/elasticsearch that referenced this issue Oct 26, 2018
Removes the checkstyle suppressions for files in
org.elasticsearch.bootstrap/client/discovery/gateway packages.

Relates to elastic#34884
dakrone added a commit that referenced this issue Oct 26, 2018
This removes the checkstyle suppressions for things in the `common` package.

Relates to #34884
dakrone added a commit that referenced this issue Oct 26, 2018
This removes the checkstyle suppressions for things in the `common` package.

Relates to #34884
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this issue Oct 26, 2018
* Fix linelength suppressions in index.fielddata
  * Some lines that were too long were dead code => Removed them and all code that became dead because of it
* Relates elastic#34884
imotov added a commit that referenced this issue Oct 26, 2018
Removes the checkstyle suppressions for files in
org.elasticsearch.bootstrap/client/discovery/gateway packages.

Relates to #34884
imotov added a commit that referenced this issue Oct 26, 2018
Removes the checkstyle suppressions for files in
org.elasticsearch.bootstrap/client/discovery/gateway packages.

Relates to #34884
rjernst added a commit to rjernst/elasticsearch that referenced this issue Oct 26, 2018
pgomulka added a commit to pgomulka/elasticsearch that referenced this issue Jan 8, 2019
Remove the line length suppression for this package and fix offending
lines in both main and test

relates elastic#34884
rjernst added a commit that referenced this issue Jan 8, 2019
This commit removes several more line length violations from checkstyle
suppression.

relates #34884
rjernst added a commit that referenced this issue Jan 8, 2019
This commit removes several more line length violations from checkstyle
suppression.

relates #34884
pgomulka added a commit that referenced this issue Jan 9, 2019
Remove the line length suppression for this package and fix offending
lines in both main and test

relates #34884
pgomulka added a commit to pgomulka/elasticsearch that referenced this issue Jan 9, 2019
Remove the line length suppression for this package and fix offending
lines

relates: elastic#34884
pgomulka added a commit that referenced this issue Jan 10, 2019
Remove the line length suppression for this package and fix offending
lines

relates: #34884
pgomulka added a commit to pgomulka/elasticsearch that referenced this issue Jan 10, 2019
Remove the line length suppression for this package and fix offending
lines
backport elastic#37253

relates: elastic#34884
pgomulka added a commit that referenced this issue Jan 11, 2019
Remove the line length suppression for this package and fix offending
lines
backport #37253

relates: #34884
dliappis added a commit to dliappis/elasticsearch that referenced this issue Jan 15, 2019
@danielmitterdorfer
Copy link
Member

Closing as all related PRs have been merged now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants