Fix line length for monitor and remove suppressions #37456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-core-infra |
33 tasks
danielmitterdorfer
approved these changes
Jan 15, 2019
| @@ -267,7 +268,8 @@ private String innerDetect() throws Exception { | |||
| sb.append(String.format(Locale.ROOT, " %s%n", show[l])); | |||
| } | |||
| } else { | |||
| sb.append(String.format(Locale.ROOT, " %d/%d snapshots sharing following %d elements%n", count, threadElementsSnapshotCount, maxSim)); | |||
| sb.append(String.format(Locale.ROOT, | |||
| " %d/%d snapshots sharing following %d elements%n", count, threadElementsSnapshotCount, maxSim)); | |||
There was a problem hiding this comment.
I think it would be more consistent keeping the message string on the line above and only moving the parameters to this line.
There was a problem hiding this comment.
Thanks addressed in 12d1de2
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jan 15, 2019
* elastic/master: Docs be explicit on how to turn off deprecated auditing (elastic#37316) Fix line length for monitor and remove suppressions (elastic#37456) Fix IndexShardTestCase.recoverReplica(IndexShard, IndexShard, boolean) (elastic#37414) Update the Flush API documentation (elastic#33551) [TEST] Muted testDifferentRolesMaintainPathOnRestart Remove dead code from ShardSearchStats (elastic#37421) Simplify testSendSnapshotSendsOps (elastic#37445) SQL: Fix issue with field names containing "." (elastic#37364) Restore lost @Inject annotation (elastic#37452)
dliappis
added a commit
that referenced
this pull request
Jan 15, 2019
|
Backported in 6.x -> 1307fb1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates #34884