Fix line length in org.elasticsearch.routing #37253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgomulka
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra |
pgomulka
force-pushed
the
fix/routing-line-length
branch
from
8dd770f
to
260cead
Compare
33 tasks
Remove the line length suppression for this package and fix offending lines relates: elastic#34884
pgomulka
force-pushed
the
fix/routing-line-length
branch
from
260cead
to
fafc1ba
Compare
|
run default distro tests |
ebadyano
reviewed
Jan 10, 2019
| .addAliasAction(AliasActions.add().index("test").alias("alias0").routing("0")) | ||
| .addAliasAction(AliasActions.add().index("test").alias("alias1").routing("1")) | ||
| .addAliasAction(AliasActions.add().index("test").alias("alias01").searchRouting("0,1"))); | ||
| .addAliasAction(AliasActions.add().index("test").alias("alias")) |
There was a problem hiding this comment.
The original indentation seems what is used throughout the rest of code. Does it make sense to use the original style vs indenting under the period of the line above?
There was a problem hiding this comment.
I would prefer to change indentation for this file with fluent builder wrapping on dots.
Some of these chains are breaking the line length limit, I have reformatted them with intellij Allign when multiline. And then to keep this consistent across this file I formatted other fluent builders as well.
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Jan 10, 2019
Remove the line length suppression for this package and fix offending lines backport elastic#37253 relates: elastic#34884
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the line length suppression for this package and fix offending
lines
relates: #34884