Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Style] Fix line length violations for threadpool, indexing, and script packages #37205

Merged
merged 10 commits into from
Jan 9, 2019
Merged

[Style] Fix line length violations for threadpool, indexing, and script packages #37205

merged 10 commits into from
Jan 9, 2019

Conversation

jdconrad
Copy link
Contributor

@jdconrad jdconrad commented Jan 7, 2019

This fixes line length violations in several files across the threadpool, indexing, and script packages.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@dakrone dakrone mentioned this pull request Jan 7, 2019
Closed
33 tasks
rjernst
rjernst approved these changes Jan 7, 2019
View reviewed changes
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdconrad jdconrad removed the request for review from danielmitterdorfer January 7, 2019 21:36
@jdconrad
Copy link
Contributor Author

jdconrad commented Jan 7, 2019

@rjernst Thanks for the review! Will commit as soon as CI completes.

@jdconrad
Copy link
Contributor Author

jdconrad commented Jan 8, 2019

@elasticmachine test this please

@jdconrad
Copy link
Contributor Author

jdconrad commented Jan 8, 2019

@elasticmachine test this please

@jdconrad
Copy link
Contributor Author

jdconrad commented Jan 8, 2019

@elasticmachine run gradle build tests 2

@jdconrad
Copy link
Contributor Author

jdconrad commented Jan 8, 2019

@elasticmachine run gradle build tests 1

@jdconrad
Copy link
Contributor Author

jdconrad commented Jan 8, 2019

@elasticmachine run gradle build tests 2

@jdconrad
Copy link
Contributor Author

jdconrad commented Jan 8, 2019

@elasticmachine test this please

@jdconrad
Copy link
Contributor Author

jdconrad commented Jan 8, 2019

@elasticmachine run gradle build tests 1

1 similar comment
@jdconrad
Copy link
Contributor Author

jdconrad commented Jan 9, 2019

@elasticmachine run gradle build tests 1

@jdconrad
Copy link
Contributor Author

jdconrad commented Jan 9, 2019

@elasticmachine run gradle build tests 2

@jdconrad
Copy link
Contributor Author

jdconrad commented Jan 9, 2019

@elasticmachine run gradle build tests 1

1 similar comment
@jdconrad
Copy link
Contributor Author

jdconrad commented Jan 9, 2019

@elasticmachine run gradle build tests 1

@jdconrad
Copy link
Contributor Author

jdconrad commented Jan 9, 2019

@elasticmachine run gradle build tests 2

@jdconrad
Copy link
Contributor Author

jdconrad commented Jan 9, 2019

@elasticmachine run gradle build tests 1

@jdconrad
Copy link
Contributor Author

jdconrad commented Jan 9, 2019

@elasticmachine run gradle build tests 1

@jdconrad jdconrad merged commit 95eef77 into elastic:master Jan 9, 2019
jdconrad added a commit to jdconrad/elasticsearch that referenced this pull request Jan 9, 2019
@jdconrad
[Style] Fix line length violations for threadpool, indexing, and scri…
98bd190 
…pt packages (elastic#37205)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjernst rjernst rjernst approved these changes

Assignees
No one assigned
Labels
:Core/Infra/Core Core issues without another label >non-issue >refactoring v6.7.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jdconrad @elasticmachine @rjernst @colings86