Enforce 140 char line lengths for packages action.bulk/delete/explain/get/index #34885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelandis
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra |
33 tasks
|
tests now included. should be ready for review. |
nik9000
approved these changes
Oct 25, 2018
| @@ -46,7 +46,8 @@ | |||
| * @see org.elasticsearch.client.Client#delete(DeleteRequest) | |||
| * @see org.elasticsearch.client.Requests#deleteRequest(String) | |||
| */ | |||
| public class DeleteRequest extends ReplicatedWriteRequest<DeleteRequest> implements DocWriteRequest<DeleteRequest>, CompositeIndicesRequest { | |||
| public class DeleteRequest extends ReplicatedWriteRequest<DeleteRequest> implements DocWriteRequest<DeleteRequest>, | |||
| CompositeIndicesRequest { | |||
There was a problem hiding this comment.
Could you add the new line before implements instead of here? Could you also indent this one more time so it doesn't line up with the class body?
There was a problem hiding this comment.
thanks @nik9000, looks much better as suggested. (fixed)
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Oct 29, 2018
|
6.x backport: 679b0e1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #34884
No changes beyond adding newlines to satisfy the 140 char line length.