Remove remaining line length violations for o.e.action.admin.cluster #35156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This inserts newlines in order to reduce line lengths in the o.e.action.admin.cluster package to 140 characters or less. This also remves the checkstyle suppressions for affected files. Relates elastic#34884, elastic#34923
tomcallahan
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra |
33 tasks
nik9000
approved these changes
Nov 5, 2018
There was a problem hiding this comment.
I left a couple of small formatting things that I'd like but it looks great!
Thanks @tomcallahan. We're working these down!
| updater.updateSettings(build, Settings.builder().put(BalancedShardsAllocator.INDEX_BALANCE_FACTOR_SETTING.getKey(), "not a float").build(), | ||
| Settings.builder().put(BalancedShardsAllocator.INDEX_BALANCE_FACTOR_SETTING.getKey(), "not a float").put(BalancedShardsAllocator.SHARD_BALANCE_FACTOR_SETTING.getKey(), 1.0f).build(), logger); | ||
| updater.updateSettings(build, | ||
| Settings.builder().put(BalancedShardsAllocator.INDEX_BALANCE_FACTOR_SETTING.getKey(), "not a float").build(), |
There was a problem hiding this comment.
I might make this one mirror the one below it so any differences jump out visually.
There was a problem hiding this comment.
Not exactly sure what you mean here, @nik9000 , can you clarify?
There was a problem hiding this comment.
If you write it like:
updater.updateSettings(build,
Settings.builder()
.put(BalancedShardsAllocator.INDEX_BALANCE_FACTOR_SETTING.getKey(), "not a float")
.build(),
Settings.builder()
.put(BalancedShardsAllocator.INDEX_BALANCE_FACTOR_SETTING.getKey(), "not a float")
.put(BalancedShardsAllocator.SHARD_BALANCE_FACTOR_SETTING.getKey(), 1.0f)
.build(),
logger);
Then the differences between the original settings and the new settings pop out visually because the old and the new settings builders are formatted in the same way. It isn't important, but it is pleasant.
There was a problem hiding this comment.
makes sense, thanks!
| Settings.builder().put(BalancedShardsAllocator.INDEX_BALANCE_FACTOR_SETTING.getKey(), 1.6).put(BalancedShardsAllocator.SHARD_BALANCE_FACTOR_SETTING.getKey(), 1.0f).build(), logger); | ||
| ClusterState clusterState = | ||
| updater.updateSettings(build, Settings.builder().put(MetaData.SETTING_READ_ONLY_SETTING.getKey(), true).build(), | ||
| Settings.builder().put(BalancedShardsAllocator.INDEX_BALANCE_FACTOR_SETTING.getKey(), 1.6) |
There was a problem hiding this comment.
I like:
ClusterState clusterState = updater.updateSettings(build,
Settings.builder()...,
Settings.builder()...,
logger);
Or something like it. This one has a parameter lining up with the method and I get confused by stuff like that.
| Settings.builder().put(BalancedShardsAllocator.INDEX_BALANCE_FACTOR_SETTING.getKey(), 1.6).put(BalancedShardsAllocator.SHARD_BALANCE_FACTOR_SETTING.getKey(), 1.0f).build(), logger); | ||
| clusterState = | ||
| updater.updateSettings(build, Settings.builder().put(MetaData.SETTING_READ_ONLY_ALLOW_DELETE_SETTING.getKey(), true).build(), | ||
| Settings.builder().put(BalancedShardsAllocator.INDEX_BALANCE_FACTOR_SETTING.getKey(), 1.6) |
|
@elasticmachine test this please |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Nov 17, 2018
* master: (59 commits) SQL: Move internals from Joda to java.time (elastic#35649) Add HLRC docs for Get Lifecycle Policy (elastic#35612) Align RolloverStep's name with other step names (elastic#35655) Watcher: Use joda method to get local TZ (elastic#35608) Fix line length for org.elasticsearch.action.* files (elastic#35607) Remove use of AbstractComponent in server (elastic#35444) Deprecate types in count and msearch. (elastic#35421) Refactor an ambigious TermVectorsRequest constructor. (elastic#35614) [Scripting] Use Number as a return value for BucketAggregationScript (elastic#35653) Removes AbstractComponent from several classes (elastic#35566) [DOCS] Add beta warning to ILM pages. (elastic#35571) Deprecate types in validate query requests. (elastic#35575) Unmute BuildExamplePluginsIT Revert "AwaitsFix the RecoveryIT suite - see elastic#35597" Revert "[RCI] Check blocks while having index shard permit in TransportReplicationAction (elastic#35332)" Remove remaining line length violations for o.e.action.admin.cluster (elastic#35156) ML: Adjusing BWC version post backport to 6.6 (elastic#35605) [TEST] Replace fields in response with actual values Remove usages of CharSequence in Sets (elastic#35501) AwaitsFix the RecoveryIT suite - see elastic#35597 ...
|
Backported to 6.6 by #35668. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR inserts newlines in order to reduce line lengths in the
o.e.action.admin.cluster package to 140 characters or less. This
also removes the checkstyle suppressions for affected files.
@rjernst addressed much of these in #34923, but this rounds
out this package and removes all the suppressions.
The only edits in code files consist of newlines as well as some
adjustments to indentation for consistency.
Relates #34884, #34923