Remove more checkstyle suppressions #36735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes several more line length violations from checkstyle suppression. relates elastic#34884
rjernst
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra |
33 tasks
|
@elasticmachine test this please |
matriv
approved these changes
Dec 18, 2018
| table.addCell("pri.segments.fixed_bitset_memory", "default:false;text-align:right;desc:memory used by fixed bit sets for nested object field types and type filters for types referred in _parent fields"); | ||
| table.addCell("segments.fixed_bitset_memory", | ||
| "sibling:pri;alias:sfbm,fixedBitsetMemory;default:false;text-align:right;desc:memory used by fixed bit sets for" + | ||
| " nested object field types and type filters for types referred in _parent fields"); |
There was a problem hiding this comment.
I think this needs to be "unidented" by 4 spaces. Also just for the "beauty" of things you can move the leading whitespace char to the prev line.
| " nested object field types and type filters for types referred in _parent fields"); | ||
| table.addCell("pri.segments.fixed_bitset_memory", | ||
| "default:false;text-align:right;desc:memory used by fixed bit sets for nested object" + | ||
| " field types and type filters for types referred in _parent fields"); |
| "alias:svmm,segmentsVersionMapMemory;default:false;text-align:right;desc:memory used by version map"); | ||
| table.addCell("segments.fixed_bitset_memory", | ||
| "alias:sfbm,fixedBitsetMemory;default:false;text-align:right;desc:memory used by fixed bit sets for nested object" + | ||
| " field types and type filters for types referred in _parent fields"); |
| @@ -1509,7 +1517,8 @@ public void restore() throws IOException { | |||
| logger.trace("[{}] [{}] restoring from to an empty shard", shardId, snapshotId); | |||
| recoveryTargetMetadata = Store.MetadataSnapshot.EMPTY; | |||
| } catch (IOException e) { | |||
| logger.warn(() -> new ParameterizedMessage("{} Can't read metadata from store, will not reuse any local file while restoring", shardId), e); | |||
| logger.warn(() -> new ParameterizedMessage("{} Can't read metadata from store, will not reuse any local" + | |||
| " file while restoring", shardId), e); | |||
There was a problem hiding this comment.
same here for the leading whitespace char.
| } | ||
| } else { | ||
| throw new RepositoryVerificationException(metadata.name(), "a file written by master to the store [" + blobStore() + "] cannot be accessed on the node [" + localNode + "]. " | ||
| throw new RepositoryVerificationException(metadata.name(), "a file written by master to the store [" + blobStore() + | ||
| "] cannot be accessed on the node [" + localNode + "]. " | ||
| + "This might indicate that the store [" + blobStore() + "] is not shared between this node and the master node or " |
There was a problem hiding this comment.
maybe here and below you can move the + to the end of the prev line.
|
@elasticmachine run gradle build tests 1 |
rjernst
added a commit
that referenced
this pull request
Jan 8, 2019
This commit removes several more line length violations from checkstyle suppression. relates #34884
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes several more line length violations from checkstyle
suppression.
relates #34884