Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

Handle specially the key of Float32x4Array and Int32x4Array element storing for arm and x64 port #2

Merged
merged 1 commit into from
Mar 4, 2014
Merged

Handle specially the key of Float32x4Array and Int32x4Array element storing for arm and x64 port #2

merged 1 commit into from
Mar 4, 2014

Conversation

fenghaitao
Copy link
Contributor

Handle specially the key of Float32x4Array and Int32x4Array element storing for arm and x64 port, use temp register instead of kScratchRegister when calling AllocateSIMDHeapObject in x64 port.

This commit should be squashed with the previous commit.

huningxin
huningxin reviewed Mar 3, 2014
View reviewed changes
src/x64/lithium-x64.cc
@@ -2020,7 +2020,8 @@ LInstruction* LChunkBuilder::DoLoadKeyed(HLoadKeyed* instr) {
(instr->representation().IsTagged() &&
(IsSIMD128ElementsKind(instr->elements_kind()))));
LOperand* backing_store = UseRegister(instr->elements());
result = new(zone()) LLoadKeyed(backing_store, key);
result = new(zone()) LLoadKeyed(backing_store, key,
load_128bits_without_sse2 ? TempRegister() : NULL);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I missed something. Why do we need to handle "without sse2" case in x64 port?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this as currently we do not allocate registers for SIMD and also we do not emit movups yet. Those codes will be removed when register allocation is done and movups is emitted.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

understood. Thanks for your explanation.

@fenghaitao
Handle specially the key of Float32x4Array and Int32x4Array element
0955b73 
storing for ARM and x64 port, use temp register instead of kScratchRegister
when calling AllocateSIMDHeapObject in x64 port.

This commit should be squashed with the previous commit.
@huningxin
Copy link
Contributor

LGTM. Thanks for the fix.

fenghaitao added a commit that referenced this pull request Mar 4, 2014
@fenghaitao
Merge pull request #2 from fenghaitao/master
112f47f 
Handle specially the key of Float32x4Array and Int32x4Array element storing for arm and x64 port
@fenghaitao fenghaitao merged commit 112f47f into crosswalk-project:master Mar 4, 2014
@fenghaitao fenghaitao mentioned this pull request Mar 21, 2014
Closed
rakuco pushed a commit that referenced this pull request Jan 15, 2015
@jeisinger
Set the V8 version of the 4.1 branch to 4.1
5247096 
R=machenbach@chromium.org
LOG=n
BUG=none

Review URL: https://codereview.chromium.org/847503002

Cr-Commit-Position: refs/branch-heads/4.1@{#2}
Cr-Branched-From: 2e08d2a-refs/heads/candidates@{#25353}
rakuco pushed a commit that referenced this pull request Mar 12, 2015
@mi-ac
Create V8 4.2 branch for Chrome 42
2f588c2 
Cr-Commit-Position: refs/branch-heads/4.2@{#1}
Cr-Branched-From: 3dfd929-refs/heads/4.2.77@{#2}
Cr-Branched-From: e011092-refs/heads/master@{#26757}
rakuco pushed a commit that referenced this pull request Mar 12, 2015
@mi-ac
Disable handle zapping on 4.2 branch
f1dace6 
BUG=chromium:318206
LOG=n
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/946503005

Cr-Commit-Position: refs/branch-heads/4.2@{#2}
Cr-Branched-From: 3dfd929-refs/heads/4.2.77@{#2}
Cr-Branched-From: e011092-refs/heads/master@{#26757}
rakuco pushed a commit that referenced this pull request Mar 12, 2015
@mi-ac
Port public version macros.
286b12f 
This ports https://codereview.chromium.org/959713003/ to
the 4.2 branch.

BUG=v8:3075
LOG=n
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/953363002

Cr-Commit-Position: refs/branch-heads/4.2@{#3}
Cr-Branched-From: 3dfd929-refs/heads/4.2.77@{#2}
Cr-Branched-From: e011092-refs/heads/master@{#26757}
rakuco pushed a commit that referenced this pull request Mar 12, 2015
@mi-ac
Version 4.2.77.3 (cherry-pick)
a48b2e5 
Merged cd87f25
Merged 47913ba

X87: Stop using HeapType in IC and Crankshaft.

Add the dummy implementation for turbofan unsupported port.

TBR=chunyang.dai@intel.com,bmeurer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/979763002

Cr-Commit-Position: refs/branch-heads/4.2@{#4}
Cr-Branched-From: 3dfd929-refs/heads/4.2.77@{#2}
Cr-Branched-From: e011092-refs/heads/master@{#26757}
huningxin pushed a commit to huningxin/v8-crosswalk that referenced this pull request Mar 18, 2015
@lionsky
Merge pull request crosswalk-project#2 from cdai2/simd-m41-turbofan
b0c33e9 
add the int32x4 support.   add / and / mul / sub / or / xor / get x/y/z/...
darktears pushed a commit that referenced this pull request Mar 23, 2015
@mi-ac
Revert of [turbofan] Finally get rid of the generic algorithm. (patch…
c781000 
…set #2 id:20001 of https://codereview.chromium.org/944803002/)

Reason for revert:
Breaks dbg builds.

Original issue's description:
> [turbofan] Finally get rid of the generic algorithm.
>
> R=svenpanne@chromium.org
>
> Committed: https://crrev.com/5bbe693e4817011b6a496c638c9f09026fd3dac9
> Cr-Commit-Position: refs/heads/master@{#26760}

TBR=svenpanne@chromium.org,bmeurer@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/941963003

Cr-Commit-Position: refs/heads/master@{#26763}
darktears pushed a commit that referenced this pull request Mar 23, 2015
@mi-ac
Revert of Correctly propagate terminate exception in TryCall. (patchset
035b144 
#2 id:20001 of https://codereview.chromium.org/928193002/)

Reason for revert:
See crbug.com/460412 and crbug.com/460356. Reverting on master in order to roll from master again soon.

Original issue's description:
> Correctly propagate terminate exception in TryCall.
>
> BUG=v8:3892
> LOG=Y
>
> Committed: https://crrev.com/a49b55b78844557b65a98e7a77dd26078157ed7f
> Cr-Commit-Position: refs/heads/master@{#26685}

TBR=ishell@chromium.org,yangguo@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:3892

Review URL: https://codereview.chromium.org/946973004

Cr-Commit-Position: refs/heads/master@{#26792}
darktears pushed a commit that referenced this pull request Mar 23, 2015
@bmeurer
Revert of Rebase GDBJIT interface solely on JITCodeEvent (patchset #2 …
49b112e 
…id:20001 of https://codereview.chromium.org/957673004/)

Reason for revert:
Doesn't compile

Original issue's description:
> Rebase GDBJIT interface solely on JITCodeEvent
>
> R=mstarzinger@chromium.org
> BUG=
>
> Committed: https://chromium.googlesource.com/v8/v8/+/8989d828e86bc7edae5e25687bcb60c0e301dffb

TBR=mstarzinger@chromium.org,wingo@igalia.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/954833004

Cr-Commit-Position: refs/heads/master@{#26848}
darktears pushed a commit that referenced this pull request Mar 23, 2015
@mi-ac
Revert of rename UniquePersistent to Global (patchset #2 id:20001 of h…
8465f39 
…ttps://codereview.chromium.org/980173003/)

Reason for revert:
breaks arm compile

Original issue's description:
> rename UniquePersistent to Global
>
> BUG=
>
> Committed: https://crrev.com/3f5ae16c62b031ad572f750d81ffc71c5d6d1f9b
> Cr-Commit-Position: refs/heads/master@{#27011}

TBR=svenpanne@chromium.org,dcarney@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/983653002

Cr-Commit-Position: refs/heads/master@{#27012}
darktears pushed a commit that referenced this pull request Mar 25, 2015
@expatdanno
Version 4.3.47.1 (cherry-pick)
c0b3da1 
Merged c622cb6

Introduce explicit constant for per Context debug data set by embedder

BUG=chromium:466631
LOG=N
TBR=yangguo@chromium.org

Review URL: https://codereview.chromium.org/1022013003

Cr-Commit-Position: refs/heads/4.3.47@{#2}
Cr-Branched-From: bcf51d2-refs/heads/master@{#27252}
Bysmyyr pushed a commit to Bysmyyr/v8-crosswalk that referenced this pull request Apr 1, 2015
@dslomov
Version 4.2.77.4 (cherry-pick)
58825bb 
Merged 290ee37

Disallow subclassing Arrays.

BUG=v8:3930,chromium:463894
LOG=N
R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/1000633002

Cr-Commit-Position: refs/branch-heads/4.2@{crosswalk-project#5}
Cr-Branched-From: 3dfd929-refs/heads/4.2.77@{crosswalk-project#2}
Cr-Branched-From: e011092-refs/heads/master@{#26757}
Bysmyyr pushed a commit to Bysmyyr/v8-crosswalk that referenced this pull request Apr 1, 2015
@dslomov
Version 4.2.77.5 (cherry-pick)
2c4e3f8 
Merged 1604bd4

Implement subclassing Arrays.

BUG=v8:3930,chromium:463894
LOG=N
R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/997063003

Cr-Commit-Position: refs/branch-heads/4.2@{crosswalk-project#6}
Cr-Branched-From: 3dfd929-refs/heads/4.2.77@{crosswalk-project#2}
Cr-Branched-From: e011092-refs/heads/master@{#26757}
Bysmyyr pushed a commit to Bysmyyr/v8-crosswalk that referenced this pull request Apr 1, 2015
@hashseed
Version 4.2.77.6 (cherry-pick)
555f5bc 
Merged afb2706

Limit size of first page based on serialized data.

BUG=chromium:453111
LOG=N
TBR=hpayer@chromium.org

Review URL: https://codereview.chromium.org/998993002

Cr-Commit-Position: refs/branch-heads/4.2@{crosswalk-project#7}
Cr-Branched-From: 3dfd929-refs/heads/4.2.77@{crosswalk-project#2}
Cr-Branched-From: e011092-refs/heads/master@{#26757}
Bysmyyr pushed a commit to Bysmyyr/v8-crosswalk that referenced this pull request Apr 1, 2015
@jeisinger
Version 4.2.77.7 (cherry-pick)
49599cb 
Merged 68d5f91

Fix build on solaris platforms

BUG=3935
LOG=N
TBR=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/1018333002

Cr-Commit-Position: refs/branch-heads/4.2@{crosswalk-project#8}
Cr-Branched-From: 3dfd929-refs/heads/4.2.77@{crosswalk-project#2}
Cr-Branched-From: e011092-refs/heads/master@{#26757}
Bysmyyr pushed a commit to Bysmyyr/v8-crosswalk that referenced this pull request Apr 1, 2015
@isheludko
Version 4.2.77.8 (cherry-pick)
35b44e5 
Merged 0902b5f

Incorrect handling of HTransitionElementsKind in hydrogen check elimination phase fixed.

BUG=chromium:460917
LOG=N
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/1019033004

Cr-Commit-Position: refs/branch-heads/4.2@{crosswalk-project#9}
Cr-Branched-From: 3dfd929-refs/heads/4.2.77@{crosswalk-project#2}
Cr-Branched-From: e011092-refs/heads/master@{#26757}
Bysmyyr pushed a commit to Bysmyyr/v8-crosswalk that referenced this pull request Apr 1, 2015
@isheludko
Version 4.2.77.9 (cherry-pick)
b8c8da9 
Merged ddfca2b

Bugfix in hydrogen GVN.

BUG=chromium:467481
LOG=N
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/1020473006

Cr-Commit-Position: refs/branch-heads/4.2@{crosswalk-project#10}
Cr-Branched-From: 3dfd929-refs/heads/4.2.77@{crosswalk-project#2}
Cr-Branched-From: e011092-refs/heads/master@{#26757}
Bysmyyr pushed a commit to Bysmyyr/v8-crosswalk that referenced this pull request Apr 1, 2015
@hashseed
Version 4.2.77.10 (cherry-pick)
1236eaf 
Merged 567e45a

Promote code from code cache to compilation cache.

BUG=chromium:399580
LOG=N
TBR=vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1028483003

Cr-Commit-Position: refs/branch-heads/4.2@{crosswalk-project#11}
Cr-Branched-From: 3dfd929-refs/heads/4.2.77@{crosswalk-project#2}
Cr-Branched-From: e011092-refs/heads/master@{#26757}
Bysmyyr pushed a commit to Bysmyyr/v8-crosswalk that referenced this pull request Apr 1, 2015
@cdai2
Version 4.2.77.11 (cherry-pick)
fb672f6 
Merged 8b33fa6

X87: Disallow subclassing Arrays.

R=dslomov@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1033463002

Cr-Commit-Position: refs/branch-heads/4.2@{crosswalk-project#12}
Cr-Branched-From: 3dfd929-refs/heads/4.2.77@{crosswalk-project#2}
Cr-Branched-From: e011092-refs/heads/master@{#26757}
Bysmyyr pushed a commit to Bysmyyr/v8-crosswalk that referenced this pull request Apr 1, 2015
@cdai2
Version 4.2.77.12 (cherry-pick)
b0a290c 
Merged a3773e4

X87: Implement subclassing Arrays.

R=dslomov@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1019353006

Cr-Commit-Position: refs/branch-heads/4.2@{crosswalk-project#13}
Cr-Branched-From: 3dfd929-refs/heads/4.2.77@{crosswalk-project#2}
Cr-Branched-From: e011092-refs/heads/master@{#26757}
Bysmyyr pushed a commit to Bysmyyr/v8-crosswalk that referenced this pull request Apr 2, 2015
@verwaest
Version 4.2.77.13 (cherry-pick)
0d2d0e5 
Merged 0f57346

Ensure we don't overflow in BCE

BUG=chromium:469148
LOG=N
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/997153005

Cr-Commit-Position: refs/branch-heads/4.2@{crosswalk-project#14}
Cr-Branched-From: 3dfd929-refs/heads/4.2.77@{crosswalk-project#2}
Cr-Branched-From: e011092-refs/heads/master@{#26757}
darktears pushed a commit that referenced this pull request Apr 10, 2015
@mi-ac
Revert of Track how many pages trigger fallback strategies in GC (pat…
96cfadd 
…chset #2 id:20001 of https://codereview.chromium.org/1029323003/)

Reason for revert:
This seems to cause lots of crashes in layout tests debug:
../../third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp(67) : void blink::useCounterCallback(v8::Isolate *, v8::Isolate::UseCounte

http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/2332

Original issue's description:
> Track how many pages trigger fallback strategies in GC
>
> R=hpayer@chromium.org
> BUG=
>
> Committed: https://crrev.com/bb880058f6499510cff12d98dc7d524d35d769cb
> Cr-Commit-Position: refs/heads/master@{#27421}

TBR=hpayer@chromium.org,erikcorry@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/1000523003

Cr-Commit-Position: refs/heads/master@{#27427}
darktears pushed a commit that referenced this pull request Apr 10, 2015
@isheludko
Revert of Reland "Filter invalid slots out from the SlotsBuffer after…
de018fb 
… marking." (patchset #2 id:2 of https://codereview.chromium.org/1032833002/)

Reason for revert:
Reverting risky GC changes that block v8 roll.

Original issue's description:
> Reland "Filter invalid slots out from the SlotsBuffer after marking."
>
> > There are two reasons that could cause invalid slots appearance in SlotsBuffer:
> > 1) If GC trims "tail" of an array for which it has already recorded a slots and then migrate another object to the "tail".
> > 2) Tagged slot could become a double slot after migrating of an object to another map with "shifted" fields (for example as a result of generalizing immutable data property to a data field).
>
> > This CL also adds useful machinery that helps triggering incremental write barriers.
>
> > BUG=chromium:454297
> > LOG=Y
>
> NOTRY=true
>
> Committed: https://crrev.com/f86aadd1d45c756467dff8e08a055b462d7a060b
> Cr-Commit-Position: refs/heads/master@{#27433}

TBR=machenbach@chromium.org,ulan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1041593002

Cr-Commit-Position: refs/heads/master@{#27491}
darktears pushed a commit that referenced this pull request Apr 10, 2015
@natorion
Disable handle zapping on 4.3 branch
25a166b 
BUG=
LOG=n
TBR=vogelheim@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1058893002

Cr-Commit-Position: refs/branch-heads/4.3@{#2}
Cr-Branched-From: f5c0a23-refs/heads/4.3.61@{#1}
Cr-Branched-From: 0a7d4f4-refs/heads/master@{#27508}
mrunalk pushed a commit that referenced this pull request Sep 27, 2016
Version 5.4.500.27
32bbac7 
Cr-Commit-Position: refs/branch-heads/5.4@{#52}
Cr-Branched-From: 5ce2827-refs/heads/5.4.500@{#2}
Cr-Branched-From: ad07b49-refs/heads/master@{#38841}
rakuco pushed a commit that referenced this pull request Oct 7, 2016
@natorion
Merged: Squashed multiple commits.
2e706ff 
Merged: [ic] Use UnseededNumberDictionary as a storage for names in TypeFeedbackMetadata.
Revision: 7031861

Merged: [ic] Move sloppy_arguments_elements_map down in the root list.
Revision: ab7234a

BUG=chromium:576312,chromium:576312,chromium:623516,chromium:623516
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
TBR=cbruni@chromium.org, ishell@chromium.org

Review URL: https://codereview.chromium.org/2367493002 .

Cr-Commit-Position: refs/branch-heads/5.3@{#71}
Cr-Branched-From: 820a23a-refs/heads/5.3.332@{#2}
Cr-Branched-From: 37538cb-refs/heads/master@{#37308}
rakuco pushed a commit that referenced this pull request Oct 7, 2016
Version 5.3.332.46
b4d8b7d 
Cr-Commit-Position: refs/branch-heads/5.3@{#72}
Cr-Branched-From: 820a23a-refs/heads/5.3.332@{#2}
Cr-Branched-From: 37538cb-refs/heads/master@{#37308}
rakuco pushed a commit that referenced this pull request Oct 7, 2016
Merged: [turbofan] Fix loop assignment analysis on ForInStatements.
ebc2b13 
Revision: 4dab7b5

BUG=chromium:647887
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=hablich@chromium.org, bmeurer@chromium.org

Review URL: https://codereview.chromium.org/2354333006 .

Cr-Commit-Position: refs/branch-heads/5.3@{#73}
Cr-Branched-From: 820a23a-refs/heads/5.3.332@{#2}
Cr-Branched-From: 37538cb-refs/heads/master@{#37308}
rakuco pushed a commit that referenced this pull request Oct 7, 2016
Version 5.3.332.47
0431e26 
Cr-Commit-Position: refs/branch-heads/5.3@{#74}
Cr-Branched-From: 820a23a-refs/heads/5.3.332@{#2}
Cr-Branched-From: 37538cb-refs/heads/master@{#37308}
rakuco pushed a commit that referenced this pull request Oct 17, 2016
@jaro-sevcik
[turbofan] Do not use field-type tracking types for loads.
c5361cc 
Instead, we conservatively set the type of loads to Type::Any.

BUG=chromium:645179
R=bmeurer@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2354213002
Cr-Commit-Position: refs/branch-heads/5.4@{#53}
Cr-Branched-From: 5ce2827-refs/heads/5.4.500@{#2}
Cr-Branched-From: ad07b49-refs/heads/master@{#38841}
rakuco pushed a commit that referenced this pull request Oct 17, 2016
Version 5.4.500.28
d2e267f 
Cr-Commit-Position: refs/branch-heads/5.4@{#54}
Cr-Branched-From: 5ce2827-refs/heads/5.4.500@{#2}
Cr-Branched-From: ad07b49-refs/heads/master@{#38841}
rakuco pushed a commit that referenced this pull request Oct 17, 2016
Merged: [turbofan] Fix loop assignment analysis on ForInStatements.
e6ff184 
Revision: 4dab7b5

BUG=chromium:647887
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=bmeurer@chromium.org, hablich@chromium.org

Review URL: https://codereview.chromium.org/2364843002 .

Cr-Commit-Position: refs/branch-heads/5.4@{#55}
Cr-Branched-From: 5ce2827-refs/heads/5.4.500@{#2}
Cr-Branched-From: ad07b49-refs/heads/master@{#38841}
rakuco pushed a commit that referenced this pull request Oct 17, 2016
Version 5.4.500.29
63f0e78 
Cr-Commit-Position: refs/branch-heads/5.4@{#56}
Cr-Branched-From: 5ce2827-refs/heads/5.4.500@{#2}
Cr-Branched-From: ad07b49-refs/heads/master@{#38841}
rakuco pushed a commit that referenced this pull request Oct 17, 2016
Merged: [turbofan] Remove bogus constant materialization from frame.
ab8f744 
Revision: 81f4342

BUG=chromium:648539
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=hablich@chromium.org

Review URL: https://codereview.chromium.org/2369463002 .

Cr-Commit-Position: refs/branch-heads/5.4@{#57}
Cr-Branched-From: 5ce2827-refs/heads/5.4.500@{#2}
Cr-Branched-From: ad07b49-refs/heads/master@{#38841}
rakuco pushed a commit that referenced this pull request Oct 17, 2016
Version 5.4.500.30
c472fde 
Cr-Commit-Position: refs/branch-heads/5.4@{#58}
Cr-Branched-From: 5ce2827-refs/heads/5.4.500@{#2}
Cr-Branched-From: ad07b49-refs/heads/master@{#38841}
rakuco pushed a commit that referenced this pull request Oct 17, 2016
@jeisinger
Merged: Make sure to use the correct context for eval checks
f1ac92a 
Revision: d008b9e

BUG=chromium:635769
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
TBR=hablich@chromium.org

Review URL: https://codereview.chromium.org/2368183005 .

Cr-Commit-Position: refs/branch-heads/5.4@{#59}
Cr-Branched-From: 5ce2827-refs/heads/5.4.500@{#2}
Cr-Branched-From: ad07b49-refs/heads/master@{#38841}
rakuco pushed a commit that referenced this pull request Oct 17, 2016
Version 5.4.500.31
59ff54e 
Cr-Commit-Position: refs/branch-heads/5.4@{#60}
Cr-Branched-From: 5ce2827-refs/heads/5.4.500@{#2}
Cr-Branched-From: ad07b49-refs/heads/master@{#38841}
rakuco pushed a commit that referenced this pull request Oct 21, 2016
@ajklein
Merged: Don't skip hole checks inside patterns in parameter lists
75cee5e 
Revision: 3c39bac

BUG=v8:5454
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
TBR=hablich@chromium.org

Review URL: https://codereview.chromium.org/2423503002 .

Cr-Commit-Position: refs/branch-heads/5.4@{#61}
Cr-Branched-From: 5ce2827-refs/heads/5.4.500@{#2}
Cr-Branched-From: ad07b49-refs/heads/master@{#38841}
rakuco pushed a commit that referenced this pull request Oct 21, 2016
Version 5.4.500.32
d946945 
Cr-Commit-Position: refs/branch-heads/5.4@{#62}
Cr-Branched-From: 5ce2827-refs/heads/5.4.500@{#2}
Cr-Branched-From: ad07b49-refs/heads/master@{#38841}
rakuco pushed a commit that referenced this pull request Oct 21, 2016
@bmeurer
Merged: [crankshaft] Disable further folding already folded allocations.
554050f 
Revision: 7b79224

BUG=chromium:621868
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
TBR=jarin@chromium.org

Review URL: https://codereview.chromium.org/2424333002 .

Cr-Commit-Position: refs/branch-heads/5.4@{#63}
Cr-Branched-From: 5ce2827-refs/heads/5.4.500@{#2}
Cr-Branched-From: ad07b49-refs/heads/master@{#38841}
rakuco pushed a commit that referenced this pull request Oct 21, 2016
Version 5.4.500.33
93fbfa2 
Cr-Commit-Position: refs/branch-heads/5.4@{#64}
Cr-Branched-From: 5ce2827-refs/heads/5.4.500@{#2}
Cr-Branched-From: ad07b49-refs/heads/master@{#38841}
rakuco pushed a commit that referenced this pull request Oct 21, 2016
@bmeurer
Merged: [turbofan] Fix return value of Array.prototype.push.
0112cbb 
Revision: 8584442

BUG=chromium:656037
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
TBR=jarin@chromium.org

Review URL: https://codereview.chromium.org/2434753002 .

Cr-Commit-Position: refs/branch-heads/5.4@{#65}
Cr-Branched-From: 5ce2827-refs/heads/5.4.500@{#2}
Cr-Branched-From: ad07b49-refs/heads/master@{#38841}
rakuco pushed a commit that referenced this pull request Oct 21, 2016
Version 5.4.500.34
2e2fc86 
Cr-Commit-Position: refs/branch-heads/5.4@{#66}
Cr-Branched-From: 5ce2827-refs/heads/5.4.500@{#2}
Cr-Branched-From: ad07b49-refs/heads/master@{#38841}
rakuco pushed a commit that referenced this pull request Oct 21, 2016
@isheludko
Merged: [crankshaft] Range analysis should not rely on overflowed ran…
495e5a0 
…ges.

Revision: 9a0109d

BUG=chromium:645438
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
TBR=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/2436763002 .

Cr-Commit-Position: refs/branch-heads/5.4@{#67}
Cr-Branched-From: 5ce2827-refs/heads/5.4.500@{#2}
Cr-Branched-From: ad07b49-refs/heads/master@{#38841}
rakuco pushed a commit that referenced this pull request Oct 21, 2016
Version 5.4.500.35
51f0c63 
Cr-Commit-Position: refs/branch-heads/5.4@{#68}
Cr-Branched-From: 5ce2827-refs/heads/5.4.500@{#2}
Cr-Branched-From: ad07b49-refs/heads/master@{#38841}
rakuco pushed a commit that referenced this pull request Oct 21, 2016
@natorion
Merged: Squashed multiple commits.
9ee144d 
Merged: [turbofan] Ensure that all prototypes are stable for push/pop.
Revision: 4ed27fc

Merged: [turbofan] Fix effect chain for polymorphic array access.
Revision: edfe391

BUG=chromium:644689,chromium:655004
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
TBR=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/2434893002 .

Cr-Commit-Position: refs/branch-heads/5.4@{#69}
Cr-Branched-From: 5ce2827-refs/heads/5.4.500@{#2}
Cr-Branched-From: ad07b49-refs/heads/master@{#38841}
rakuco pushed a commit that referenced this pull request Oct 21, 2016
Version 5.4.500.36
a83e8d1 
Cr-Commit-Position: refs/branch-heads/5.4@{#70}
Cr-Branched-From: 5ce2827-refs/heads/5.4.500@{#2}
Cr-Branched-From: ad07b49-refs/heads/master@{#38841}
imreotto pushed a commit to tenta-browser/v8-crosswalk that referenced this pull request Sep 4, 2017
@bmeurer
Revert of [turbofan] Less aggressively insert SOFT deopts for propert…
098f939 
…y access. (patchset crosswalk-project#2 id:20001 of https://codereview.chromium.org/2746013002/ )

Reason for revert:
Tanks Octane/Mandreel and Octane/MandreelLatency.

Original issue's description:
> [turbofan] Less aggressively insert SOFT deopts for property access.
>
> Sometimes TurboFan is able to extract receiver maps from the surrounding
> graph and thus is able to generate reasonable code for property accesses,
> even if those haven't been executed in the baseline tier yet. So, only
> stick in an SOFT deoptimization exit, if ExtractReceiverMaps failed to
> infer proper receiver maps.
>
> R=yangguo@chromium.org
> BUG=v8:5267
>
> Review-Url: https://codereview.chromium.org/2746013002
> Cr-Commit-Position: refs/heads/master@{#43736}
> Committed: https://chromium.googlesource.com/v8/v8/+/b8453628c94ddf71e05d70471355c7c924bbcf31

TBR=yangguo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:5267

Review-Url: https://codereview.chromium.org/2748663002
Cr-Commit-Position: refs/heads/master@{#43743}
imreotto pushed a commit to tenta-browser/v8-crosswalk that referenced this pull request Sep 4, 2017
@alexkozy
Revert of [inspector] convert V8Console static methods into members (…
5b306f7 
…patchset crosswalk-project#2 id:20001 of https://codereview.chromium.org/2783073002/ )

Reason for revert:
Too many simulatenously landed CLs, this one should be rebased first.

Original issue's description:
> [inspector] convert V8Console static methods into members
>
> This step is required to implement console as builtin which calls console delegate methods.
>
> BUG=v8:6168
> R=dgozman@chromium.org
>
> Review-Url: https://codereview.chromium.org/2783073002
> Cr-Commit-Position: refs/heads/master@{#44283}
> Committed: https://chromium.googlesource.com/v8/v8/+/fe27dccd873024213b16d1e9810dda6a6c705571

TBR=dgozman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:6168

Review-Url: https://codereview.chromium.org/2793443002
Cr-Commit-Position: refs/heads/master@{#44284}
imreotto pushed a commit to tenta-browser/v8-crosswalk that referenced this pull request Sep 4, 2017
@tanderson-google
Revert of Remove download_binaries.py from DEPS (patchset crosswalk-p…
3b72184 
…roject#2 id:20001 of https://codereview.chromium.org/2774043002/ )

Reason for revert:
https://codereview.chromium.org/2775913002/ needs to be reverted, so reverting all dependent patch sets

Original issue's description:
> Remove download_binaries.py from DEPS
>
> This step is no longer necessary after https://codereview.chromium.org/2775913002/
>
> BUG=chromium:705072
>
> Review-Url: https://codereview.chromium.org/2774043002
> Cr-Commit-Position: refs/heads/master@{#44252}
> Committed: https://chromium.googlesource.com/v8/v8/+/459b881c233557f5da9ca9e4779fc1696c785a1c

TBR=machenbach@chromium.org,thomasanderson@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:705072

Review-Url: https://codereview.chromium.org/2786173004
Cr-Commit-Position: refs/heads/master@{#44289}
imreotto pushed a commit to tenta-browser/v8-crosswalk that referenced this pull request Sep 4, 2017
@hannespayer
Revert of [heap] Take page lock when scavenging old to new references…
d6bd3eb 
… in Scavenger. (patchset crosswalk-project#2 id:20001 of https://codereview.chromium.org/2781363002/ )

Reason for revert:
This results in a deadlock when the scavenger decides to perform sweeping and re-grabs the same mutex.

Original issue's description:
> [heap] Take page lock when scavenging old to new references in Scavenger.
>
> BUG=v8:5807
>
> Review-Url: https://codereview.chromium.org/2781363002
> Cr-Commit-Position: refs/heads/master@{#44268}
> Committed: https://chromium.googlesource.com/v8/v8/+/4024e6a1bb0b803a5cd16fcd11f39cc305b943c6

TBR=ulan@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:5807

Review-Url: https://codereview.chromium.org/2786313003
Cr-Commit-Position: refs/heads/master@{#44302}
imreotto pushed a commit to tenta-browser/v8-crosswalk that referenced this pull request Sep 4, 2017
@bmeurer
Revert of [turbofan] Better representation selection for comparison w…
5e78b32 
…ith Float64. (patchset crosswalk-project#2 id:20001 of https://codereview.chromium.org/2790833004/ )

Reason for revert:
Doesn't really move the needle, but tanks Kraken/imaging-gaussian-blur (crbug.com/709396), so reverting for now.

Original issue's description:
> [turbofan] Better representation selection for comparison with Float64.
>
> For speculative number comparisons with SignedSmall feedback, we always
> enforce either TaggedSigned or Word32 comparisons. But this is not
> really beneficial if one of the inputs is already in Float64
> representation; in that case it's cheaper to just convert the other
> input to a Float64.
>
> R=jarin@chromium.org
>
> Review-Url: https://codereview.chromium.org/2790833004
> Cr-Commit-Position: refs/heads/master@{#44327}
> Committed: https://chromium.googlesource.com/v8/v8/+/8af394d6d385daf05b73765a2545ac8f266c64c7

TBR=jarin@chromium.org
BUG=chromium:709396

Review-Url: https://codereview.chromium.org/2801233002
Cr-Commit-Position: refs/heads/master@{#44480}
imreotto pushed a commit to tenta-browser/v8-crosswalk that referenced this pull request Sep 4, 2017
@natorion
Disable handle zapping on branch 5.9
2370b7a 
BUG=chromium:318206
TBR=jochen@chromium.org, machenbach@chromium.org
LOG=n
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2811303004 .
Cr-Commit-Position: refs/branch-heads/5.9@{crosswalk-project#2}
Cr-Branched-From: fe9bb7e-refs/heads/5.9.211@{crosswalk-project#1}
Cr-Branched-From: 70ad237-refs/heads/master@{#44591}
asifhisam pushed a commit to asifhisam/v8-crosswalk that referenced this pull request Sep 9, 2019
@natorion
Disable handle zapping on branch 5.8
e3c14bb 
BUG=chromium:318206
TBR=jochen@chromium.org, machenbach@chromium.org
LOG=n
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2724953006
Cr-Commit-Position: refs/branch-heads/5.8@{crosswalk-project#2}
Cr-Branched-From: eda659c-refs/heads/5.8.283@{crosswalk-project#1}
Cr-Branched-From: 4310cd0-refs/heads/master@{#43429}
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fenghaitao @huningxin