V8 profiling patch rebased on Chromuim v34 #6

dp7 · 2014-03-18T17:44:05Z

This is the same patch as we already applied for Chromium v32 with minor differences in Logger::LogCodeObjects() and Logger::LogCompiledFunctions() from log.cc.
This patch enables CPU profiling feature for XDK.

darktears · 2014-03-18T17:47:40Z

LGTM

V8 profiling patch rebased on Chromuim v34

fenghaitao · 2014-03-19T01:30:48Z

buildbot fails for x64, ia32 and arm.

http://wrt-build.sh.intel.com/buildbot/builders/V8%20Linux%20-%20builder/builds/14
http://wrt-build.sh.intel.com/buildbot/builders/V8%20Linux64/builds/11
http://wrt-build.sh.intel.com/buildbot/builders/V8%20Linux%20-%20arm%20-%20sim/builds/12

dp7 · 2014-03-19T04:27:09Z

Thank all for review. I will fix spelling and compile issues as soon as I can today.

darktears · 2014-03-19T11:32:55Z

I think we should revert. Sounds like we need try bots. @dp7 which platforms did you test as none of the supported one are building?

gramakri · 2014-03-19T11:39:01Z

It's too late to fix atleast one of the spelling mistakes since it's in the commit message :)

darktears · 2014-03-19T11:41:05Z

I've reverted it.

dp7 · 2014-03-19T11:41:41Z

I use Linux (Ubuntu) to build xwalk. The reason I couldn't see these warnings as errors was missing -Wall compiler option in default configuration. I had to add it manually to see all these warnings.

darktears · 2014-03-19T11:41:47Z

Please upload a new version which compiles and work correctly. History clutter is not a problem, the next rebase I will clean it up.

dp7 · 2014-03-19T11:43:00Z

I am already fixed it. Last minute testing to be sure that everything is OK.

dp7 · 2014-03-19T11:43:40Z

.. then I will upload a new version.

Merged 76ce4a9 [d8] Fix V8 external snapshot for Windows. BUG=421063,439661 LOG=N R=yangguo@chromium.org, rmcilroy@chromium.org Review URL: https://codereview.chromium.org/838383007 Cr-Commit-Position: refs/branch-heads/4.1@{#6} Cr-Branched-From: 2e08d2a-refs/heads/candidates@{#25353}

…rom linux (patchset #6 id:100001 of https://codereview.chromium.org/955393002/) Reason for revert: broke some things Original issue's description: > ensure host compiler is always clang when cross compiling from linux > > BUG= > > Committed: https://crrev.com/56039af476797accc238dcb24c7ab926899287a0 > Cr-Commit-Position: refs/heads/master@{#26881} TBR=machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/964483002 Cr-Commit-Position: refs/heads/master@{#26882}

…s://codereview.chromium.org/975463002/) Reason for revert: ARM build failure... Original issue's description: > Implement subclassing Arrays. > > R=mvstanton@chromium.org,arv@chromium.org,rossberg@chromium.org > BUG=v8:3930 > LOG=Y > > Committed: https://crrev.com/6898da1a28d64d1fb2962804ba566f6d618ffc70 > Cr-Commit-Position: refs/heads/master@{#26960} TBR=arv@chromium.org,rossberg@chromium.org,dslomov@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3930 Review URL: https://codereview.chromium.org/975693002 Cr-Commit-Position: refs/heads/master@{#26961}

Add ia32 support for int32x4 and float64x2

Merged 1604bd4 Implement subclassing Arrays. BUG=v8:3930,chromium:463894 LOG=N R=rossberg@chromium.org Review URL: https://codereview.chromium.org/997063003 Cr-Commit-Position: refs/branch-heads/4.2@{crosswalk-project#6} Cr-Branched-From: 3dfd929-refs/heads/4.2.77@{crosswalk-project#2} Cr-Branched-From: e011092-refs/heads/master@{#26757}

…. (patchset #6 id:220001 of https://codereview.chromium.org/1010363005/) Reason for revert: Need to revert in order to revert https://codereview.chromium.org/1029323003/ Original issue's description: > Filter invalid slots out from the SlotsBuffer after marking. > > There are two reasons that could cause invalid slots appearance in SlotsBuffer: > 1) If GC trims "tail" of an array for which it has already recorded a slots and then migrate another object to the "tail". > 2) Tagged slot could become a double slot after migrating of an object to another map with "shifted" fields (for example as a result of generalizing immutable data property to a data field). > > This CL also adds useful machinery that helps triggering incremental write barriers. > > BUG=chromium:454297 > LOG=Y > > Committed: https://crrev.com/5c47c1c0d3e4a488f190c16a64ee02f5a14e6561 > Cr-Commit-Position: refs/heads/master@{#27423} TBR=hpayer@chromium.org,erik.corry@gmail.com,ishell@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:454297 Review URL: https://codereview.chromium.org/1033453005 Cr-Commit-Position: refs/heads/master@{#27426}

Merged 845154a Fix the bug in CompareIC_GenerateNumber for X87 platform. R=jkummerow@chromium.org BUG= Review URL: https://codereview.chromium.org/1065303004 Cr-Commit-Position: refs/branch-heads/4.3@{#6} Cr-Branched-From: f5c0a23-refs/heads/4.3.61@{#1} Cr-Branched-From: 0a7d4f4-refs/heads/master@{#27508}

…tchset #6 id:150001 of https://codereview.chromium.org/1045753002/) Reason for revert: [Sheriff] Breaks compile here: http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/6115 Original issue's description: > CpuProfiler: public API for deopt info in cpu profiler. > > BUG=chromium:452067 > LOG=n > > Committed: https://crrev.com/baf927ff5115ec62a6dad684b9232ed9d3960e3a > Cr-Commit-Position: refs/heads/master@{#27626} TBR=alph@chromium.org,jkummerow@chromium.org,svenpanne@chromium.org,yurys@chromium.org,loislo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:452067 Review URL: https://codereview.chromium.org/1062053004 Cr-Commit-Position: refs/heads/master@{#27628}

… id:100001 of https://codereview.chromium.org/1094863002/) Reason for revert: I'm reverting this while working on the regression fix Original issue's description: > Remove the weak list of views from array buffers > > Instead, views have to check their array buffer for whether > it's neutered or not. > > BUG=v8:3996 > R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org > LOG=n > > Committed: https://crrev.com/5ae083a05a6743d6cb91585f449539f7846a5d8c > Cr-Commit-Position: refs/heads/master@{#27995} TBR=dslomov@chromium.org,hpayer@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3996 Review URL: https://codereview.chromium.org/1061753008 Cr-Commit-Position: refs/heads/master@{#28014}

…00001 of https://codereview.chromium.org/802583003/) Reason for revert: Compile failures: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/2047 Original issue's description: > [test] Make msan work for v8 stand-alone. > > The msan configuration can be used in combination with > v8_use_snapshot=false. > > BUG=chromium:425187 > LOG=n > > Committed: https://crrev.com/a65ef0d53fc28b0908f228938c6d84effa83c596 > Cr-Commit-Position: refs/heads/master@{#28064} TBR=jochen@chromium.org,earthdok@chromium.org,svenpanne@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:425187 Review URL: https://codereview.chromium.org/1104073002 Cr-Commit-Position: refs/heads/master@{#28068}

…ttps://codereview.chromium.org/1104073002/) Reason for revert: Reland after switching bot to ninja. Original issue's description: > Revert of [test] Make msan work for v8 stand-alone. (patchset #6 id:100001 of https://codereview.chromium.org/802583003/) > > Reason for revert: > Compile failures: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/2047 > > Original issue's description: > > [test] Make msan work for v8 stand-alone. > > > > The msan configuration can be used in combination with > > v8_use_snapshot=false. > > > > BUG=chromium:425187 > > LOG=n > > > > Committed: https://crrev.com/a65ef0d53fc28b0908f228938c6d84effa83c596 > > Cr-Commit-Position: refs/heads/master@{#28064} > > TBR=jochen@chromium.org,earthdok@chromium.org,svenpanne@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:425187 > > Committed: https://crrev.com/f69a48696ec3ec0ea1169a41b4c84fb36b059968 > Cr-Commit-Position: refs/heads/master@{#28068} TBR=jochen@chromium.org,earthdok@chromium.org,svenpanne@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:425187 Review URL: https://codereview.chromium.org/1102323002 Cr-Commit-Position: refs/heads/master@{#28078}

Merged de3a1ca Bug: Runtime_GrowArrayElements provoked unnecessary lazy deopt. BUG=488398 LOG=N R=jarin@chromium.org Review URL: https://codereview.chromium.org/1145343004 Cr-Commit-Position: refs/branch-heads/4.4@{crosswalk-project#6} Cr-Branched-From: 2e4c550-refs/heads/4.4.63@{#1} Cr-Branched-From: 0208b8e-refs/heads/master@{#28333}

…chset crosswalk-project#6 id:100001 of https://codereview.chromium.org/1125073004/) Reason for revert: [Sheriff] Breaks msan: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/2266 Original issue's description: > Prevent stack overflow in the serializer/deserializer. > > We keep an eye on the recursion depth. Once it exceeds a limit, we serialize > only the object header and size, but defer serializing the object body for > after we have unwound the stack. > > R=mvstanton@chromium.org > > Committed: https://crrev.com/36b4a498d6614243454d5a182e4946b0dad24f0a > Cr-Commit-Position: refs/heads/master@{#28385} TBR=mvstanton@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1139113002 Cr-Commit-Position: refs/heads/master@{#28403}

… id:100001 of https://codereview.chromium.org/1186733002/) Reason for revert: [Sheriff] Changes layout tests: http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2032/builds/429 See e.g.: https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Linux_32/429/layout-test-results/inspector/console/console-big-array-pretty-diff.html Please upload a blink side needsmanualrebaseline change first for these tests if the change is intended. Please also add a blink trybot on a reland of this CL. Original issue's description: > Add %TypedArray% to proto chain > > According to the ES6 spec, the main methods and getters shouldn't > be properties of the individual TypedArray objects and prototypes > but instead on %TypedArray% and %TypedArray%.prototype. This > difference is observable through introspection. This patch moves > some methods and getters to the proper place, with the exception > of %TypedArray%.prototype.subarray and harmony methods. These will > be moved in follow-on patches. > > BUG=v8:4085 > LOG=Y > R=adamk > > Committed: https://crrev.com/a10590158260737b256fac3254b4939f48f90095 > Cr-Commit-Position: refs/heads/master@{#29057} TBR=adamk@chromium.org,arv@chromium.org,littledan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4085 Review URL: https://codereview.chromium.org/1192433003 Cr-Commit-Position: refs/heads/master@{#29070}

…rosswalk-project#6 id:100001 of https://codereview.chromium.org/1185643004/) Reason for revert: Fails on V8 Win32 - nosnap - shared (http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/7427) Fails on V8 Arm - debug builder (http://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20debug%20builder/builds/4361) Fails on V8 Linux - shared (http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20shared/builds/4430) Original issue's description: > Add d8 API for spawning function on a new thread. > > This API closely matches the Worker API. The differences: > > 1) The argument to the Worker constructor is a function to run, not a script. > 2) Receiving a message from a worker is a synchronous API (as there is no event > loop). > > The serialization done here is not robust as the real DOM implementation. For > example, recursive data structures or otherwise duplicated objects are not > allowed. > > BUG=none > R=jochen@chromium.org > LOG=n > > Committed: https://crrev.com/3d98b956b56fa283b40913788ff760022d478812 > Cr-Commit-Position: refs/heads/master@{#29126} TBR=jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Review URL: https://codereview.chromium.org/1192193002 Cr-Commit-Position: refs/heads/master@{#29130}

…1 of https://codereview.chromium.org/1187543003/) Reason for revert: [Sheriff] Breaks gcstress and mac asan: http://build.chromium.org/p/client.v8/builders/V8%20GC%20Stress%20-%203/builds/3896 http://build.chromium.org/p/client.v8/builders/V8%20Mac64%20ASAN/builds/1774 Original issue's description: > Ship Harmony Array/TypedArray methods > > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel > BUG=v8:3578 > LOG=Y > R=adamk > > Committed: https://crrev.com/7142b0d211b732e1c119fded80f43fbbd9cea0f8 > Cr-Commit-Position: refs/heads/master@{#29170} TBR=adamk@chromium.org,littledan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3578 Review URL: https://codereview.chromium.org/1195163002 Cr-Commit-Position: refs/heads/master@{#29171}

…erJoin to JS (patchset #6 id:100001 of https://codereview.chromium.org/1775403008/ ) Reason for revert: [Sheriff] This lets a gc stress test time out: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/2337/steps/Mjsunit%20%28flakes%29/logs/regress-542823 The test ran in <2sec before this. Please fix the test as well on a reland. Original issue's description: > Replace PushIfAbsent by a Stack object and move StringBuilderJoin to JS > > This significantly speeds up String(array). > BUG= > > Committed: https://crrev.com/c91faa0b39b62025460eb9f8b578e20d88f3549e > Cr-Commit-Position: refs/heads/master@{#34696} TBR=cbruni@chromium.org,adamk@chromium.org,bmeurer@chromium.org,verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1785003004 Cr-Commit-Position: refs/heads/master@{#34706}

…id:140001 of https://codereview.chromium.org/1801203002/ ) Reason for revert: Violates ES6 spec (crbug.com/4850), and implementation was over-eager. Will revert for now. Original issue's description: > Parser: Make skipping HTML comments optional. > > API change: This adds a new flag skip_html_comments to v8::ScriptOriginOptions. This flag controls whether V8 will attempt to honour HTML-style comments in JS sources. > > (That is: Gracefully ignore  in JS sources, which was a popular technique in the early days of JavaScript, to prevent non-JS-enabled browsers from displaying script sources to uses.) > > The flag defaults to 'true' when using v8::ScriptOrigin constructor, which preserves the existing behaviour. Embedders which are happy with the existing behaviour will thus not need any changes. > > BUG=chromium:573887 > LOG=Y > > Committed: https://crrev.com/91d344288aa51ed03eaaa1cb3e368ac1e82f0173 > Cr-Commit-Position: refs/heads/master@{#34904} TBR=jochen@chromium.org,rossberg@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:573887, v8:4850 LOG=Y Review URL: https://codereview.chromium.org/1817163003 Cr-Commit-Position: refs/heads/master@{#34958}

Merged 2f8de2e Fix Gyp rule that broke node.js build after snapshot log removal. R=hablich@chromium.org NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1870103002 Cr-Commit-Position: refs/branch-heads/5.1@{#6} Cr-Branched-From: 167dc63-refs/heads/5.1.281@{#1} Cr-Branched-From: 03953f5-refs/heads/master@{#35282}

…id:100001 of https://codereview.chromium.org/1891033002/ ) Reason for revert: [Sheriff] Breaks https://build.chromium.org/p/client.v8/builders/V8%20Linux%20ASAN%20mipsel%20-%20debug%20builder/builds/6121 Original issue's description: > [Atomics] Remove Atomics code stubs; use TF ops > > This is a much cleaner solution, which won't require nearly as much > architecture-specific code. Thanks bmeurer@! > > BUG=v8:4614 > LOG=y > R=bmeurer@chromium.org,jarin@chromium.org > > Committed: https://crrev.com/6ff5881b1def45b35384572f61327e42563a89c3 > Cr-Commit-Position: refs/heads/master@{#35547} TBR=bmeurer@chromium.org,jarin@chromium.org,rodolph.perfetta@gmail.com,binji@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4614 Review URL: https://codereview.chromium.org/1895643002 Cr-Commit-Position: refs/heads/master@{#35548}

…01 of https://codereview.chromium.org/1961973002/ ) Reason for revert: The ThreadSanitizer finds data races. Original issue's description: > [wasm] Implement parallel compilation. > > With this CL it is possible to compile a wasm module with multiple > threads in parallel. Parallel compilation works as follows: > > 1) The main thread allocates a compilation unit for each wasm function. > 2) The main thread spawns WasmCompilationTasks which run on the > background threads. > 3.a) The background threads and the main thread pick one compilation unit > at a time and execute the parallel phase of the compilation unit. > After finishing the execution of the parallel phase, the compilation > unit is stored in a result queue. > 3.b) If the result queue contains a compilation unit, the main thread > dequeues it and finishes its compilation. > 4) After the execution of the parallel phase of all compilation units has > started, the main thread waits for all WasmCompilationTasks to finish. > 5) The main thread finalizes the compilation of the module. > > I'm going to add some additional tests before committing this CL. > > R=titzer@chromium.org, bmeurer@chromium.org, mlippautz@chromium.org, mstarzinger@chromium.org > > Committed: https://crrev.com/17215438659d8ff2d7d55f95226bf8a1477ccd79 > Cr-Commit-Position: refs/heads/master@{#36178} TBR=bmeurer@chromium.org,mlippautz@chromium.org,mstarzinger@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/1965243003 Cr-Commit-Position: refs/heads/master@{#36182}

… mode (patchset #6 id:100001 of https://codereview.chromium.org/1948403002/ ) Reason for revert: [Sheriff] Breaks https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20debug%20builder/builds/602 Original issue's description: > In parallel to the strict octal check that would reject `012` in strict mode, this patch collects UseCounters for `089` in strict mode. The spec says this should be an error, but this patch does not report it as such. > > BUG=v8:4973 > LOG=y > > Committed: https://crrev.com/d0b6686c14339bd5d0aeaf610705c7ed85393e1f > Cr-Commit-Position: refs/heads/master@{#36221} TBR=littledan@chromium.org,caitpotter88@gmail.com,jwolfe@igalia.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4973 Review-Url: https://codereview.chromium.org/1970333004 Cr-Commit-Position: refs/heads/master@{#36224}

…with returning to the entry trampoline. (patchset #6 id:170001 of https://codereview.chromium.org/1969423002/ ) Reason for revert: Breaks https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm%20-%20sim/builds/619 Might only affect pure release builds? Original issue's description: > [Interpreter] Remove InterpreterExitTrampoline and replace with returning to the entry trampoline. > > In order to support compiling to baseline on return we need to be able to > return to the actual return address. With this change this is what the > Return bytecode now does, removing the need for the > InterpreterExitTrampoline. > > This change also removes the InterpreterNotifyDeoptXXX builtins and > unifies FCG and Igntion to both use NotifyDeoptXXX. As part of this > change, FullCodegenerator::State is moved to Deoptimize::BailoutState. > > BUG=v8:4280 > LOG=N > > Committed: https://crrev.com/34c9626e2ee56fe805de549697ca5323aed7cb66 > Cr-Commit-Position: refs/heads/master@{#36288} TBR=mstarzinger@chromium.org,oth@chromium.org,rmcilroy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4280 Review-Url: https://codereview.chromium.org/1986353002 Cr-Commit-Position: refs/heads/master@{#36294}

Merged 32ba3c9 X87: [Interpreter] Remove InterpreterExitTrampoline and replace with returning to the entry trampoline. R=hablich@chromium.org BUG= LOG=N NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/1995273002 Cr-Commit-Position: refs/branch-heads/5.2@{#6} Cr-Branched-From: 2cd36d6-refs/heads/5.2.361@{#1} Cr-Branched-From: 3fef34e-refs/heads/master@{#36332}

… of https://codereview.chromium.org/1986173002/ ) Reason for revert: Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/6896 Original issue's description: > Refactor script position calculation > > Script position calculation logic (i.e. line & column numbers for a > given code position) is now based on a single method > Script::GetPositionInfo(). Refactored related code in isolate.cc and > js/messages.js to use the new method and removed the line_ends JS > accessor. > > R=yangguo@chromium.org > BUG= > > Committed: https://crrev.com/c04d547298ce4fd425ef1eaa9b02ad1e177918dc > Cr-Commit-Position: refs/heads/master@{#36359} TBR=yangguo@chromium.org,jgruber@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/1994973002 Cr-Commit-Position: refs/heads/master@{#36368}

…d:220001 of https://codereview.chromium.org/2005723005/ ) Reason for revert: Breaking TSAN https://uberchromegw.corp.google.com/i/client.v8/builders/V8%20Linux64%20TSAN/builds/9741/steps/Ignition%20-%20turbofan%20%28flakes%29/logs/FixedUint32Array Original issue's description: > Reland of "[heap] Fine-grained JSArrayBuffer tracking" > > Track based on JSArrayBuffer addresses on pages instead of the attached > backing store. > > Details of tracking: > - Scavenge: New space pages are processes in bulk on the main thread > - MC: Unswept pages are processed in bulk in parallel. All other pages > are processed by the sweeper concurrently. > > This reverts commit d2dff03. > > R=hpayer@chromium.org > BUG=chromium:611688 > LOG=N > CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg,v8_linux_gc_stress_dbg,v8_mac_gc_stress_dbg,v8_linux64_tsan_rel,v8_mac64_asan_rel > > Committed: https://crrev.com/b5704bc1e6ba74c9ca975f5d58f5b2dc60261457 > Cr-Commit-Position: refs/heads/master@{#36495} TBR=hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:611688 Review-Url: https://codereview.chromium.org/2011863002 Cr-Commit-Position: refs/heads/master@{#36504}

…view.chromium.org/2011853002/ ) Reason for revert: http://crbug.com/615890 Original issue's description: > [gn] Add unittests > > BUG=chromium:474921 > NOTRY=true > > Committed: https://crrev.com/67e549ec5b34ad02506abb2720c6a0851ae31f5e > Cr-Commit-Position: refs/heads/master@{#36510} > > Committed: https://crrev.com/143b3d167d7014525d049d3ab53c73cf2592243c > Cr-Commit-Position: refs/heads/master@{#36582} TBR=vogelheim@chromium.org,bmeurer@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:474921 Review-Url: https://codereview.chromium.org/2022893002 Cr-Commit-Position: refs/heads/master@{#36605}

…ap. (patchset #6 id:100001 of https://codereview.chromium.org/2046953002/ ) Reason for revert: Revert because uncommit of lo is broken. Original issue's description: > [heap] Unregister shrinked large object memory from chunk map. > > BUG=chromium:617883 > LOG=n > > Committed: https://crrev.com/2b38d3121b5fd0e409cdda0071fa2e0ec2846ab2 > Cr-Commit-Position: refs/heads/master@{#36793} TBR=ulan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:617883 Review-Url: https://codereview.chromium.org/2046563008 Cr-Commit-Position: refs/heads/master@{#36806}

…id:100001 of https://codereview.chromium.org/2052523002/ ) Reason for revert: Seems to break TSAN, see http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/10057 Original issue's description: > The trace-events will have a high overhead when turned on, but they are in a disabled-by-default category. > > As long as the off overhead is negligible, this CL allows us to understand the behavior of V8 rather than its performance at the moment. > > BUG=v8:5089 > > Committed: https://crrev.com/44ec143f26769bd103662643bfeafc7d0834cc90 > Cr-Commit-Position: refs/heads/master@{#36909} TBR=cbruni@chromium.org,fmeawad@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5089 Review-Url: https://codereview.chromium.org/2064553002 Cr-Commit-Position: refs/heads/master@{#36910}

Cr-Commit-Position: refs/branch-heads/5.3@{#6} Cr-Branched-From: 820a23a-refs/heads/5.3.332@{#2} Cr-Branched-From: 37538cb-refs/heads/master@{#37308}

…eters. (patchset #6 id:100001 of https://codereview.chromium.org/2109733003/ ) Reason for revert: Fuzzer claims `try { \"\" ; } catch(x) { let x1 = [1,,], x = x; }` causes a crash. Original issue's description: > Add errors for declarations which conflict with catch parameters. > > Catch parameters are largely treated as lexical declarations in the > block which contains their body for the purposes of early syntax errors, > with some exceptions outlined in B.3.5. This patch introduces most of > those errors, except those from `eval('for (var e of ...);')` inside of > a catch with a simple parameter named 'e'. > > Note that annex B.3.5 allows var declarations to conflict with simple > catch parameters, except when the variable declaration is the init of a > for-of statement. > > BUG=v8:5112,v8:4231 > > Committed: https://crrev.com/2907c726b2bb5cf20b2bec639ca9e6a521585406 > Cr-Commit-Position: refs/heads/master@{#37462} TBR=littledan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5112,v8:4231 Review-Url: https://codereview.chromium.org/2112223002 Cr-Commit-Position: refs/heads/master@{#37464}

…eters. (patchset #1 id:1 of https://codereview.chromium.org/2112223002/ ) Reason for revert: Correcting issue. Original issue's description: > Revert of Add errors for declarations which conflict with catch parameters. (patchset #6 id:100001 of https://codereview.chromium.org/2109733003/ ) > > Reason for revert: > Fuzzer claims `try { \"\" ; } catch(x) { let x1 = [1,,], x = x; }` causes a crash. > > Original issue's description: > > Add errors for declarations which conflict with catch parameters. > > > > Catch parameters are largely treated as lexical declarations in the > > block which contains their body for the purposes of early syntax errors, > > with some exceptions outlined in B.3.5. This patch introduces most of > > those errors, except those from `eval('for (var e of ...);')` inside of > > a catch with a simple parameter named 'e'. > > > > Note that annex B.3.5 allows var declarations to conflict with simple > > catch parameters, except when the variable declaration is the init of a > > for-of statement. > > > > BUG=v8:5112,v8:4231 > > > > Committed: https://crrev.com/2907c726b2bb5cf20b2bec639ca9e6a521585406 > > Cr-Commit-Position: refs/heads/master@{#37462} > > TBR=littledan@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:5112,v8:4231 > > Committed: https://crrev.com/8834d5ecb559001c87c42322969471da60574a8c > Cr-Commit-Position: refs/heads/master@{#37464} R=littledan@chromium.org BUG=v8:5112,v8:4231 Review-Url: https://codereview.chromium.org/2119933002 Cr-Commit-Position: refs/heads/master@{#37728}

…de handler (patchset #6 id:100001 of https://codereview.chromium.org/2153433002/ ) Reason for revert: This cl causes a large regression in octane (https://chromeperf.appspot.com/group_report?bug_id=629503). I have to investigate the reason before I can reland this. Original issue's description: > [Interpreter] Collect type feedback for 'new' in the bytecode handler > > Collect type feedback in the bytecode handler for 'new' bytecode. The > current implementation does not collect allocation site feedback. > > BUG=v8:4280, v8:4780 > LOG=N > > Committed: https://crrev.com/1eadc76419b323fb2e55ae9953142f801704aa59 > Cr-Commit-Position: refs/heads/master@{#37862} TBR=rmcilroy@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4280, v8:4780 Review-Url: https://codereview.chromium.org/2165633003 Cr-Commit-Position: refs/heads/master@{#37872}

…chset #6 id:100001 of https://codereview.chromium.org/2160613002/ ) Reason for revert: Suspected to cause crbug.com/630969 Original issue's description: > [heap] Remove black pages and use black areas instead. > > BUG=630386 > LOG=n > > Committed: https://crrev.com/b008a0d5a3db80a854cb93d9c94d67bf2d780f2c > Cr-Commit-Position: refs/heads/master@{#37967} TBR=ulan@chromium.org,hpayer@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=630386 Review-Url: https://codereview.chromium.org/2176133002 Cr-Commit-Position: refs/heads/master@{#38006}

… id:100001 of https://codereview.chromium.org/2172233002/ ) Reason for revert: Bunch of breakages. Maybe bad interaction with https://chromium.googlesource.com/v8/v8/+/e520e5da5550f0d1a975e87d6e66a2edecbb0c8e ? E.g.: https://build.chromium.org/p/client.v8/builders/V8%20Linux64/builds/11607 Original issue's description: > [interpreter] Add explicit OSR polling bytecode. > > This adds an explicit {OsrPoll} bytecode into every loop header which > triggers on-stack replacement when armed. Note that each such bytecode > stores the static loop depths as an operand, and hence can be armed for > specific loop depths. > > This also adds builtin code that triggers OSR compilation and switches > execution over to optimized code in case compilation succeeds. In case > compilation fails, the bytecode dispatch just continues unhindered. > > R=rmcilroy@chromium.org > TEST=mjsunit/ignition/osr-from-bytecode > BUG=v8:4764 > > Committed: https://crrev.com/a55beb68e0ededb3773affa294a71edc50621458 > Cr-Commit-Position: refs/heads/master@{#38043} TBR=rmcilroy@chromium.org,mstarzinger@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4764 Review-Url: https://codereview.chromium.org/2184553003 Cr-Commit-Position: refs/heads/master@{#38044}

… id:1 of https://codereview.chromium.org/2184553003/ ) Reason for revert: Fix has been landed. Original issue's description: > Revert of [interpreter] Add explicit OSR polling bytecode. (patchset #6 id:100001 of https://codereview.chromium.org/2172233002/ ) > > Reason for revert: > Bunch of breakages. Maybe bad interaction with https://chromium.googlesource.com/v8/v8/+/e520e5da5550f0d1a975e87d6e66a2edecbb0c8e ? > > E.g.: > https://build.chromium.org/p/client.v8/builders/V8%20Linux64/builds/11607 > > Original issue's description: > > [interpreter] Add explicit OSR polling bytecode. > > > > This adds an explicit {OsrPoll} bytecode into every loop header which > > triggers on-stack replacement when armed. Note that each such bytecode > > stores the static loop depths as an operand, and hence can be armed for > > specific loop depths. > > > > This also adds builtin code that triggers OSR compilation and switches > > execution over to optimized code in case compilation succeeds. In case > > compilation fails, the bytecode dispatch just continues unhindered. > > > > R=rmcilroy@chromium.org > > TEST=mjsunit/ignition/osr-from-bytecode > > BUG=v8:4764 > > > > Committed: https://crrev.com/a55beb68e0ededb3773affa294a71edc50621458 > > Cr-Commit-Position: refs/heads/master@{#38043} > > TBR=rmcilroy@chromium.org,mstarzinger@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4764 > > Committed: https://crrev.com/439aa2c6d708bfd95db725bd6f97c4c49bbc51fc > Cr-Commit-Position: refs/heads/master@{#38044} TBR=rmcilroy@chromium.org,machenbach@chromium.org BUG=v8:4764 Review-Url: https://codereview.chromium.org/2184713002 Cr-Commit-Position: refs/heads/master@{#38056}

…(patchset #1 id:1 of https://codereview.chromium.org/2184553003/ ) Port e1ad114 Original commit message: Reason for revert: Fix has been landed. Original issue's description: > Revert of [interpreter] Add explicit OSR polling bytecode. (patchset #6 id:100001 of https://codereview.chromium.org/2172233002/ ) > > Reason for revert: > Bunch of breakages. Maybe bad interaction with https://chromium.googlesource.com/v8/v8/+/e520e5da5550f0d1a975e87d6e66a2edecbb0c8e ? > > E.g.: > https://build.chromium.org/p/client.v8/builders/V8%20Linux64/builds/11607 > > Original issue's description: > > [interpreter] Add explicit OSR polling bytecode. > > > > This adds an explicit {OsrPoll} bytecode into every loop header which > > triggers on-stack replacement when armed. Note that each such bytecode > > stores the static loop depths as an operand, and hence can be armed for > > specific loop depths. > > > > This also adds builtin code that triggers OSR compilation and switches > > execution over to optimized code in case compilation succeeds. In case > > compilation fails, the bytecode dispatch just continues unhindered. > > > > R=rmcilroy@chromium.org > > TEST=mjsunit/ignition/osr-from-bytecode > > BUG=v8:4764 > > > > Committed: https://crrev.com/a55beb68e0ededb3773affa294a71edc50621458 > > Cr-Commit-Position: refs/heads/master@{#38043} > > TBR=rmcilroy@chromium.org,mstarzinger@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4764 > > Committed: https://crrev.com/439aa2c6d708bfd95db725bd6f97c4c49bbc51fc > Cr-Commit-Position: refs/heads/master@{#38044} R=mstarzinger@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:4764 LOG=N Review-Url: https://codereview.chromium.org/2182173002 Cr-Commit-Position: refs/heads/master@{#38063}

…hset #1 id:1 of https://codereview.chromium.org/2184553003/ ). port e1ad114 (r38056) original commit message: Reason for revert: Fix has been landed. Original issue's description: > Revert of [interpreter] Add explicit OSR polling bytecode. (patchset #6 id:100001 of https://codereview.chromium.org/2172233002/ ) > > Reason for revert: > Bunch of breakages. Maybe bad interaction with https://chromium.googlesource.com/v8/v8/+/e520e5da5550f0d1a975e87d6e66a2edecbb0c8e ? > > E.g.: > https://build.chromium.org/p/client.v8/builders/V8%20Linux64/builds/11607 > > Original issue's description: > > [interpreter] Add explicit OSR polling bytecode. > > > > This adds an explicit {OsrPoll} bytecode into every loop header which > > triggers on-stack replacement when armed. Note that each such bytecode > > stores the static loop depths as an operand, and hence can be armed for > > specific loop depths. > > > > This also adds builtin code that triggers OSR compilation and switches > > execution over to optimized code in case compilation succeeds. In case > > compilation fails, the bytecode dispatch just continues unhindered. > > > > R=rmcilroy@chromium.org > > TEST=mjsunit/ignition/osr-from-bytecode > > BUG=v8:4764 > > > > Committed: https://crrev.com/a55beb68e0ededb3773affa294a71edc50621458 > > Cr-Commit-Position: refs/heads/master@{#38043} > > TBR=rmcilroy@chromium.org,mstarzinger@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4764 > > Committed: https://crrev.com/439aa2c6d708bfd95db725bd6f97c4c49bbc51fc > Cr-Commit-Position: refs/heads/master@{#38044} BUG= Review-Url: https://codereview.chromium.org/2190903002 Cr-Commit-Position: refs/heads/master@{#38122}

#6 id:100001 of https://codereview.chromium.org/2187693002/ ) Reason for revert: Sanitizer failures: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/10989/ https://build.chromium.org/p/client.v8/builders/V8%20Mac64%20ASAN/builds/7786/ Original issue's description: > [Tracing] Embed V8 runtime call stats into tracing. > > Currently we have V8 RuntimeCallStats that is independently from tracing when > running d8 with flag --runtime_call_stats. This patch embeds V8 runtime call > stats into tracing, by having a global table of runtime call counters each > isolate, resetting the table each time we enter a top level trace event, and > dumping the table for each top level trace event. This will make trace file more > compat, as well as enable runtime call stats in tracing system. > > This patch adds ~5% overhead to V8 when the category is enabled, we measure the > overhead by running a script when category is enabled. > > BUG=v8:5089 > > Committed: https://crrev.com/d014866173eaa2b548c566217b2c94b1d49385fa > Cr-Commit-Position: refs/heads/master@{#38270} TBR=cbruni@chromium.org,fmeawad@chromium.org,machenbach@chromium.org,bmeurer@chromium.org,adamk@chromium.org,rmcilroy@chromium.org,lpy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5089 Review-Url: https://codereview.chromium.org/2203913004 Cr-Commit-Position: refs/heads/master@{#38275}

…de handler (patchset #6 id:100001 of https://codereview.chromium.org/2190293003/ ) Reason for revert: [Sheriff] Fails on nosnap debug: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/8403 Original issue's description: > [Interpreter] Collect type feedback for 'new' in the bytecode handler > > Collect type feedback in the bytecode handler for 'new' bytecode. The > earlier cl (https://codereview.chromium.org/2153433002/) was reverted > because that implementation did not collect allocation site feedback. > This regressed delta blue by an order of magnitude. This implementation > includes collection of allocation site feedback. > > BUG=v8:4280, v8:4780 > LOG=N > > Committed: https://crrev.com/9d5e6129c4c7f9cbfe81a5fad2a470f219fe137c > Cr-Commit-Position: refs/heads/master@{#38364} TBR=bmeurer@chromium.org,rmcilroy@chromium.org,balazs.kilvady@imgtec.com,mythria@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4280, v8:4780 Review-Url: https://codereview.chromium.org/2212343002 Cr-Commit-Position: refs/heads/master@{#38368}

…arse. (patchset #6 id:100001 of https://codereview.chromium.org/2259633002/ ) Reason for revert: Broke MIPS compile due to an uninitialization warning: https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20builder/builds/3110/steps/compile/logs/stdio Original issue's description: > Blink-compatible serialization of arrays, both dense and sparse. > > The current "dense" format is not expressive enough to distinguish between > an element that is not defined and one that has the value "undefined", > but in this CL the existing behaviour of Blink is used for such cases. > Format changes to fix these issues could be made later on. > > Not included in this CL is compatibility with version 0 arrays. > Those will be implemented in a separate CL. > > BUG=chromium:148757 > > Committed: https://crrev.com/2e000127df2e88e31d352ef70af397741d1f2298 > Cr-Commit-Position: refs/heads/master@{#38729} TBR=jkummerow@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:148757 Review-Url: https://codereview.chromium.org/2255313002 Cr-Commit-Position: refs/heads/master@{#38730}

…chset #6 id:140001 of https://codereview.chromium.org/2210263002/ ) Reason for revert: Tanks octane Original issue's description: > [heap] Improve size profiling for ArrayBuffer tracking > > Eagerly account for retained sizes during ArrayBuffer tracking. Following up on this, > we can now do Scavenges if the amount of memory retained from new space is too large. > > BUG=chromium:621829 > R=jochen@chromium.org,hpayer@chromium.org > > Committed: https://crrev.com/28e13bd6a75c9467dae43043e7b741a1387d5252 > Cr-Commit-Position: refs/heads/master@{#38731} TBR=jochen@chromium.org,hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:621829 Review-Url: https://codereview.chromium.org/2261513003 Cr-Commit-Position: refs/heads/master@{#38739}

…sentations. Revision: 32e7b91 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=hablich@chromium.org BUG= Review-Url: https://codereview.chromium.org/2284543002 Cr-Commit-Position: refs/branch-heads/5.4@{#6} Cr-Branched-From: 5ce2827-refs/heads/5.4.500@{#2} Cr-Branched-From: ad07b49-refs/heads/master@{#38841}

…oject#6 id:120001 of https://codereview.chromium.org/2785293002/ ) Reason for revert: console.toString() should return "[object Object]" Original issue's description: > [inspector] move console to builtins > > What will we get: > - console would be included into snapshot and allow us to reduce time that we spent in contextCreated function (~5 times faster), > - it allows us to make further small improvement of console methods, e.g. we can implement super quick return from console.assert if first argument is true, > - console calls are ~ 15% faster. > > BUG=v8:6175 > R=dgozman@chromium.org > > Review-Url: https://codereview.chromium.org/2785293002 > Cr-Commit-Position: refs/heads/master@{#44353} > Committed: https://chromium.googlesource.com/v8/v8/+/55905f85d63d75aaa9313e51eb7bede754a8e41c TBR=dgozman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:6175 Review-Url: https://codereview.chromium.org/2795003003 Cr-Commit-Position: refs/heads/master@{#44354}

Revision: 8c0c5e8 BUG=chromium:684208,chromium:709753,v8:5267 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true TBR=bmeurer@chromium.org Change-Id: I98d2a7e39892cd186bb8c9a43c6cf87fc6067d85 Reviewed-on: https://chromium-review.googlesource.com/476671 Reviewed-by: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/branch-heads/5.9@{crosswalk-project#6} Cr-Branched-From: fe9bb7e-refs/heads/5.9.211@{crosswalk-project#1} Cr-Branched-From: 70ad237-refs/heads/master@{#44591}

…rame navigates away. Revision: 1c7f839 BUG=chromium:683667 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=verwaest@chromium.org Review-Url: https://codereview.chromium.org/2725153002 . Cr-Commit-Position: refs/branch-heads/5.8@{crosswalk-project#6} Cr-Branched-From: eda659c-refs/heads/5.8.283@{crosswalk-project#1} Cr-Branched-From: 4310cd0-refs/heads/master@{#43429}

V8 profiling patch rebased on Chromuim v34

075f828

darktears added a commit that referenced this pull request Mar 18, 2014

Merge pull request #6 from dp7/master

9f0736d

V8 profiling patch rebased on Chromuim v34

darktears merged commit 9f0736d into crosswalk-project:master Mar 18, 2014

fenghaitao mentioned this pull request Mar 21, 2014

V8 profiling patch rebased on Chromium v34 #9

Closed

huningxin pushed a commit to huningxin/v8-crosswalk that referenced this pull request Mar 25, 2015

Merge pull request crosswalk-project#6 from huningxin/simd-m41-turbofan

36d2bed

Add ia32 support for int32x4 and float64x2

mrunalk pushed a commit that referenced this pull request Aug 10, 2016

Version 5.3.332.4

27543e7

Cr-Commit-Position: refs/branch-heads/5.3@{#6} Cr-Branched-From: 820a23a-refs/heads/5.3.332@{#2} Cr-Branched-From: 37538cb-refs/heads/master@{#37308}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

V8 profiling patch rebased on Chromuim v34 #6

V8 profiling patch rebased on Chromuim v34 #6

dp7 commented Mar 18, 2014

darktears commented Mar 18, 2014

fenghaitao commented Mar 19, 2014

dp7 commented Mar 19, 2014

darktears commented Mar 19, 2014

gramakri commented Mar 19, 2014

darktears commented Mar 19, 2014

dp7 commented Mar 19, 2014

darktears commented Mar 19, 2014

dp7 commented Mar 19, 2014

dp7 commented Mar 19, 2014

V8 profiling patch rebased on Chromuim v34 #6

V8 profiling patch rebased on Chromuim v34 #6

Conversation

dp7 commented Mar 18, 2014

darktears commented Mar 18, 2014

fenghaitao commented Mar 19, 2014

dp7 commented Mar 19, 2014

darktears commented Mar 19, 2014

gramakri commented Mar 19, 2014

darktears commented Mar 19, 2014

dp7 commented Mar 19, 2014

darktears commented Mar 19, 2014

dp7 commented Mar 19, 2014

dp7 commented Mar 19, 2014