This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
[SIMD.js] Fix build failure on arm64 architecture #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapt deoptimizer and lithium to SIMD128 register and data types. BUG=XWALK-2998
|
Testing patch series with huningxin/v8-crosswalk@b5abfa9 as its head.
|
|
@fujunwei, please take a look. Thanks. |
|
Testing patch series with huningxin/v8-crosswalk@8299b0f as its head.
|
|
@rakuco , typo (WALK -> XWALK) was fixed. Please take another look. Thanks. |
|
ping @rakuco . Thanks. |
rakuco
added a commit
that referenced
this pull request
Nov 26, 2014
[SIMD.js] Fix build failure on arm64 architecture
mrunalk
pushed a commit
that referenced
this pull request
Jun 11, 2016
BUG=None TEST=None R=hablich@chromium.org LOG=N NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2007293002 Cr-Commit-Position: refs/branch-heads/5.1@{#60} Cr-Branched-From: 167dc63-refs/heads/5.1.281@{#1} Cr-Branched-From: 03953f5-refs/heads/master@{#35282}
rakuco
pushed a commit
that referenced
this pull request
Sep 21, 2016
rakuco
pushed a commit
that referenced
this pull request
Oct 17, 2016
imreotto
pushed a commit
to tenta-browser/v8-crosswalk
that referenced
this pull request
Sep 4, 2017
…id:1170001 of https://codereview.chromium.org/2371833007/ ) Reason for revert: ASAN breakage, such as https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20ASAN/builds/19111/steps/Check/logs/grow-memory Original issue's description: > [wasm] Initial signal handler > > This is basically the minimum viable signal handler for Wasm bounds checks. > It includes the TLS check and the fine grained instructions checks. These > two checks provide most of the safety for the signal handler. Future CLs will > add code range and data range checks for more robustness. > > The trap handling code and data structures are all in src/trap-handler, with > the code that actually runs in the signal handler confined to > src/trap-handler/signal-handler.cc. > > This changes adds a new V8 API that the embedder should call from a signal > handler that will give V8 the chance to handle the fault first. For hosts that > do not want to implement their own signal handler, we include the option to > install a simple one. This simple handler is also used for the tests. > > When a Wasm module is instantiated, information about each function is passed > to the trap handler, which is used to classify faults. These are removed during > the instance finalizer. > > Several future enhancements are planned before turning this on by default. > Obviously, the additional checks will be added to MaybeHandleFault. We are > also planning to add a two-level CodeObjectData table that is grouped by > isolates to make cleanup easier and also reduce potential for contending on > a single data structure. > > BUG= https://bugs.chromium.org/p/v8/issues/detail?id=5277 > > Review-Url: https://codereview.chromium.org/2371833007 > Cr-Original-Commit-Position: refs/heads/master@{#43523} > Committed: https://chromium.googlesource.com/v8/v8/+/a5af7fe9ee388a636675f4a6872b1d34fa7d1a7a > Review-Url: https://codereview.chromium.org/2371833007 > Cr-Commit-Position: refs/heads/master@{#43755} > Committed: https://chromium.googlesource.com/v8/v8/+/338622d7cae787a63cece1f2e79a8b030023940b TBR=ahaas@chromium.org,bradnelson@google.com,hpayer@chromium.org,jochen@chromium.org,mark@chromium.org,mseaborn@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= https://bugs.chromium.org/p/v8/issues/detail?id=5277 Review-Url: https://codereview.chromium.org/2744383002 Cr-Commit-Position: refs/heads/master@{#43757}
imreotto
pushed a commit
to tenta-browser/v8-crosswalk
that referenced
this pull request
Sep 4, 2017
Cr-Commit-Position: refs/branch-heads/5.9@{crosswalk-project#60}
Cr-Branched-From: fe9bb7e-refs/heads/5.9.211@{crosswalk-project#1}
Cr-Branched-From: 70ad237-refs/heads/master@{#44591}
asifhisam
pushed a commit
to asifhisam/v8-crosswalk
that referenced
this pull request
Sep 9, 2019
Revision: c5c570f NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=hablich@chromium.org BUG=v8:6032 Review-Url: https://codereview.chromium.org/2733333003 Cr-Commit-Position: refs/branch-heads/5.8@{crosswalk-project#60} Cr-Branched-From: eda659c-refs/heads/5.8.283@{crosswalk-project#1} Cr-Branched-From: 4310cd0-refs/heads/master@{#43429}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt deoptimizer and lithium to SIMD128 register and data types.
BUG=XWALK-2998