This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
[SIMD.js] Refactor the simd128 registers in deoptimizer #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only replace double registers with simd128 registers on architectures that support this. Currently they are ia32, x64 and arm.
|
Testing patch series with huningxin/v8-crosswalk@34478f0 as its head.
|
|
@vvavrychuk and @rakuco , please take a look. Thanks! |
|
I'm not familiar with V8's code base, but from your description the idea sounds sane. Is there anyone who could take a look at it from a V8 point of view? |
|
@fujunwei, could you please take a look? Thanks. |
|
I can compile it for mips. Thanks for the change. |
|
LGTM, Thanks. |
|
Thanks for the test and review. I am going to merge it. |
huningxin
added a commit
that referenced
this pull request
Dec 1, 2014
[SIMD.js] Refactor the simd128 registers in deoptimizer
rakuco
pushed a commit
that referenced
this pull request
Sep 21, 2016
rakuco
pushed a commit
that referenced
this pull request
Oct 21, 2016
imreotto
pushed a commit
to tenta-browser/v8-crosswalk
that referenced
this pull request
Sep 4, 2017
Cr-Commit-Position: refs/branch-heads/5.9@{crosswalk-project#62}
Cr-Branched-From: fe9bb7e-refs/heads/5.9.211@{crosswalk-project#1}
Cr-Branched-From: 70ad237-refs/heads/master@{#44591}
asifhisam
pushed a commit
to asifhisam/v8-crosswalk
that referenced
this pull request
Sep 9, 2019
…e.push. Revision: 1fceaf9 BUG=v8:5267,v8:6241 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Change-Id: I7cd3fa5cfb61bcd49e57eba704639943fbd8d220 Reviewed-on: https://chromium-review.googlesource.com/476731 Reviewed-by: Michael Hablich <hablich@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/branch-heads/5.8@{crosswalk-project#62} Cr-Branched-From: eda659c-refs/heads/5.8.283@{crosswalk-project#1} Cr-Branched-From: 4310cd0-refs/heads/master@{#43429}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only replace double registers with simd128 registers on architectures that
support this. Currently they are ia32, x64 and arm.