This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
Fix GPU process crash #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix GPU process crash on "Check failed: policy->PreSandboxHook()". BUG=XWALK-2789
|
Testing patch series with pozdnyakov/chromium-crosswalk@17ac09e as its head.
|
pozdnyakov
pushed a commit
to pozdnyakov/chromium-crosswalk
that referenced
this pull request
Nov 28, 2014
There is a race condition in the current state of the code where in cross-process navigation we swap the existing RenderFrameHost with a new RenderFrameHost. If the existing host sends an IPC message to create a new child frame, it arrives on the IO thread, allocates a routing id based of the existing process (p1) and does a PostTask to the UI thread. If there is a CommitPending event either executing on the UI thread or in the task queue before the task posted from the IO thread, it will end up putting the existing RenderFrameHost in swapped out state (or waiting for swapped out). When the task to create a child frame is executed after that, it creates a new RenderFrameHost, but it uses the "current" process (p2), which is different than the process that sent the message (p1). This manifests sometimes as adding duplicate routing ids to RenderProcessHost and is in general really bad bug. BUG=415059, 423691, 381990 Review URL: https://codereview.chromium.org/642813007 Cr-Commit-Position: refs/heads/master@{#299939} (cherry picked from commit dcdb02f) R=creis@chromium.org Review URL: https://codereview.chromium.org/670793002 Cr-Commit-Position: refs/branch-heads/2171@{crosswalk-project#215} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
|
@kenchris @darktears @rakuco PTAL |
|
don't worry about the Android failure, it's V8 master that's currently broken (since we don't have DEPS.xwalk here we just build what's in master) and being fixed in crosswalk-project/v8-crosswalk#62 |
|
the change itself lgtm |
|
LGTM, thanks for fixing. |
|
Remember to roll DEPS.xwalk. |
mrunalk
pushed a commit
that referenced
this pull request
Jan 27, 2015
Making this lower case will hopefully get rid of the TC exception
generated by similar but not identical strings. As this is in the example
text we don't anticipate this will cause any issues, but we should follow up.
R=matthewyuan@google.com
BUG=438717
Cr-Commit-Position: refs/branch-heads/2214@{#215}
Cr-Branched-From: 03655fd-refs/heads/master@{#303346}
rakuco
pushed a commit
that referenced
this pull request
Feb 27, 2015
Bad things happen if you delete the profile that started the Metro process (at best, you crash), since relaunching Metro with a new user is not supported. Hiding the button selectively depending on the profile selected is a bit weird, so in Metro mode, hide it for all profiles. BUG=448352 TBR=noms@chromium.org Review URL: https://codereview.chromium.org/863063002 Cr-Commit-Position: refs/heads/master@{#313449} (cherry picked from commit 9a4fcc9) Conflicts: chrome/browser/ui/webui/signin/user_manager_screen_handler.cc Review URL: https://codereview.chromium.org/887203003 Cr-Commit-Position: refs/branch-heads/2272@{#215} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
rakuco
pushed a commit
that referenced
this pull request
Apr 30, 2015
Fix the issue that the bottom bar of wallpaper picker application was chopped. This issue is caused by the CL that upgraded src/third_party/WebKit: https://codereview.chromium.org/1054333002. Not quite sure why it would cause this misalignment issue. This CL did a fix of the issue by fixing the height of image picker area. BUG=475107 TEST=Manually test TBR=bshe@chromium.org, xdai@chromium.org Review URL: https://codereview.chromium.org/1070273002 Cr-Commit-Position: refs/heads/master@{#324734} (cherry picked from commit e7247e6) Review URL: https://codereview.chromium.org/1092933007 Cr-Commit-Position: refs/branch-heads/2357@{#215} Cr-Branched-From: 59d4494-refs/heads/master@{#323860}
mrunalk
pushed a commit
that referenced
this pull request
Sep 22, 2015
…rg/1189033002/patch/20001/30002 made the change in such a way that current URL is not sent to GWS. More details can be found in the bug. BUG=529447 Review URL: https://codereview.chromium.org/1305163010 TBR=pkasting@chromium.org Cr-Commit-Position: refs/heads/master@{#347852} (cherry picked from commit 830d6fa) Review URL: https://codereview.chromium.org/1307743013 . Cr-Commit-Position: refs/branch-heads/2490@{#215} Cr-Branched-From: 7790a35-refs/heads/master@{#344925}
mrunalk
pushed a commit
that referenced
this pull request
Dec 18, 2015
Reader Mode does not support any of the functionality found in the app menu (find in page, bookmark, etc), therefore, the menu should be disabled when the Reader Mode is open. This change primarily affects devices with a hardware menu button. BUG=556368, 556366 Review URL: https://codereview.chromium.org/1458953003 Cr-Commit-Position: refs/heads/master@{#362742} (cherry picked from commit ac2fd2a) Review URL: https://codereview.chromium.org/1500713002 . Cr-Commit-Position: refs/branch-heads/2564@{#215} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
rakuco
pushed a commit
that referenced
this pull request
Mar 3, 2016
BUG=579249 Review URL: https://codereview.chromium.org/1625633003 Cr-Commit-Position: refs/heads/master@{#371818} (cherry picked from commit f932e39) Review URL: https://codereview.chromium.org/1652053003 . Cr-Commit-Position: refs/branch-heads/2623@{#215} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
May 17, 2016
During text selection, AutoscrollController calls scrollIntoView continuously to make the scroll position follow the selection. This had the side effect of resetting ScrollAnimator before it could finish a main-thread smooth scroll. There are early returns for zero-delta scrolls in FrameView::setScrollPosition and RootFrameViewport::distributeScrollBetweenViewports, but scrollIntoView's conversion of fractional scroll offsets to LayoutUnits resulted in a very small (< 1px) non-zero scroll delta. We now avoid this by directly comparing the input and output of getRectToExpose and skipping the unneeded calls to setScrollPosition. BUG=591918 Review URL: https://codereview.chromium.org/1775213002 Cr-Commit-Position: refs/heads/master@{#380162} (cherry picked from commit 67a7b9d) Review URL: https://codereview.chromium.org/1797623003 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#215} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Oct 9, 2016
Having to call VRS::Start(), wait for VRS::RC::Render(), and then queuing a VRS::Stop() across multiple threads just to paint a single frame is not desirable... so remove a bunch of TODOs and rename PaintFrameUsingOldRenderingPath() to PaintSingleFrame(). This allows a lot of simplification in VideoRendererImpl and avoids Chromecast from having to pick up this complexity. It also will likely resolve nullptr crashes due having two sink startup points. BUG=614099, 611714 TEST=existing unittests pass. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/1996763002 Cr-Commit-Position: refs/heads/master@{#395138} (cherry picked from commit e9c89e9) Review URL: https://codereview.chromium.org/2039443003 . Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#215} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
|ToPositionInFlatTree(pos_in_dom)| returned invalid PositionInFlatTree when |pos_in_dom| is not settled in flat tree. This patch checks validity of returned PositionInFlatTree. Bug: 759364 Change-Id: I859e5cfb57a40a9b1f7c1e39a911707a4959f60c Reviewed-on: https://chromium-review.googlesource.com/656778 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#500806}(cherry picked from commit 8a45da3) Reviewed-on: https://chromium-review.googlesource.com/666364 Reviewed-by: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#215} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix GPU process crash on "Check failed: policy->PreSandboxHook()".
Related to: XWALK-2789