V8 profiling patch re-based on Chromium v34 #7

dp7 · 2014-03-19T13:13:40Z

This is the same patch as we already applied for Chromium v32 with minor differences in Logger::LogCodeObjects() and Logger::LogCompiledFunctions() from log.cc.
This patch enables CPU profiling feature for XDK.

P.S.
This patch addresses the spelling and compilation issues (not detected last time because -Wall compiler flag was out of configuration).

darktears · 2014-03-19T16:26:44Z

@kenchris anything?

rakuco · 2014-03-19T16:42:35Z

@fenghaitao: ^

V8 profiling patch re-based on Chromium v34

darktears · 2014-03-19T19:42:18Z

if @fenghaitao have some comments we can address them in a separate commit. We need that patch before selecting the branching point.

darktears · 2014-03-19T19:52:10Z

http://wrt-build.sh.intel.com/buildbot/builders/V8%20Linux%20-%20builder/builds/16/steps/compile/logs/stdio :(

darktears · 2014-03-19T19:52:30Z

@dp7 gosh

fenghaitao · 2014-03-19T23:54:52Z

src/third_party/xdk/xdk-types.h

+#define XDK_LOG(...) v8engine::PrintF(__VA_ARGS__)
+#else
+#define XDK_LOG(...)
+#endif


You could make this a function like:
void XDKLog(const char* msg, ...) {
#if DEBUG
va_list arguments;
va_start(arguments, msg);
OS::VPrint(msg, arguments);
va_end(arguments);
#endif
}

Merged a4124b3 Map -0 to integer 0 for typed array constructors. BUG=chromium:447756 LOG=N R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/846253002 Cr-Commit-Position: refs/branch-heads/4.1@{#7} Cr-Branched-From: 2e08d2a-refs/heads/candidates@{#25353}

…ps://codereview.chromium.org/975463002/) Reason for revert: Arm buildre complains again (why v8_linux_arm_dbg does not complain?) Original issue's description: > Implement subclassing Arrays. > > R=mvstanton@chromium.org,arv@chromium.org,rossberg@chromium.org > BUG=v8:3930 > LOG=Y > > Committed: https://crrev.com/6898da1a28d64d1fb2962804ba566f6d618ffc70 > Cr-Commit-Position: refs/heads/master@{#26960} > > Committed: https://crrev.com/8d29cc11a56e77297792fe100986a80b65de0051 > Cr-Commit-Position: refs/heads/master@{#26963} TBR=arv@chromium.org,mvstanton@chromium.org,rossberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3930 Review URL: https://codereview.chromium.org/974963002 Cr-Commit-Position: refs/heads/master@{#26965}

Merged afb2706 Limit size of first page based on serialized data. BUG=chromium:453111 LOG=N TBR=hpayer@chromium.org Review URL: https://codereview.chromium.org/998993002 Cr-Commit-Position: refs/branch-heads/4.2@{crosswalk-project#7} Cr-Branched-From: 3dfd929-refs/heads/4.2.77@{crosswalk-project#2} Cr-Branched-From: e011092-refs/heads/master@{#26757}

Add check API

Merged 536b7cf Set the default compiler for X87 to GCC. R=jkummerow@chromium.org BUG= Review URL: https://codereview.chromium.org/1078823002 Cr-Commit-Position: refs/branch-heads/4.3@{#7} Cr-Branched-From: f5c0a23-refs/heads/4.3.61@{#1} Cr-Branched-From: 0a7d4f4-refs/heads/master@{#27508}

…d:120001 of https://codereview.chromium.org/376623004/) Reason for revert: [Sheriff] This causes test failures on mac gc stress: http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/1027 Original issue's description: > [es6] implement Array.prototype.copyWithin() > > https://people.mozilla.org/~jorendorff/es6-draft.html#sec-array.prototype.copywithin > > BUG=v8:4039 > R=adamk@chromium.org > LOG=N TBR=dslomov@chromium.org,rossberg@chromium.org,adamk@chromium.org,caitpotter88@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4039 Review URL: https://codereview.chromium.org/1084183004 Cr-Commit-Position: refs/heads/master@{#27984}

…al, O.preventExtensions) (patchset #7 id:140001 of https://codereview.chromium.org/1011823003/) Reason for revert: [Sheriff] breaks mac gc stress: http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/1029 Original issue's description: > [es6] don't throw if argument is non-object (O.freeze, O.seal, O.preventExtensions) > > BUG=v8:3965, v8:3966 > R=arv@chromium.org > LOG=N > > Committed: https://crrev.com/b09c048f693d280052ac63c7d6b3baf27b3bf271 > Cr-Commit-Position: refs/heads/master@{#27985} TBR=arv@chromium.org,caitpotter88@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3965, v8:3966 Review URL: https://codereview.chromium.org/1103473003 Cr-Commit-Position: refs/heads/master@{#27990}

id:110001 of https://codereview.chromium.org/1024063002/) Reason for revert: [Sheriff] Breaks mac gc stress: http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/1024 Original issue's description: > [strong] checking of this & super in constructors > > R=dslomov@chromium.org, marja@chromium.org > BUG=v8:3956 > LOG=N > > Enforces for constructors that > - the only use of 'super' is the super constructor call > - the only use of 'this' is a property assignment > - both of these must happen at the top-level of the body > - 'this' may only be assigned after the 'super' call > - 'return' may only be used after the last assignment to 'this' > > Not yet working for arrow functions (there might be deeper bugs with those). > > Committed: https://crrev.com/580d66bcda66220d2f3062ac58daf925436df74c > Cr-Commit-Position: refs/heads/master@{#27977} TBR=dslomov@chromium.org,marja@chromium.org,conradw@chromium.org,rossberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3956 Review URL: https://codereview.chromium.org/1105453002 Cr-Commit-Position: refs/heads/master@{#27991}

…chset #1 id:1 of https://codereview.chromium.org/1084183004/) Reason for revert: Check if this CL fails independently of https://chromium.googlesource.com/v8/v8/+/580d66bcda66220d2f3062ac58daf925436df74c Original issue's description: > Revert of [es6] implement Array.prototype.copyWithin() (patchset #7 id:120001 of https://codereview.chromium.org/376623004/) > > Reason for revert: > [Sheriff] This causes test failures on mac gc stress: > http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/1027 > > Original issue's description: > > [es6] implement Array.prototype.copyWithin() > > > > https://people.mozilla.org/~jorendorff/es6-draft.html#sec-array.prototype.copywithin > > > > BUG=v8:4039 > > R=adamk@chromium.org > > LOG=N > > TBR=dslomov@chromium.org,rossberg@chromium.org,adamk@chromium.org,caitpotter88@gmail.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4039 > > Committed: https://crrev.com/9283fc89710e59445bdc4479454fba97ab9ebdd7 > Cr-Commit-Position: refs/heads/master@{#27984} TBR=dslomov@chromium.org,rossberg@chromium.org,adamk@chromium.org,caitpotter88@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4039 Review URL: https://codereview.chromium.org/1072193005 Cr-Commit-Position: refs/heads/master@{#27997}

…opertyCell. (patchset #7 id:120001 of https://codereview.chromium.org/1092043002/) Reason for revert: MAC GCSTRESS failure on new test. Original issue's description: > Protect the emptiness of Array prototype elements with a PropertyCell. > > Not just emptiness, but also a particular structure. > > BUG=v8:4044 > LOG=N TBR=jkummerow@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4044 Review URL: https://codereview.chromium.org/1099203004 Cr-Commit-Position: refs/heads/master@{#27998}

…eeze, O.seal, O.preventExtensions) (patchset #1 id:1 of https://codereview.chromium.org/1103473003/) Reason for revert: This was probably an infrastructure problem caused by the mac ninja/goma switch. Original issue's description: > Revert of [es6] don't throw if argument is non-object (O.freeze, O.seal, O.preventExtensions) (patchset #7 id:140001 of https://codereview.chromium.org/1011823003/) > > Reason for revert: > [Sheriff] breaks mac gc stress: > http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/1029 > > Original issue's description: > > [es6] don't throw if argument is non-object (O.freeze, O.seal, O.preventExtensions) > > > > BUG=v8:3965, v8:3966 > > R=arv@chromium.org > > LOG=N > > > > Committed: https://crrev.com/b09c048f693d280052ac63c7d6b3baf27b3bf271 > > Cr-Commit-Position: refs/heads/master@{#27985} > > TBR=arv@chromium.org,caitpotter88@gmail.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:3965, v8:3966 TBR=arv@chromium.org,caitpotter88@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3965, v8:3966 Review URL: https://codereview.chromium.org/1098243002 Cr-Commit-Position: refs/heads/master@{#27999}

… with a PropertyCell. (patchset #1 id:1 of https://codereview.chromium.org/1099203004/) Reason for revert: This was probably an infrastructure problem caused by the mac ninja/goma switch. Original issue's description: > Revert of Protect the emptiness of Array prototype elements with a PropertyCell. (patchset #7 id:120001 of https://codereview.chromium.org/1092043002/) > > Reason for revert: > MAC GCSTRESS failure on new test. > > Original issue's description: > > Protect the emptiness of Array prototype elements with a PropertyCell. > > > > Not just emptiness, but also a particular structure. > > > > BUG=v8:4044 > > LOG=N > > TBR=jkummerow@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4044 TBR=jkummerow@chromium.org,mvstanton@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4044 Review URL: https://codereview.chromium.org/1052253003 Cr-Commit-Position: refs/heads/master@{#28000}

… (patchset #1 id:1 of https://codereview.chromium.org/1105453002/) Reason for revert: Was an infrastructure problem. Original issue's description: > Revert of [strong] checking of this & super in constructors (patchset #7 id:110001 of https://codereview.chromium.org/1024063002/) > > Reason for revert: > [Sheriff] Breaks mac gc stress: > http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/1024 > > Original issue's description: > > [strong] checking of this & super in constructors > > > > R=dslomov@chromium.org, marja@chromium.org > > BUG=v8:3956 > > LOG=N > > > > Enforces for constructors that > > - the only use of 'super' is the super constructor call > > - the only use of 'this' is a property assignment > > - both of these must happen at the top-level of the body > > - 'this' may only be assigned after the 'super' call > > - 'return' may only be used after the last assignment to 'this' > > > > Not yet working for arrow functions (there might be deeper bugs with those). > > > > Committed: https://crrev.com/580d66bcda66220d2f3062ac58daf925436df74c > > Cr-Commit-Position: refs/heads/master@{#27977} > > TBR=dslomov@chromium.org,marja@chromium.org,conradw@chromium.org,rossberg@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:3956 TBR=dslomov@chromium.org,marja@chromium.org,conradw@chromium.org,rossberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3956 Review URL: https://codereview.chromium.org/1073103004 Cr-Commit-Position: refs/heads/master@{#28001}

Merged 7b24219 Fix lookup iterator checks in GetRealNamedProperty* methods BUG=v8:4143 LOG=N R=hablich@chromium.org TBR=hablich@chromium.org Review URL: https://codereview.chromium.org/1161953002 Cr-Commit-Position: refs/branch-heads/4.4@{crosswalk-project#7} Cr-Branched-From: 2e4c550-refs/heads/4.4.63@{#1} Cr-Branched-From: 0208b8e-refs/heads/master@{#28333}

…d:120001 of https://codereview.chromium.org/1136553006/) Reason for revert: breaks build Original issue's description: > Implement SharedArrayBuffer. > > This adds a new external type (v8::SharedArrayBuffer) that uses a JSArrayBuffer under the hood. It can be distinguished from an ArrayBuffer by the newly-added is_shared() bit. > > Currently there is no difference in functionality between a SharedArrayBuffer and an ArrayBuffer. However, a future CL will add the Atomics API, which is only available on an SharedArrayBuffer. All non-atomic accesses are identical to ArrayBuffer accesses. > > BUG= > > Committed: https://crrev.com/57170bff7baf341c666252a7f6a49e9c08d51263 > Cr-Commit-Position: refs/heads/master@{#28588} TBR=jarin@chromium.org,jochen@chromium.org,binji@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1149203003 Cr-Commit-Position: refs/heads/master@{#28589}

…chset crosswalk-project#7 id:120001 of https://codereview.chromium.org/1179893002/) Reason for revert: [Sheriff] Breaks gc mole: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gcmole/builds/2435 Original issue's description: > Add script context with context-allocated "const this" > > R=rossberg@chromium.org > LOG=N > BUG=498811 > > Committed: https://crrev.com/fa32d461c16a053cc6d48d3fb326016bc2765765 > Cr-Commit-Position: refs/heads/master@{#28988} TBR=rossberg@chromium.org,mstarzinger@chromium.org,wingo@igalia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=498811 Review URL: https://codereview.chromium.org/1180043004 Cr-Commit-Position: refs/heads/master@{#28992}

…hset #7 id:120001 of https://codereview.chromium.org/1189743003/) Reason for revert: [Sheriff] Breaks tsan: http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/4392 Original issue's description: > [destructuring] Implement parameter pattern matching. > > Scoping for initializers is yet incorrect. Defaults are not supported. > > R=arv@chromium.org,rossberg@chromium.org > BUG=v8:811 > LOG=N > > Committed: https://crrev.com/42f30f4ded2b1ca0c4caa7639e6206e93c78ee70 > Cr-Commit-Position: refs/heads/master@{#29184} TBR=arv@chromium.org,rossberg@chromium.org,caitpotter88@gmail.com,wingo@igalia.com,dslomov@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:811 Review URL: https://codereview.chromium.org/1195163007 Cr-Commit-Position: refs/heads/master@{#29188}

Merged 2798e11 PPC: [turbofan] Add TruncationMode for TruncateFloat64ToInt32. R=michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1239513003 . Cr-Commit-Position: refs/branch-heads/4.5@{#7} Cr-Branched-From: 7f21153-refs/heads/4.5.103@{#1} Cr-Branched-From: 4b38c15-refs/heads/master@{#29527}

Merged 2454469 Merged e642fde Message formatting: handle unexpected case of failing property lookup. Deserializer: flush code cache while code pointers are still valid. BUG=chromium:523308,chromium:523453 LOG=N TBR=hablich@chromium.org Review URL: https://codereview.chromium.org/1313513004 . Cr-Commit-Position: refs/branch-heads/4.6@{#7} Cr-Branched-From: 24d34a8-refs/heads/4.6.85@{#1} Cr-Branched-From: 8f44118-refs/heads/master@{#30256}

… id:120001 of https://codereview.chromium.org/1293283002/ ) Reason for revert: Breaks cctest/test-cpu-profiler/SourceLocation on nosnap Original issue's description: > Add a separate scope for switch > > The ES2015 specification for switch statements 13.12.11 specifies that > they get their own lexical scope. This patch introduces such a scope > through a complex desugaring in terms of blocks, done so that Crankshaft > does not have to be updated to support multiple constructs providing > scopes. > > BUG=v8:4377 > LOG=Y > R=adamk > > Committed: https://crrev.com/9edbc1f21eb1050cabbe3b8bc9aebf89ada7ebd7 > Cr-Commit-Position: refs/heads/master@{#30314} TBR=adamk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4377 Review URL: https://codereview.chromium.org/1309043004 Cr-Commit-Position: refs/heads/master@{#30316}

…type.push (patchset crosswalk-project#1 id:1 of https://codereview.chromium.org/1418093007/ ) Reason for revert: The test failure was unrelated; relanding. Original issue's description: > Revert of Check that array length stays a safe integer in Array.prototype.push (patchset crosswalk-project#7 id:120001 of https://codereview.chromium.org/1428483002/ ) > > Reason for revert: > Caused for-in-opt test to fail > > Original issue's description: > > Check that array length stays a safe integer in Array.prototype.push > > > > This patch adds a check in Array.prototype.push to assert that the new > > length does not become greater than 2**53-1. Such a length would be > > dangerous because integer arithmetic becomes imprecise after the > > boundary. The check is also required by a test262 test. > > > > R=adamk > > LOG=Y > > BUG=v8:3087 > > > > Committed: https://crrev.com/e68adf4548dd101dc08fcbff14444152fb1b7fe7 > > Cr-Commit-Position: refs/heads/master@{#31588} > > TBR=adamk@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:3087 > > Committed: https://crrev.com/78abedb94431a233842fcb2f7a910805a05bed09 > Cr-Commit-Position: refs/heads/master@{#31590} TBR=adamk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3087 Review URL: https://codereview.chromium.org/1424823005 Cr-Commit-Position: refs/heads/master@{#31610}

BUG=chromium:555127,v8:3502 R=adamk@chromium.org NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1469733007 Cr-Commit-Position: refs/branch-heads/4.8@{#7} Cr-Branched-From: 10449d4-refs/heads/4.8.271@{#1} Cr-Branched-From: 2ebd5fc-refs/heads/master@{#31941}

…patchset crosswalk-project#7 id:120001 of https://codereview.chromium.org/1463803002/ ) Reason for revert: [Sheriff] Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/3074 Original issue's description: > [debugger] flood function for stepping before calling it. > > R=verwaest@chromium.org > > Committed: https://crrev.com/93eb633214e0f97bf70ae30d2a07b7fbbaa78266 > Cr-Commit-Position: refs/heads/master@{#32285} TBR=verwaest@chromium.org,mstarzinger@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1474943005 Cr-Commit-Position: refs/heads/master@{#32299}

crosswalk-project#7 id:120001 of https://codereview.chromium.org/1375253002/ ) Reason for revert: Does not compile https://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20debug%20builder/builds/6870/steps/compile/logs/stdio Original issue's description: > [turbofan] Instruction scheduler for Turbofan. > > Implement machine instruction scheduling after instruction selection. > > Currently only works for arm64. > > R=danno@chromium.org, bmeurer@chromium.org, titzer@chromium.org > > Committed: https://crrev.com/e11bba3acd5188f0e12686b6fcf3e0ab22989216 > Cr-Commit-Position: refs/heads/master@{#32858} TBR=jarin@chromium.org,bmeurer@chromium.org,baptiste.afsa@arm.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1526913002 Cr-Commit-Position: refs/heads/master@{#32860}

…hset crosswalk-project#7 id:120001 of https://codereview.chromium.org/1551443002/ ) Reason for revert: Causes frequent crashes in Canary: chromium:537816 Original issue's description: > Ship ES2015 sloppy-mode function hoisting, let, class > > This patch doesn't ship all features of ES2015 variable/scoping > changes, notably omitting the removal of legacy const. I think > function hoisting, let and class in sloppy mode can stand to > themselves as a package, and the legacy const change is much > riskier and more likely to be reverted, so my intention is to > pursue those as a separate, follow-on patch. > > R=adamk@chromium.org > BUG=v8:4285,v8:3305 > LOG=Y > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/fcff8588a5a01587643d6c2507c7b882c78a2957 > Cr-Commit-Position: refs/heads/master@{#33133} TBR=adamk@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:4285,v8:3305,chromium:537816 LOG=Y Review URL: https://codereview.chromium.org/1565263002 Cr-Commit-Position: refs/heads/master@{#33162}

…hset crosswalk-project#1 id:1 of https://codereview.chromium.org/1565263002/ ) Reason for revert: Crash fixed by https://codereview.chromium.org/1564923007 Original issue's description: > Revert of Ship ES2015 sloppy-mode function hoisting, let, class (patchset crosswalk-project#7 id:120001 of https://codereview.chromium.org/1551443002/ ) > > Reason for revert: > Causes frequent crashes in Canary: chromium:537816 > > Original issue's description: > > Ship ES2015 sloppy-mode function hoisting, let, class > > > > This patch doesn't ship all features of ES2015 variable/scoping > > changes, notably omitting the removal of legacy const. I think > > function hoisting, let and class in sloppy mode can stand to > > themselves as a package, and the legacy const change is much > > riskier and more likely to be reverted, so my intention is to > > pursue those as a separate, follow-on patch. > > > > R=adamk@chromium.org > > BUG=v8:4285,v8:3305 > > LOG=Y > > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel > > > > Committed: https://crrev.com/fcff8588a5a01587643d6c2507c7b882c78a2957 > > Cr-Commit-Position: refs/heads/master@{#33133} > > TBR=adamk@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=v8:4285,v8:3305,chromium:537816 > LOG=Y > > Committed: https://crrev.com/adac5956c6216056a211cfaa460a00ac1500d8f8 > Cr-Commit-Position: refs/heads/master@{#33162} TBR=adamk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4285,v8:3305,chromium:537816 Review URL: https://codereview.chromium.org/1571793002 Cr-Commit-Position: refs/heads/master@{#33189}

Merged ec30425 [proxy] Reload the initial map after prototype lookup on constructable Proxy. BUG=chromium:578039 LOG=N R=hablich@chromium.org NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1602063005 Cr-Commit-Position: refs/branch-heads/4.9@{crosswalk-project#7} Cr-Branched-From: 2fea296-refs/heads/4.9.385@{crosswalk-project#1} Cr-Branched-From: 0c1430a-refs/heads/master@{#33306}

…n't delete an element. (patchset #7 id:220001 of https://codereview.chromium.org/1587073003/ ) Reason for revert: [Sheriff] Breaks layout tests. Please fix upstream. https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/4077 Original issue's description: > Array length reduction should throw in strict mode if it can't delete an element. > > When accessor getter callback is called the v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, since according to ES6 there's no difference between strict and non-strict property loads. For the setter case the v8::PropertyCallbackInfo::ShouldThrowOnError() returns true if the property is set in strict context. > > Interceptors follow same idea: for getter, enumerator and query callbacks the v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, and for setter and deleter callback the v8::PropertyCallbackInfo::ShouldThrowOnError() returns true in strict context. > > This CL also cleans up the CallApiGetterStub and removes bogus asserts from [arm] Push(reg1, reg2, ..., regN) that prevented from pushing a set of registers containing duplicates. > > BUG=v8:4267 > LOG=Y > > Committed: https://crrev.com/1d3e837fcbbd9d9fd5e72dfe85dfd47c025f3c9f > Cr-Commit-Position: refs/heads/master@{#33438} TBR=verwaest@chromium.org,ishell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4267 Review URL: https://codereview.chromium.org/1611313003 Cr-Commit-Position: refs/heads/master@{#33444}

…120001 of https://codereview.chromium.org/1681283004/ ) Reason for revert: [Sheriff] Breaks android runs. Will look later why. Original issue's description: > [tools] add --pretty switch to run_perf.py > > This CL improves running our internal benchmarks locally by adding the > --pretty option to tools/run_perf.py. With the flag enabled we print > the run-time of each benchmark directly and avoid the json output at > the end. > > NOTRY=true > > Committed: https://crrev.com/83f69507ab1b9380b56758b747d4f3fabc849e49 > Cr-Commit-Position: refs/heads/master@{#33981} TBR=cbruni@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1696293002 Cr-Commit-Position: refs/heads/master@{#34017}

Merged 7bc1577 Fix iterator (std::vector) invalidation during sampling heap profile retrieval R=hablich@chromium.org BUG=v8:4790 NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1740973005 Cr-Commit-Position: refs/branch-heads/5.0@{#7} Cr-Branched-From: ad16e6c-refs/heads/5.0.71@{#1} Cr-Branched-From: bd9df50-refs/heads/master@{#34215}

…id:200001 of https://codereview.chromium.org/1780043004/ ) Reason for revert: [Sheriff] Leads to mac gc stress crashes: https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/4975 Original issue's description: > [crankshaft] Fixing ES6 tail call elimination. > > In case when F inlined normal call to G which tail calls H we should not write translation for G for the tail call site. > Otherwise we will see G in a stack trace inside H. > > This CL also enables all existing tests related to ES6 tail call elimination. > > TBR=bmeurer@chromium.org > BUG=v8:4698 > LOG=N > > Committed: https://crrev.com/689980f7d4dfd4c29492f616d7b616b86ec9af91 > Cr-Commit-Position: refs/heads/master@{#34830} TBR=mstarzinger@chromium.org,ishell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4698 Review URL: https://codereview.chromium.org/1814433002 Cr-Commit-Position: refs/heads/master@{#34835}

… id:120001 of https://codereview.chromium.org/1812753004/ ) Reason for revert: [Sheriff] Something seems to leak: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20ASAN/builds/10838 I don't see the direct connection to this CL though... Original issue's description: > [elements] Minor hardening and cleanup of concat > > BUG= > > Committed: https://crrev.com/b98b3fbbe3dd14548cb356339f52403c07ef33f4 > Cr-Commit-Position: refs/heads/master@{#35027} TBR=jkummerow@chromium.org,cbruni@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1825363002 Cr-Commit-Position: refs/heads/master@{#35028}

… id:1 of https://codereview.chromium.org/1825363002/ ) Reason for revert: Test disabled. See: https://codereview.chromium.org/1830583002/ Original issue's description: > Revert of [elements] Minor hardening and cleanup of concat (patchset #7 id:120001 of https://codereview.chromium.org/1812753004/ ) > > Reason for revert: > [Sheriff] Something seems to leak: > https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20ASAN/builds/10838 > > I don't see the direct connection to this CL though... > > Original issue's description: > > [elements] Minor hardening and cleanup of concat > > > > BUG= > > > > Committed: https://crrev.com/b98b3fbbe3dd14548cb356339f52403c07ef33f4 > > Cr-Commit-Position: refs/heads/master@{#35027} > > TBR=jkummerow@chromium.org,cbruni@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://crrev.com/d30d861a0cb0da11efd3b30eb3d03fbe56b4ba23 > Cr-Commit-Position: refs/heads/master@{#35028} TBR=jkummerow@chromium.org,cbruni@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. BUG= Review URL: https://codereview.chromium.org/1827573003 Cr-Commit-Position: refs/heads/master@{#35038}

Merged 9478356 Fix representation issue in FastArrayPushStub BUG=chromuim:599089 LOG=N R=cbruni@chromium.org Review URL: https://codereview.chromium.org/1881433002 . Cr-Commit-Position: refs/branch-heads/5.1@{#7} Cr-Branched-From: 167dc63-refs/heads/5.1.281@{#1} Cr-Branched-From: 03953f5-refs/heads/master@{#35282}

…id:140001 of https://codereview.chromium.org/1838283003/ ) Reason for revert: Makes some WebGL tests flaky: https://codereview.chromium.org/1866373002/ Bisection on tryserver shows this as the culprit. Local repro unfortunately does not work. Original issue's description: > Migrate FastCloneShallowObjectStub to TurboFan > > BUG= > > Committed: https://crrev.com/4c2b04542f263b2679194f9fb75672ebbe72b924 > Cr-Commit-Position: refs/heads/master@{#35330} TBR=bmeurer@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Review URL: https://codereview.chromium.org/1875683002 Cr-Commit-Position: refs/heads/master@{#35353}

…ure creation. (patchset #7 id:120001 of https://codereview.chromium.org/1670143002/ ) Reason for revert: Blocks roll. See https://codereview.chromium.org/1877003002/ for detailed messages. You should be able to repro this with Linux ASAN. Original issue's description: > Visit the Optimized Code Map on first call rather than closure creation. > > This is useful for escape analysis, and helps upcoming changes to > type feedback gathering. > > BUG= > > Committed: https://crrev.com/9336f4cc6d25d39a128176679a70dbd13a6d946e > Cr-Commit-Position: refs/heads/master@{#35395} TBR=mstarzinger@chromium.org,bmeurer@chromium.org,mvstanton@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1878063004 Cr-Commit-Position: refs/heads/master@{#35404}

…s (patchset #7 id:130001 of https://codereview.chromium.org/1881423003/ ) Reason for revert: Breaks: https://uberchromegw.corp.google.com/i/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug/builds/20 RecordMigratedSlotVisitor is not safe to use on code pages. Original issue's description: > [heap] Better integrate handling of aborted compaction pages > > - Get rid of fixing up pointers on the main thread > - Get rid of sweeping on the main thread > > Instead: > - Record (and process afterwards) slots in parallel > - Add the pages to the concurrent sweeper as pointers have already been fixed > > BUG=chromium:581412 > LOG=N > TEST=cctest/test-compaction/* > > Committed: https://crrev.com/2e4f57774d4993f9f98332d3b2469280ee10beca > Cr-Commit-Position: refs/heads/master@{#35451} TBR=hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:581412 Review URL: https://codereview.chromium.org/1890553002 Cr-Commit-Position: refs/heads/master@{#35454}

…200001 of https://codereview.chromium.org/1936233002/ ) Reason for revert: Breaks readonly test https://uberchromegw.corp.google.com/i/client.v8/builders/V8%20Linux/builds/10121 Original issue's description: > [heap] Fine-grained JSArrayBuffer tracking > > Track based on JSArrayBuffer addresses instead of the attached backing store. > This way we can later on iterate buffers on a single page. > > BUG=chromium:581412 > LOG=N > R=jochen@chromium.org, hpayer@chromium.org > > Committed: https://crrev.com/4cdf71e2d07c038d7af84e41c6e6d0093af0f0de > Cr-Commit-Position: refs/heads/master@{#36140} TBR=hpayer@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:581412 Review-Url: https://codereview.chromium.org/1961403002 Cr-Commit-Position: refs/heads/master@{#36143}

Merged ca266e7 [arm] Make CEntryStub's handling of triple return values more robust. BUG=chromium:611885 LOG=N R=rmcilroy@chromium.org Review URL: https://codereview.chromium.org/2004013002 . Cr-Commit-Position: refs/branch-heads/5.2@{#7} Cr-Branched-From: 2cd36d6-refs/heads/5.2.361@{#1} Cr-Branched-From: 3fef34e-refs/heads/master@{#36332}

…view.chromium.org/2011853002/ ) Reason for revert: Still http://crbug.com/615890 Original issue's description: > [gn] Add unittests > > BUG=chromium:474921 > NOTRY=true > > Committed: https://crrev.com/67e549ec5b34ad02506abb2720c6a0851ae31f5e > Cr-Commit-Position: refs/heads/master@{#36510} > > Committed: https://crrev.com/143b3d167d7014525d049d3ab53c73cf2592243c > Cr-Commit-Position: refs/heads/master@{#36582} > > Committed: https://crrev.com/378a26c03efc74bda401daa5accda223cb266177 > Cr-Commit-Position: refs/heads/master@{#36606} TBR=vogelheim@chromium.org,bmeurer@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:474921 Review-Url: https://codereview.chromium.org/2026713002 Cr-Commit-Position: refs/heads/master@{#36616}

#7 id:180001 of https://codereview.chromium.org/2026633003/ ) Reason for revert: Also failing with the new implementation: https://build.chromium.org/p/chromium.gpu/builders/Linux%20Debug%20%28NVIDIA%29/builds/62646 Will do a local repro now. Original issue's description: > Track based on JSArrayBuffer addresses on pages instead of the attached > backing store. > > Details of tracking: > - Scavenge: New space pages are processes in bulk on the main thread > - MC: Unswept pages are processed in bulk in parallel. All other pages > are processed by the sweeper concurrently. > > BUG=chromium:611688 > LOG=N > TEST=cctest/test-array-buffer-tracker/* > CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg,v8_linux_gc_stress_dbg,v8_mac_gc_stress_dbg,v8_linux64_tsan_rel,v8_mac64_asan_rel > > Committed: https://crrev.com/279e274eccf95fbb4bd41d908b9153acf6ec118a > Cr-Commit-Position: refs/heads/master@{#36653} TBR=hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:611688 Review-Url: https://codereview.chromium.org/2032973002 Cr-Commit-Position: refs/heads/master@{#36663}

…ce objects. (patchset #7 id:120001 of https://codereview.chromium.org/2045263002/ ) Reason for revert: [Sheriff] Breaks arm debug: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm%20-%20sim%20-%20debug/builds/1038 Original issue's description: > [heap] Avoid the use of cells to point from code to new-space objects. > > Cells were needed originally because there was no typed remembered set to > record direct pointers from code space to new space. A previous > CL (https://codereview.chromium.org/2003553002/) already introduced > the remembered set, this CL uses it. > > This CL > * stores direct pointers in code objects, even if the target is in new space, > * records the slot of the pointer in typed-old-to-new remembered set, > * adds a list which stores weak code-to-new-space references, > * adds a test to test-heap.cc for weak code-to-new-space references, > * removes prints in tail-call-megatest.js > > R=ulan@chromium.org > > Committed: https://crrev.com/2d2087b79a293a92a6ed34a2775e481ff2173b3c > Cr-Commit-Position: refs/heads/master@{#37134} TBR=titzer@chromium.org,ulan@chromium.org,ahaas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2087463004 Cr-Commit-Position: refs/heads/master@{#37139}

Merged 05638b9 PPC/s390: [turbofan] Introduce Float64Pow and NumberPow operators. BUG=v8:3599,v8:5086,v8:5157 LOG=N NOTRY=true NOPRESUBMIT=true R=machenbach@chromium.org, jyan@ca.ibm.com Review-Url: https://codereview.chromium.org/2109503008 Cr-Commit-Position: refs/branch-heads/5.3@{#7} Cr-Branched-From: 820a23a-refs/heads/5.3.332@{#2} Cr-Branched-From: 37538cb-refs/heads/master@{#37308}

…0001 of https://codereview.chromium.org/2126613002/ ) Reason for revert: failing gc stress tests: https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/7223/steps/Mjsunit/logs/stdio Original issue's description: > [runtime] making heap verification more aggressive > > - check that packed elements do not contain the_hole (with fix) > - verify argument objects with elements kind > - use JSObjectVerifiy in all JSObject "subclasses" > - change initialization order for ArrayLiteralBoilerplate to simplify verification > > BUG=v8:5188 > > Committed: https://crrev.com/599aa2e106ca8ab79f5cc489d1b93b6a26b19714 > Cr-Commit-Position: refs/heads/master@{#37680} TBR=ishell@chromium.org,ulan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5188 Review-Url: https://codereview.chromium.org/2140163002 Cr-Commit-Position: refs/heads/master@{#37682}

id:140001 of https://codereview.chromium.org/2240463002/ ) Reason for revert: Failing on Win64 bot: https://build.chromium.org/p/client.v8/builders/V8%20Win64/builds/12061/steps/Check/logs/regress-635429 Original issue's description: > [Interpreter] Introduce InterpreterCompilationJob > > Adds InterpreterCompilationJob as a sub-class of > CompilationJob, to enable off-thread bytecode > generation. Currently only used in > Interpreter::MakeBytecode. > > As part of this change, CompilationJob is modified > to make it less specific to optimized compilation, > renaming the phases as follows: > - CreateGraph -> PrepareJob > - OptimizeGraph -> ExecuteJob > - GenerateCode -> FinalizeJob > > RegisterWeakObjectsInOptimizedCode is also moved out > of CompilationJob and instead becomes a static function > on Compiler. > > BUG=v8:5203 > > Committed: https://crrev.com/1fb6a7e697e8bc5b4af51647553741f966e00cdc > Cr-Commit-Position: refs/heads/master@{#38662} TBR=mstarzinger@chromium.org,jkummerow@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5203 Review-Url: https://codereview.chromium.org/2249153002 Cr-Commit-Position: refs/heads/master@{#38663}

id:140001 of https://codereview.chromium.org/2240463002/ ) Reason for revert: Breaks Win64 bot Original issue's description: > [Interpreter] Introduce InterpreterCompilationJob > > Adds InterpreterCompilationJob as a sub-class of > CompilationJob, to enable off-thread bytecode > generation. Currently only used in > Interpreter::MakeBytecode. > > As part of this change, CompilationJob is modified > to make it less specific to optimized compilation, > renaming the phases as follows: > - CreateGraph -> PrepareJob > - OptimizeGraph -> ExecuteJob > - GenerateCode -> FinalizeJob > > RegisterWeakObjectsInOptimizedCode is also moved out > of CompilationJob and instead becomes a static function > on Compiler. > > BUG=v8:5203 > > Committed: https://crrev.com/1fb6a7e697e8bc5b4af51647553741f966e00cdc > Committed: https://crrev.com/785990e9fc0dd9a9d963d25d0bed2909165e4ca9 > Cr-Original-Commit-Position: refs/heads/master@{#38662} > Cr-Commit-Position: refs/heads/master@{#38668} TBR=mstarzinger@chromium.org,jkummerow@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5203 Review-Url: https://codereview.chromium.org/2251673003 Cr-Commit-Position: refs/heads/master@{#38669}

Cr-Commit-Position: refs/branch-heads/5.4@{#7} Cr-Branched-From: 5ce2827-refs/heads/5.4.500@{#2} Cr-Branched-From: ad07b49-refs/heads/master@{#38841}

…oject#7 id:140001 of https://codereview.chromium.org/2785293002/ ) Reason for revert: http://crbug.com/v8/6198 Original issue's description: > [inspector] move console to builtins > > What will we get: > - console would be included into snapshot and allow us to reduce time that we spent in contextCreated function (~5 times faster), > - it allows us to make further small improvement of console methods, e.g. we can implement super quick return from console.assert if first argument is true, > - console calls are ~ 15% faster. > > BUG=v8:6175 > R=dgozman@chromium.org > > Review-Url: https://codereview.chromium.org/2785293002 > Cr-Original-Commit-Position: refs/heads/master@{#44353} > Committed: https://chromium.googlesource.com/v8/v8/+/55905f85d63d75aaa9313e51eb7bede754a8e41c > Review-Url: https://codereview.chromium.org/2785293002 > Cr-Commit-Position: refs/heads/master@{#44355} > Committed: https://chromium.googlesource.com/v8/v8/+/cc74ea0bc4fe4a71fa53d08b62cc18d15e01fbb3 TBR=dgozman@chromium.org,kozyatinskiy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:6175 Review-Url: https://codereview.chromium.org/2790343002 Cr-Commit-Position: refs/heads/master@{#44358}

Revision: 483812d BUG=chromium:708050 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true TBR=bmeurer@chromium.org Change-Id: Ib447c84f8ae37e6c16760a0ad716d59b08e55799 Reviewed-on: https://chromium-review.googlesource.com/476352 Reviewed-by: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/branch-heads/5.9@{crosswalk-project#7} Cr-Branched-From: fe9bb7e-refs/heads/5.9.211@{crosswalk-project#1} Cr-Branched-From: 70ad237-refs/heads/master@{#44591}

…rf regression. See crbug.co ... Revision: 5a04f4f BUG=chromium:695653 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true TBR=binji@chromium.org Review-Url: https://codereview.chromium.org/2725873004 . Cr-Commit-Position: refs/branch-heads/5.8@{crosswalk-project#7} Cr-Branched-From: eda659c-refs/heads/5.8.283@{crosswalk-project#1} Cr-Branched-From: 4310cd0-refs/heads/master@{#43429}

V8 profiling patch rebased on Chromium v34

0483117

darktears added a commit that referenced this pull request Mar 19, 2014

Merge pull request #7 from dp7/master

edd9fe8

V8 profiling patch re-based on Chromium v34

darktears merged commit edd9fe8 into crosswalk-project:master Mar 19, 2014

fenghaitao reviewed Mar 19, 2014
View reviewed changes

fenghaitao mentioned this pull request Mar 21, 2014

V8 profiling patch rebased on Chromium v34 #9

Closed

huningxin pushed a commit to huningxin/v8-crosswalk that referenced this pull request Apr 4, 2015

Merge pull request crosswalk-project#7 from huningxin/simd-m41-turbofan

2476752

Add check API

mrunalk pushed a commit that referenced this pull request Sep 27, 2016

Version 5.4.500.4

807ba33

Cr-Commit-Position: refs/branch-heads/5.4@{#7} Cr-Branched-From: 5ce2827-refs/heads/5.4.500@{#2} Cr-Branched-From: ad07b49-refs/heads/master@{#38841}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

V8 profiling patch re-based on Chromium v34 #7

V8 profiling patch re-based on Chromium v34 #7

dp7 commented Mar 19, 2014

darktears commented Mar 19, 2014

rakuco commented Mar 19, 2014

darktears commented Mar 19, 2014

darktears commented Mar 19, 2014

darktears commented Mar 19, 2014

fenghaitao Mar 19, 2014

V8 profiling patch re-based on Chromium v34 #7

V8 profiling patch re-based on Chromium v34 #7

Conversation

dp7 commented Mar 19, 2014

darktears commented Mar 19, 2014

rakuco commented Mar 19, 2014

darktears commented Mar 19, 2014

darktears commented Mar 19, 2014

darktears commented Mar 19, 2014

fenghaitao Mar 19, 2014

Choose a reason for hiding this comment