This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgtm |
darktears
added a commit
that referenced
this pull request
Mar 25, 2014
Fixed a limit for static initializers
mrunalk
pushed a commit
to mrunalk/v8-crosswalk
that referenced
this pull request
Feb 5, 2015
Merged 02218ad Report SyntaxError on Token::ILLEGAL in ParseTemplateLiteral BUG=v8:3820,v8:3821 LOG=N R=dslomov@chromium.org Review URL: https://codereview.chromium.org/861173005 Cr-Commit-Position: refs/branch-heads/4.1@{crosswalk-project#12} Cr-Branched-From: 2e08d2a-refs/heads/candidates@{#25353}
Bysmyyr
pushed a commit
to Bysmyyr/v8-crosswalk
that referenced
this pull request
Apr 1, 2015
Merged 8b33fa6 X87: Disallow subclassing Arrays. R=dslomov@chromium.org BUG= Review URL: https://codereview.chromium.org/1033463002 Cr-Commit-Position: refs/branch-heads/4.2@{crosswalk-project#12} Cr-Branched-From: 3dfd929-refs/heads/4.2.77@{crosswalk-project#2} Cr-Branched-From: e011092-refs/heads/master@{#26757}
Bysmyyr
pushed a commit
to Bysmyyr/v8-crosswalk
that referenced
this pull request
Apr 27, 2015
Merged 189b355 Filter out remembered slots that are at the start of an object. BUG=chromium:473174 LOG=N R=hpayer@chromium.org Review URL: https://codereview.chromium.org/1098673002 Cr-Commit-Position: refs/branch-heads/4.3@{crosswalk-project#12} Cr-Branched-From: f5c0a23-refs/heads/4.3.61@{#1} Cr-Branched-From: 0a7d4f4-refs/heads/master@{#27508}
Bysmyyr
pushed a commit
to Bysmyyr/v8-crosswalk
that referenced
this pull request
Jun 30, 2015
Merged 29715d7 Reland "Keep track of array buffers in new space separately" BUG=v8:3996 LOG=N TBR=hpayer@chromium.org Review URL: https://codereview.chromium.org/1188313006. Cr-Commit-Position: refs/branch-heads/4.4@{crosswalk-project#12} Cr-Branched-From: 2e4c550-refs/heads/4.4.63@{#1} Cr-Branched-From: 0208b8e-refs/heads/master@{#28333}
Bysmyyr
pushed a commit
to Bysmyyr/v8-crosswalk
that referenced
this pull request
Jul 10, 2015
…220001 of https://codereview.chromium.org/1131783003/) Reason for revert: Breaks Linux nosnap cctest/test-api/FastReturnValuesWithProfiler, see http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug%20-%202/builds/609/steps/Check/logs/FastReturnValuesWithP.. Original issue's description: > Add support for Embedded Constant Pools for PPC and Arm > > Embed constant pools within their corresponding Code > objects. > > This removes support for out-of-line constant pools in favor > of the new approach -- the main advantage being that it > eliminates the need to allocate and manage separate constant > pool array objects. > > Currently supported on PPC and ARM. Enabled by default on > PPC only. > > This yields a 6% improvment in Octane on PPC64. > > R=danno@chromium.org, svenpanne@chromium.org, bmeurer@chromium.org, rmcilroy@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com > BUG=chromium:478811 > LOG=Y > > Committed: https://crrev.com/a9404029343d65f146e3443f5280c40a97e736af > Cr-Commit-Position: refs/heads/master@{#28770} TBR=rmcilroy@chromium.org,ishell@chromium.org,rodolph.perfetta@arm.com,mbrandy@us.ibm.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:478811 Review URL: https://codereview.chromium.org/1155703006 Cr-Commit-Position: refs/heads/master@{#28772}
Bysmyyr
pushed a commit
to Bysmyyr/v8-crosswalk
that referenced
this pull request
Jul 10, 2015
…k-project#12 id:240001 of https://codereview.chromium.org/1133163005/) Reason for revert: Compile failure: https://chromegw.corp.google.com/i/client.v8/builders/V8%20Mac64%20-%20debug/builds/3070/steps/compile/logs/stdio Original issue's description: > MIPS64: Enable shorten-64-to-32 warning. > > Port cdc43bc > > Original commit message: > Enable clang's shorten-64-to-32 warning flag on ARM64, and fix the warnings > that arise. > > BUG= > > Committed: https://crrev.com/9af578a7c83b58a0ce25345998d9287cbf2030cb > Cr-Commit-Position: refs/heads/master@{#28990} TBR=danno@chromium.org,martyn.capewell@arm.com,paul.lind@imgtec.com,akos.palfi@imgtec.com,dusan.milosavljevic@imgtec.com,jkummerow@chromium.org,machenbach@chromium.org,svenpanne@chromium.org,balazs.kilvady@imgtec.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1182493007 Cr-Commit-Position: refs/heads/master@{#28991}
rakuco
pushed a commit
that referenced
this pull request
Aug 5, 2015
Merged 8233964 MIPS: Fix missing fallthru handling for some branch cases in TF. R=jkummerow@chromium.org BUG= Review URL: https://codereview.chromium.org/1242293004 . Cr-Commit-Position: refs/branch-heads/4.5@{#12} Cr-Branched-From: 7f21153-refs/heads/4.5.103@{#1} Cr-Branched-From: 4b38c15-refs/heads/master@{#29527}
mrunalk
pushed a commit
that referenced
this pull request
Sep 22, 2015
Merged a56f537 Merged 7a21a70 [heap] Cleanup and fix GC flags [heap] Thread through GC flags in memory reducer and incremental marking. BUG=chromium:520607 LOG=N R=hablich@chromium.org NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1314843010 Cr-Commit-Position: refs/branch-heads/4.6@{#12} Cr-Branched-From: 24d34a8-refs/heads/4.6.85@{#1} Cr-Branched-From: 8f44118-refs/heads/master@{#30256}
mrunalk
pushed a commit
that referenced
this pull request
Dec 18, 2015
Merged 086d459 [crankshaft] Loads and stores to typed arrays have to reference the backing store holder BUG=v8:1827 LOG=N TBR=hablich@chromium.org Review URL: https://codereview.chromium.org/1511433005 . Cr-Commit-Position: refs/branch-heads/4.8@{#12} Cr-Branched-From: 10449d4-refs/heads/4.8.271@{#1} Cr-Branched-From: 2ebd5fc-refs/heads/master@{#31941}
rakuco
pushed a commit
that referenced
this pull request
Mar 3, 2016
Merged cccb7e1 Value::IsObject should return true for proxies as well TBR=hablich@chromium.org BUG= Review URL: https://codereview.chromium.org/1611343003 . Cr-Commit-Position: refs/branch-heads/4.9@{#12} Cr-Branched-From: 2fea296-refs/heads/4.9.385@{#1} Cr-Branched-From: 0c1430a-refs/heads/master@{#33306}
mrunalk
pushed a commit
that referenced
this pull request
Apr 5, 2016
… id:220001 of https://codereview.chromium.org/1555553002/ ) Reason for revert: The random nature of the tests caused the following buildbot to fail: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20gcc%204.8/builds/4724/steps/Check/logs/stdio Original issue's description: > [profiler] Implement POC Sampling Heap Profiler > > This implements a proof-of-concept sampling based heap profiler inspired by > tcmalloc's heap profiler [1] and Go's mprof/memprofile [2]. > > The basic idea is the sample allocations using a randomized Poisson process. At > any point in time we can cheaply request the set of live sample objects that > should be a representative sample of heap. Samples include stack-traces from the > allocation sites, making this an effective tool for memory leak debugging. > > Unlike AllocationTracking, this is intended to be cheap and usable online in > production. > > The proof-of-concept is only sampling new-space allocations at this point. > Support for sampling paged space and native allocations is anticipated in the > future. > > [1] http://goog-perftools.sourceforge.net/doc/heap_profiler.html > [2] http://blog.golang.org/profiling-go-programs > > Committed: https://crrev.com/e5a9947811db9c9e23557dbad27f8b8a349b3262 > Cr-Commit-Position: refs/heads/master@{#33448} TBR=jochen@chromium.org,alph@chromium.org,hpayer@chromium.org,yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1615173002 Cr-Commit-Position: refs/heads/master@{#33449}
mrunalk
pushed a commit
that referenced
this pull request
Apr 5, 2016
…tchset #12 id:220001 of https://codereview.chromium.org/1555553002/ )" This reverts commit 77df865. BUG= Review URL: https://codereview.chromium.org/1618693004 Cr-Commit-Position: refs/heads/master@{#33473}
mrunalk
pushed a commit
that referenced
this pull request
Apr 5, 2016
…260001 of https://codereview.chromium.org/1563213002/ ) Reason for revert: FAilure on win32 bot, need to investigate webkit failures. Original issue's description: > Type Feedback Vector lives in the closure > > We get less "pollution" of type feedback if we have one vector per native > context, rather than one for the whole system. This CL moves the vector > appropriately. > > We rely more heavily on the Optimized Code Map in the SharedFunctionInfo. The > vector actually lives in the first slot of the literals array (indeed there is > great commonality between those arrays, they can be thought of as the same > thing). So we make greater effort to ensure there is a valid literals array > after compilation. > > This meant, for performance reasons, that we needed to extend > FastNewClosureStub to support creating closures with literals. And ultimately, > it drove us to move the optimized code map lookup out of FastNewClosureStub > and into the compile lazy builtin. > > The heap change is trivial so I TBR Hannes for it... > > TBR=hpayer@chromium.org > > BUG= > > Committed: https://crrev.com/a5200f7ed4d11c6b882fa667da7a1864226544b4 > Cr-Commit-Position: refs/heads/master@{#33518} TBR=bmeurer@chromium.org,akos.palfi@imgtec.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1632993003 Cr-Commit-Position: refs/heads/master@{#33520}
mrunalk
pushed a commit
that referenced
this pull request
Apr 5, 2016
Merged c268aea [turbofan] Unship try-catch. R=jkummerow@chromium.org, bmeurer@chromium.org BUG=v8:3566 LOG=Y Review URL: https://codereview.chromium.org/1768293002 . Cr-Commit-Position: refs/branch-heads/5.0@{#12} Cr-Branched-From: ad16e6c-refs/heads/5.0.71@{#1} Cr-Branched-From: bd9df50-refs/heads/master@{#34215}
mrunalk
pushed a commit
that referenced
this pull request
May 20, 2016
Merged d0151bf [heap] Don't use black pages for map, code and, lo space. Instead color objects black. BUG=chromium:599174 LOG=N R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1899193005 . Cr-Commit-Position: refs/branch-heads/5.1@{#12} Cr-Branched-From: 167dc63-refs/heads/5.1.281@{#1} Cr-Branched-From: 03953f5-refs/heads/master@{#35282}
mrunalk
pushed a commit
that referenced
this pull request
Jun 21, 2016
… of https://codereview.chromium.org/1858143003/ ) Reason for revert: [Sheriff] Breaks tsan: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/8999 Original issue's description: > Get rid of UnsafeCurrent in Sampler > > Currently we are using UnsafeCurrent in async signal handler to acquire the > isolate of VM thread, but we want to get rid of that since it prevents V8 from > being thread agnostic. > > This patch replaces UnsafeCurrent with a static map, where we store a map of > samplers for threads, and makes it accessible by signal handler. > > BUG=v8:4889 > LOG=n > > Committed: https://crrev.com/62fb4775fea0d56d8a175baf1d902213f6752168 > Cr-Commit-Position: refs/heads/master@{#35541} TBR=jochen@chromium.org,alph@chromium.org,fmeawad@chromium.org,yangguo@chromium.org,lpy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4889 Review URL: https://codereview.chromium.org/1897673002 Cr-Commit-Position: refs/heads/master@{#35545}
mrunalk
pushed a commit
that referenced
this pull request
Jun 21, 2016
mrunalk
pushed a commit
that referenced
this pull request
Aug 10, 2016
Merged d944015 Merged 43d0b7e Merged 90fa326 Merged 7a02c72 Merged 9a9ffd1 Merged 21550e0 Merged bf4ef54 X87: [builtins] Introduce proper Float64Tan operator. X87: [cleanup] Remove dead code from DeclareLookupSlot and rename it. X87: [builtins] NonNumberToNumber and StringToNumber now use CallRuntime instead of TailCallRuntime. X87: Reland: [Crankshaft] Always check for stubs marked to not require an eager frame. X87: disable some sin/cos/expm1/tan test cases for x87. X87: [RegisterConfiguration] Streamline access to arch defaults, simplify Registers. X87: disable test-gap-resolver/FuzzResolver test case for x87. R=hablich@chromium.org BUG= LOG=N NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2127683002 Cr-Commit-Position: refs/branch-heads/5.3@{#12} Cr-Branched-From: 820a23a-refs/heads/5.3.332@{#2} Cr-Branched-From: 37538cb-refs/heads/master@{#37308}
mrunalk
pushed a commit
that referenced
this pull request
Sep 27, 2016
…ttps://codereview.chromium.org/2193793002/ ) Reason for revert: Broke Node.js tests (test-require-dot etc.) Original issue's description: > Put Scopes into temporary Zone > > When parsing a eagerly-parsed-but-lazily-compiled function, we > used to put some of its AST nodes into a discardable Zone. This > CL puts the function Scope, its inner Scopes and the related AST > nodes (Declarations, VariableProxys) into the temporary Zone > too. This reduces peak memory usage and enables future work to > keep the temporary Zone around for later compilation. > > BUG= > > Committed: https://crrev.com/eaebdd858b466057ccc39894a172c9b66868e8f7 > Cr-Commit-Position: refs/heads/master@{#38232} TBR=adamk@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2205013002 Cr-Commit-Position: refs/heads/master@{#38258}
mrunalk
pushed a commit
that referenced
this pull request
Sep 27, 2016
Revision: f3bf8f9 R=hablich@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2290603004 Cr-Commit-Position: refs/branch-heads/5.4@{#12} Cr-Branched-From: 5ce2827-refs/heads/5.4.500@{#2} Cr-Branched-From: ad07b49-refs/heads/master@{#38841}
imreotto
pushed a commit
to tenta-browser/v8-crosswalk
that referenced
this pull request
Sep 4, 2017
Cr-Commit-Position: refs/branch-heads/5.9@{crosswalk-project#12} Cr-Branched-From: fe9bb7e-refs/heads/5.9.211@{crosswalk-project#1} Cr-Branched-From: 70ad237-refs/heads/master@{#44591}
asifhisam
pushed a commit
to asifhisam/v8-crosswalk
that referenced
this pull request
Sep 9, 2019
Cr-Commit-Position: refs/branch-heads/5.8@{crosswalk-project#12} Cr-Branched-From: eda659c-refs/heads/5.8.283@{crosswalk-project#1} Cr-Branched-From: 4310cd0-refs/heads/master@{#43429}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The XDK cpu profiler patch introduces one more static. This patch to make this check pass.