Skip to content

Commit

Permalink
Revert of Remove download_binaries.py from DEPS (patchset crosswalk-p…
Browse files Browse the repository at this point in the history
…roject#2 id:20001 of https://codereview.chromium.org/2774043002/ )

Reason for revert:
https://codereview.chromium.org/2775913002/ needs to be reverted, so reverting all dependent patch sets

Original issue's description:
> Remove download_binaries.py from DEPS
>
> This step is no longer necessary after https://codereview.chromium.org/2775913002/
>
> BUG=chromium:705072
>
> Review-Url: https://codereview.chromium.org/2774043002
> Cr-Commit-Position: refs/heads/master@{#44252}
> Committed: https://chromium.googlesource.com/v8/v8/+/459b881c233557f5da9ca9e4779fc1696c785a1c

TBR=machenbach@chromium.org,thomasanderson@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:705072

Review-Url: https://codereview.chromium.org/2786173004
Cr-Commit-Position: refs/heads/master@{#44289}
  • Loading branch information
tanderson-google authored and Commit bot committed Mar 31, 2017
1 parent 776d89f commit 3b72184
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ deps = {
"v8/third_party/icu":
Var("chromium_url") + "/chromium/deps/icu.git" + "@" + "450be73c9ee8ae29d43d4fdc82febb2a5f62bfb5",
"v8/third_party/instrumented_libraries":
Var("chromium_url") + "/chromium/src/third_party/instrumented_libraries.git" + "@" + "61065eb0db191f46bdea202e833f5cd1f1ecedcd",
Var("chromium_url") + "/chromium/src/third_party/instrumented_libraries.git" + "@" + "48dcb2c2397ce4fbb49f9461638a32ccf2c84ce5",
"v8/buildtools":
Var("chromium_url") + "/chromium/buildtools.git" + "@" + "e6b510a9daf822bbe9f922c200c58150803d2fd8",
"v8/base/trace_event/common":
Expand Down Expand Up @@ -250,6 +250,16 @@ hooks = [
'--running-as-hook',
],
},
{
# Pull sanitizer-instrumented third-party libraries if requested via
# GYP_DEFINES.
'name': 'instrumented_libraries',
'pattern': '\\.sha1',
'action': [
'python',
'v8/third_party/instrumented_libraries/scripts/download_binaries.py',
],
},
{
# Update the Windows toolchain if necessary.
'name': 'win_toolchain',
Expand Down

0 comments on commit 3b72184

Please sign in to comment.