Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fb sync ufs #597

Merged
merged 30 commits into from
Jan 27, 2022
Merged

Fb sync ufs #597

merged 30 commits into from
Jan 27, 2022

Conversation

aliabdolali
Copy link
Contributor

Pull Request Summary

merge develop to dev/ufs-weather-model

Description

Update the dev/ufs-weather-model to the top of develop

Commit Message

sync develop and dev/ufs-weather-model

Check list

Testing

  • How were these changes tested? N/A
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) N/A
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)? N/A
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):
  • Please indicate the expected changes in the regression test output (Note the known list of non-identical tests).
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

JessicaMeixner-NOAA and others added 30 commits October 19, 2021 09:49
@JessicaMeixner-NOAA
Use CPP instead of Switches (NOAA-EMC#476)
dd31794 
Use CPP ifdefs instead of switches for pre-processing and convert all code from ftn to F90 files. (ftn->src) 
The tools for converting ftn->src can be found in the model/tools directory.
@JessicaMeixner-NOAA
Version 7.14: switch from ftn/*.ftn to src/*.F90 by using CPP ifdefs (N…
cb5d2b4 
…OAA-EMC#511)

Updated version number to 7.14
@MatthewMasarik-NOAA
Modify: w3wavemd.F90, w3initmd.F90 - fix for OUTID (NOAA-EMC#512)
aed0e73 
bugfix: OUTID length adjusted for secondary restarts.
@ukmo-ccbunney
Staging/UKMO Oct 2021 (NOAA-EMC#499)
ad51140 
Bugfix/FLX5 Tau 
Small bugfix to variable INTENT
@JessicaMeixner-NOAA
update to protect a divide by zero in ST4 (NOAA-EMC#519)
b3462ba 
Protect a possible divide by zero ustar in w3src4
@JessicaMeixner-NOAA
in w3scat pass info for mapsta.ne.0 this will pass information for (N…
1f8ef83 
…OAA-EMC#518)

Update w3scat to update values of VA for MAPSTA.ne.0 which solves some mpi reproducibility issues.
@JessicaMeixner-NOAA
updates for jet (NOAA-EMC#529)
c702032 
Update for jet specific compiler flags
@aliabdolali
Fix knint (NOAA-EMC#532)
46b0d18 
Portability fix for all compiler options in ww3_grib (KNINT > NINT)
@aliabdolali
Fb update issue temp (NOAA-EMC#507)
bf41d9b 
update issue, discussion and PR templates
@JessicaMeixner-NOAA
Add switch ifdefs for wmesmf SCRIP (NOAA-EMC#537)
349751a 
Add SCRIP ifdefs for wmesmf
@JessicaMeixner-NOAA
remove w3netcdf.F90 and associated debug messages that are not active…
77319a1 
…ly used (NOAA-EMC#535)

remove unused w3netcdf code
@JessicaMeixner-NOAA
Clean up of W3UICE routine (NOAA-EMC#534)
b629d2f 
Clean up W3UICE subroutine
@aliabdolali
Bf test.comp (NOAA-EMC#545)
3016ed3 
fix for test.comp and matrix.comp
@ukmo-nievesvaliente
Fixed typo in call to OASACM switch. (NOAA-EMC#548)
22e1915 
Bugfix; fixed typo in call to OASACM switch.
@MatthewMasarik-NOAA
cmplr.env: err_pattern fix for false positive grep with scrip_errormo…
bc17f1f 
…d.F90 (NOAA-EMC#555)

scrip_errormod.f90: fixes build failure due to 'error' substring in file name
@ukmo-ccbunney
Fix overlapping internal write of INSTR in w3ounfmetamd (NOAA-EMC#558)
5f801f8
@ukmo-ccbunney
Fixed incorrect ordering of TAU and RHOAIR fields in ww3_shel.nml fie…
59dd939 
…ld output table. (NOAA-EMC#559)
@ukmo-ccbunney
Fix incorrect field index for ICEF (NOAA-EMC#561)
c68b12c
@aliabdolali
Fix ww3 tr1 (NOAA-EMC#563)
14d536c 
bug fix: zero initialization to ISBPO
@aronroland
Scal xyb (NOAA-EMC#556)
7e006d9
@ukmo-ccbunney
[ww3_ounp] TIMESPLIT=0 support (NOAA-EMC#569)
12a4e80 
Add TIMESPLIT=0 (no date string) support for ww3_ounp.
@JessicaMeixner-NOAA
removing BT2 which is not used (NOAA-EMC#584)
280f408 
Remove BT2 switch
@JessicaMeixner-NOAA
code changes needed for cmake to pass (NOAA-EMC#582)
a4768f8 
Minor bug fixes dealing with MPI variables.
@MatthewMasarik-NOAA
Memory leak: w3iorsmd.F90 (NOAA-EMC#583)
a0a48ee 
w3iorsmd: fixes memory leaks in the restart module
@MatthewMasarik-NOAA
Doxygen header templates (NOAA-EMC#585)
d95482a 
ww3_doxy_tmpl.md: add doxygen header templates
@MatthewMasarik-NOAA
ww3_doxy_tmpl.md: small updates (NOAA-EMC#593)
f41c73e 
ww3_doxy_tmpl.md: update headers
@junwang-noaa @aliabdolali
Support ESMF-managed-threading by making generic SetVM public. (NOAA-…
54d74a5 
…EMC#587)

 make the SetVM public
@DeniseWorthen @aliabdolali
allow mask variables to be retrieved (NOAA-EMC#588)
7acc63f 
Retrieve mask_value_water and mask_value_land if present in nems.configure and med_present is true.
2c3a2e1
922a65c
This was referenced Jan 25, 2022
Closed
Merged
JessicaMeixner-NOAA
JessicaMeixner-NOAA approved these changes Jan 27, 2022
View reviewed changes
Copy link
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a clone of this branch and develop are the exact same and ufs-weather-model rts are passing

@JessicaMeixner-NOAA JessicaMeixner-NOAA merged commit bba5df0 into NOAA-EMC:dev/ufs-weather-model Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JessicaMeixner-NOAA JessicaMeixner-NOAA JessicaMeixner-NOAA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@aliabdolali @JessicaMeixner-NOAA @MatthewMasarik-NOAA @ukmo-ccbunney @ukmo-nievesvaliente @aronroland @junwang-noaa @DeniseWorthen