-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix knint #532
Fix knint #532
Conversation
to ensure they comply with the limits of the nameslist.
Changes to add support to 360-day and 365-day (no leap year) calendar - see ticket #209 * Additional CALTYPE namelist parameter in MISC section * New ww3_tc1 regtest.
* Updated ww3_bound and ww3_bounc to handle model grids formulated on a rotated pole. * Manual and nml/inp files to updated clarify that ww3_bound/ww3_bounc only accept input spectra formulated on a standard pole grid.
Updates to allow a coupling time step that is different from the model time step. * Includes new regtest (in ww3_tp2.14) for non-default oasis time step. * ww3_tp2.14 regtest added to matrix.base.
This reverts commit 6efe9bb.
Hi @kgerheiser |
Yep, I was able to compile with this change using GCC 9.4.0 on my local macOS machine. |
I don't really know how WW3 tests work, but is your test log showing differences in output? I wouldn't expect this change to affect results. |
Hi @ukmo-ccbunney |
Hi @aliabdolali - so, this now compiles for me (the KNINT -> NINT fix works for me), but it fails to link. opt="$opt -convert big_endian -assume byterecl -prec-div -prec-sqrt -ip" I believe these options are Intel IFORT specific, so I needed to modify these for the GNU compiler. Additionally, I need to compile the relevant grib/bacio/g2lib libraries to get this regtest to actually compile (link) for me (we don't routinely use grib with the wave model). However, I am going to approve this PR as the fix for KNINT looks to be working OK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KNINT fix worked for me.
I am struggling to test the ww3_tp2.17 regtest at the moment though due to other issues described in this PR's comments.
Pull Request Summary
replace KNINT with NINT to be compatible with all compiler options.
Description
The
knint
in model/src/ww3_grib.F90 routine is an Intel extension and does not work with GNU compilers.Replacing it with
nint
makes it generic, compatible with GNU and INTEL.Is a change of answers expected from this PR? NO
Issue(s) addressed
Check list
Is your feature branch up to date with the authoritative repository (NOAA/develop)? Yes
Make sure you have checked the checklist for a developer submitting to develop and updating version number
Please list appropriate labels code managers should add for this PR:
bug
Reviewers: @kgerheiser
Commit Message
Testing
matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt