Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in call to OASACM switch. #548

Merged
merged 2 commits into from
Dec 5, 2021

Conversation

ukmo-nievesvaliente
Copy link
Collaborator

@ukmo-nievesvaliente ukmo-nievesvaliente commented Nov 29, 2021

Pull Request Summary

Small bugfix in ww3_shel that shows up when coupling air density.

Description

It fixes a bug in ww3_shel when coupling air density. When calling the air density there is a typo that says "#ifdef W3_OASASCM" and it should be "#ifdef W3_OASACM".

No changes in regtests are expected.

Issue(s) addressed

Commit Message

Bugfix; fixed typo in call to OASACM switch.

Check list

  • [Yes ] Branch is up to date with the authoritative repository (NOAA-EMC) develop branch.
  • [Done ] Checked the checklist for a developer submitting to develop.
  • [Not applicable] If a version number update is required, checked the updating version number checklist.
  • [Not applicable] If a new feature was added, a regression test for testing the new feature is added.

Testing

  • How were these changes tested?
    Regtests.
  • Are the changes covered by regression tests? No. There is no regtest that tests the air density as a coupled field.
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)? Yes. Cray compiler in the CrayXC40 HPC at the Met Office.
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):
  • Please indicate the expected changes in the regression test output (Note the known list of non-identical tests). None.
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):
    matrixCompFull.txt
    matrixDiff.txt
    matrixCompSummary.txt

@ukmo-nievesvaliente ukmo-nievesvaliente marked this pull request as ready for review December 1, 2021 16:30
@ukmo-ccbunney ukmo-ccbunney added the bug Something isn't working label Dec 4, 2021
@aliabdolali aliabdolali self-requested a review December 5, 2021 04:51
@aliabdolali aliabdolali merged commit 22e1915 into NOAA-EMC:develop Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants