Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fb sync ufs #597

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
dd31794
Use CPP instead of Switches (#476)
JessicaMeixner-NOAA Oct 19, 2021
cb5d2b4
Version 7.14: switch from ftn/*.ftn to src/*.F90 by using CPP ifdefs …
JessicaMeixner-NOAA Nov 2, 2021
aed0e73
Modify: w3wavemd.F90, w3initmd.F90 - fix for OUTID (#512)
MatthewMasarik-NOAA Nov 2, 2021
ad51140
Staging/UKMO Oct 2021 (#499)
ukmo-ccbunney Nov 5, 2021
b3462ba
update to protect a divide by zero in ST4 (#519)
JessicaMeixner-NOAA Nov 5, 2021
1f8ef83
in w3scat pass info for mapsta.ne.0 this will pass information for (#…
JessicaMeixner-NOAA Nov 5, 2021
c702032
updates for jet (#529)
JessicaMeixner-NOAA Nov 15, 2021
46b0d18
Fix knint (#532)
aliabdolali Nov 17, 2021
bf41d9b
Fb update issue temp (#507)
aliabdolali Nov 19, 2021
349751a
Add switch ifdefs for wmesmf SCRIP (#537)
JessicaMeixner-NOAA Nov 19, 2021
77319a1
remove w3netcdf.F90 and associated debug messages that are not active…
JessicaMeixner-NOAA Nov 22, 2021
b629d2f
Clean up of W3UICE routine (#534)
JessicaMeixner-NOAA Nov 22, 2021
3016ed3
Bf test.comp (#545)
aliabdolali Nov 30, 2021
22e1915
Fixed typo in call to OASACM switch. (#548)
ukmo-nievesvaliente Dec 5, 2021
bc17f1f
cmplr.env: err_pattern fix for false positive grep with scrip_errormo…
MatthewMasarik-NOAA Dec 9, 2021
5f801f8
Fix overlapping internal write of INSTR in w3ounfmetamd (#558)
ukmo-ccbunney Dec 15, 2021
59dd939
Fixed incorrect ordering of TAU and RHOAIR fields in ww3_shel.nml fie…
ukmo-ccbunney Dec 15, 2021
c68b12c
Fix incorrect field index for ICEF (#561)
ukmo-ccbunney Dec 20, 2021
14d536c
Fix ww3 tr1 (#563)
aliabdolali Dec 23, 2021
7e006d9
Scal xyb (#556)
aronroland Dec 30, 2021
12a4e80
[ww3_ounp] TIMESPLIT=0 support (#569)
ukmo-ccbunney Jan 11, 2022
280f408
removing BT2 which is not used (#584)
JessicaMeixner-NOAA Jan 18, 2022
a4768f8
code changes needed for cmake to pass (#582)
JessicaMeixner-NOAA Jan 18, 2022
a0a48ee
Memory leak: w3iorsmd.F90 (#583)
MatthewMasarik-NOAA Jan 24, 2022
d95482a
Doxygen header templates (#585)
MatthewMasarik-NOAA Jan 24, 2022
f41c73e
ww3_doxy_tmpl.md: small updates (#593)
MatthewMasarik-NOAA Jan 24, 2022
54d74a5
Support ESMF-managed-threading by making generic SetVM public. (#587)
junwang-noaa Jan 24, 2022
7acc63f
allow mask variables to be retrieved (#588)
DeniseWorthen Jan 24, 2022
2c3a2e1
Jan 25, 2022
922a65c
Jan 25, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions .github/ISSUE_TEMPLATE/add-development-request.md

This file was deleted.

4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
name: Bug report
about: Create a report to help us improve WW3
about: Create a bug report to help us improve WW3
title: ''
labels: 'bug'
assignees: ''
Expand All @@ -11,7 +11,7 @@ assignees: ''
A clear and concise description of what the bug is.

**To Reproduce**
Steps to reproduce the behavior:
Steps to reproduce the behavior.

**Expected behavior**
A clear and concise description of what you expected to happen.
Expand Down
8 changes: 8 additions & 0 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
blank_issues_enabled: true
contact_links:
- name: Q&A about using WW3
url: https://github.com/NOAA-EMC/WW3/discussions/new?category=q-a
about: Ask the community for help
- name: General
url: https://github.com/NOAA-EMC/WW3/discussions/new?category=general
about: Chat about anything and everything here
9 changes: 3 additions & 6 deletions .github/ISSUE_TEMPLATE/documentation.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,12 @@
---
name: Documentation request/update
about: Add new section in the documentation or report a type/mistake in the documentation
name: Documentation
about: Any issues in documentation including reporting a typo/mistake in the documentation or a missing section.
title: ''
labels: 'documentation'
assignees: ''

---

**Describe the section in the documentation that is missing or requires an update?**
<!-- Describe the section in the documentation that is missing or requires an update? -->

**Report a bug/typo in the documentation**

**Link the issue(s) associated with this documentation update**

48 changes: 26 additions & 22 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,41 +1,45 @@
# Pull Request Summary
(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Please describe the PR summary
<!-- A short overview of the PR -->

## Description
<!--
Provide a detailed description of what this PR does.
What bug does it fix, or what feature does it add?
Is a change of answers expected from this PR?

### Issue(s) addressed
* Is there an issue associated with this development (bug fix, enhancement, new feature)?
Please add a reference to a related issue(s) in WW3 repository (Follow [link](https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue)).
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!).
Note that properly "linked issues" (either automatic links, or manual ones using the correct keywords) will be automatically closed when the PR is merged.
Please also include the following information:
* Add any suggestions for a reviewer
* Mention any labels that should be added: _bug_, _documentation_, _enhancement_, _new feature_
* Are answer changes expected from this PR? Please describe the changes and the reason why in addition to which of the following labels would apply: _mod_def change_, _out_grd change_, _out_pnt change_, _restart file change_, _Regression test_
-->

### Issue(s) addressed
<!--
* Please list any issues associated with this PR, including those the PR will fix/close. For example:
- fixes #<issue_number>
- fixes noaa-emc/ww3/issues/<issue_number>
-->

### Commit Message
<!--
Please provide a short summary of this PR, which will be used during _Squash and Merge_ and will be shown as a git log message. Be sure to add any co-authors here.
-->

### Check list
* Is your feature branch up to date with the authoritative repository (NOAA/develop)?
* Make sure you have checked the [checklist for a developer submitting to develop](https://github.com/NOAA-EMC/WW3/wiki/Code-Management#checklist-for-a-developer-submitting-to-develop) and [updating version number](https://github.com/NOAA-EMC/WW3/wiki/Code-Management#checklist-for-updating-version-number)
* Please list appropriate labels code managers should add for this PR:
_bug_, _documentation_, _enhancement_, _new feature_, ..

* Reviewers: @mentions of suggested reviewers of the proposed changes

### Commit Message
* Please provide a short summary of this PR, which will be used during _Squash and Merge_ and will be shown as git log message
<!-- After creating the PR you can check each of the items below that have been completed -->

- [ ] Branch is up to date with the authoritative repository (NOAA-EMC) develop branch.
- [ ] Checked the [checklist for a developer submitting to develop](https://github.com/NOAA-EMC/WW3/wiki/Code-Management#checklist-for-a-developer-submitting-to-develop).
- [ ] If a version number update is required, checked the [updating version number](https://github.com/NOAA-EMC/WW3/wiki/Code-Management#checklist-for-updating-version-number) checklist.
- [ ] If a new feature was added, a regression test for testing the new feature is added.

### Testing

* How were these changes tested?
* Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
* If a new feature was added, was a new regression test added?
* Have regression tests been run?
* Which compiler / HPC you used to run the regression tests in the PR?
* Have the matrix regression tests been run (if yes, please note HPC and compiler)?
* Please provide the summary output of matrix.comp (_matrix.Diff.txt_, _matrixCompFull.txt_ and _matrixCompSummary.txt_):
Please indicate the expected changes in the outputs ([excluding the known list of non-identical tests](https://github.com/NOAA-EMC/WW3/wiki/How-to-use-matrix.comp-to-compare-regtests-with-master#4-look-at-results)).
* Please list which labels code managers should add to indicate code changes:
_mod_def change_, _out_grd change_, _out_pnt change_, _restart file change_, _Regression test_, ...
* Please indicate the expected changes in the regression test output ([Note the known list of non-identical tests](https://github.com/NOAA-EMC/WW3/wiki/How-to-use-matrix.comp-to-compare-regtests-with-master#4-look-at-results)).
* Please provide the summary output of matrix.comp (_matrix.Diff.txt_, _matrixCompFull.txt_ and _matrixCompSummary.txt_):

Loading