Modify: w3wavemd.F90, w3initmd.F90 - fix for OUTID #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here are the outputs of matrix.comp. Besides pre-known non-b4b cases, there are expected changes in log files for all the tests as follow: |
aliabdolali
approved these changes
Nov 2, 2021
16 tasks
JessicaMeixner-NOAA
pushed a commit
that referenced
this pull request
Nov 17, 2021
bugfix: OUTID length adjusted for secondary restarts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Fix for character array position access beyond it's declared length.
Description
The character array variable, OUTID, is used to annotate columns of the action table in log file output. It is declared with length=13 in w3wavemd.F90, though later in the same file index=15 is accessed, which causes a fatal error when running in debug mode. This bug is fixed by declaring OUTID to be length=16. All accesses are then within the array, and the chosen length also gives the correct positioning within a newly added column (r2) for secondary restart streams.
Issue(s) addressed
Check list
Is your feature branch up to date with the authoritative repository (NOAA/develop)?
Make sure you have checked the [checklist for a developer submitting to develop].
Please list appropriate labels code managers should add for this PR:
Reviewers: @aliabdolali , @JessicaMeixner-NOAA
Commit Message
bugfix: OUTID length adjusted for secondary restarts.
Testing
How were these changes tested?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
If a new feature was added, was a new regression test added?
Have regression tests been run?
Which compiler / HPC you used to run the regression tests in the PR?
Please provide the summary output of matrix.comp:
matrix12.out.debug.dev.txt
matrix12.out.debug.fix.txt
matrixCompSummary.txt
matrixCompFull.txt