-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add switch ifdefs for wmesmf SCRIP #537
Add switch ifdefs for wmesmf SCRIP #537
Conversation
Use CPP ifdefs instead of switches for pre-processing and convert all code from ftn to F90 files. (ftn->src) The tools for converting ftn->src can be found in the model/tools directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this was raised for the CMake build and ww3_multi _esmf. Did you test the ufs-weather-model with the changes? considering SCRIP is in the switch, it might be unnecessary.
I only tested in ufs-weather-model on a test that I knew did not use SCRIP and I removed SCRIP and SCRIPNC. As reported in the PR, this test succeeded. I did not run a full test in ufs-weather-model without changes. I can do that now. |
that would be great, then we can proceed with the merge once WW3 regtests outputs are ready (tonight) |
@aliabdolali I ran ufs-weather-model with the wrong WW3 branch, so I'll have to re-do these tests today. I'll post results when I have them. |
I have the following changes: ********************* non-identical cases **************************** mww3_test_03/./work_PR2_UQ_MPI_d2 (6 files differ) I need to do further analysis, something is wrong. I'll let you know. |
That is indeed strange as the regression tests should have no impact with this change. I'll run some tests too. |
Here are the outputs of my comparison, with just pre-known not b4b cases *``` ********************* non-identical cases **************************** mww3_test_03/./work_PR2_UQ_MPI_d2 (6 files differ)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can merge it once the ufs-weather-model passed
Okay- the ufs-weather-model waves tests run on hera: /scratch2/NCEPDEV/climate/Jessica.Meixner/PR_WW3/scrip/ufs-weather-model/tests/RegressionTests_hera.intel.log (I tried to copy it here but my hera window is temporarily acting up and I couldn't get the transfer to work). They even work without the other fix if you don't have "error" int he directory name that will trigger warning messages as errors (oops). |
Pull Request Summary
Adding switch ifdefs for scrip in wmesmf
Description
When the addition of corner points was added, we used scrip subroutines but did not add the switch ifdefs. These add the ifdefs. There is no expected answer changes for this, but it should solve the issues of compiling wmesmf without the SCRIP switch.
Issue(s) addressed
Check list
Is your feature branch up to date with the authoritative repository (NOAA/develop)? yes
Make sure you have checked the checklist for a developer submitting to develop and updating version number no version number increase
Please list appropriate labels code managers should add for this PR:
bug
Reviewers: @aliabdolali @uturuncoglu
Commit Message
Testing
Please indicate the expected changes in the outputs (excluding the known list of non-identical tests).
No code changes.